| Message ID | 20190209090106.GB4865@kadam (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 320f07b4a92216aa313680e3c7c7d325d8642715 |
| Headers | show |
| Series | Input: msm: Tweak an error message | expand |
On Sat, Feb 09, 2019 at 12:01:06PM +0300, Dan Carpenter wrote: > The PTR_ERR(NULL) value is zero and it's not useful to print that. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied, thank you. > --- > drivers/input/misc/msm-vibrator.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/misc/msm-vibrator.c b/drivers/input/misc/msm-vibrator.c > index c06941021447..69f2579c4ec2 100644 > --- a/drivers/input/misc/msm-vibrator.c > +++ b/drivers/input/misc/msm-vibrator.c > @@ -199,8 +199,7 @@ static int msm_vibrator_probe(struct platform_device *pdev) > vibrator->base = devm_ioremap(&pdev->dev, res->start, > resource_size(res)); > if (!vibrator->base) { > - dev_err(&pdev->dev, "Failed to iomap resource: %ld\n", > - PTR_ERR(vibrator->base)); > + dev_err(&pdev->dev, "Failed to iomap resource.\n"); > return -ENOMEM; > } > > -- > 2.17.1 >
diff --git a/drivers/input/misc/msm-vibrator.c b/drivers/input/misc/msm-vibrator.c index c06941021447..69f2579c4ec2 100644 --- a/drivers/input/misc/msm-vibrator.c +++ b/drivers/input/misc/msm-vibrator.c @@ -199,8 +199,7 @@ static int msm_vibrator_probe(struct platform_device *pdev) vibrator->base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!vibrator->base) { - dev_err(&pdev->dev, "Failed to iomap resource: %ld\n", - PTR_ERR(vibrator->base)); + dev_err(&pdev->dev, "Failed to iomap resource.\n"); return -ENOMEM; }
The PTR_ERR(NULL) value is zero and it's not useful to print that. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/input/misc/msm-vibrator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)