| Message ID | 20190211222555.GA5472@embeddedor (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4e116e93f4fbd1b5f0e800d312d62d1917370d1a |
| Headers | show |
| Series | Input: mark expected switch fall-through | expand |
On Mon, Feb 11, 2019 at 04:25:55PM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/input/joystick/db9.c: In function ‘db9_saturn_read_packet’: > drivers/input/joystick/db9.c:256:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (tmp == 0xff) { > ^ > drivers/input/joystick/db9.c:263:2: note: here > default: > ^~~~~~~ > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied, thank you. > --- > drivers/input/joystick/db9.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c > index 804b1b80a8be..5a52b65bef9a 100644 > --- a/drivers/input/joystick/db9.c > +++ b/drivers/input/joystick/db9.c > @@ -259,7 +259,7 @@ static unsigned char db9_saturn_read_packet(struct parport *port, unsigned char > db9_saturn_write_sub(port, type, 3, powered, 0); > return data[0] = 0xe3; > } > - /* else: fall through */ > + /* fall through */ > default: > return data[0]; > } > -- > 2.20.1 >
On 2/11/19 4:48 PM, Dmitry Torokhov wrote: > On Mon, Feb 11, 2019 at 04:25:55PM -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/input/joystick/db9.c: In function ‘db9_saturn_read_packet’: >> drivers/input/joystick/db9.c:256:6: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if (tmp == 0xff) { >> ^ >> drivers/input/joystick/db9.c:263:2: note: here >> default: >> ^~~~~~~ >> >> Notice that, in this particular case, the code comment is modified >> in accordance with what GCC is expecting to find. >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied, thank you. > Thanks, Dmitry. -- Gustavo
diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c index 804b1b80a8be..5a52b65bef9a 100644 --- a/drivers/input/joystick/db9.c +++ b/drivers/input/joystick/db9.c @@ -259,7 +259,7 @@ static unsigned char db9_saturn_read_packet(struct parport *port, unsigned char db9_saturn_write_sub(port, type, 3, powered, 0); return data[0] = 0xe3; } - /* else: fall through */ + /* fall through */ default: return data[0]; }
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/input/joystick/db9.c: In function ‘db9_saturn_read_packet’: drivers/input/joystick/db9.c:256:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (tmp == 0xff) { ^ drivers/input/joystick/db9.c:263:2: note: here default: ^~~~~~~ Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/input/joystick/db9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)