| Message ID | 20190201094736.32057-3-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mfd: add support for max77650 PMIC | expand |
Hi! > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > new file mode 100644 > index 000000000000..f3e00d41e299 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > @@ -0,0 +1,27 @@ > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > + > +This module is part of the MAX77650 MFD device. For more details > +see Documentation/devicetree/bindings/mfd/max77650.txt. > + > +The charger is represented as a sub-node of the PMIC node on the device tree. > + > +Required properties: > +-------------------- > +- compatible: Must be "maxim,max77650-charger" > + > +Optional properties: > +-------------------- > +- maxim,vchgin-min: Minimum CHGIN regulation voltage (in microvolts). Must be > + one of: 4000000, 4100000, 4200000, 4300000, 4400000, > + 4500000, 4600000, 4700000. > +- maxim,ichgin-lim: CHGIN input current limit (in microamps). Must be one of: > + 95000, 190000, 285000, 380000, 475000. We already have richtek,min-input-voltage-regulation and ti,minimum-sys-voltage and ti,in-dpm-voltage. This is not too consistent with with the rest.. and perhaps common name should be used for those? See also ti,current-limit. That seems to be direct match. Best regards, Pavel
wt., 12 lut 2019 o 12:54 Pavel Machek <pavel@ucw.cz> napisał(a): > > Hi! > > > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > new file mode 100644 > > index 000000000000..f3e00d41e299 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > @@ -0,0 +1,27 @@ > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > + > > +This module is part of the MAX77650 MFD device. For more details > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > + > > +The charger is represented as a sub-node of the PMIC node on the device tree. > > + > > +Required properties: > > +-------------------- > > +- compatible: Must be "maxim,max77650-charger" > > + > > +Optional properties: > > +-------------------- > > +- maxim,vchgin-min: Minimum CHGIN regulation voltage (in microvolts). Must be > > + one of: 4000000, 4100000, 4200000, 4300000, 4400000, > > + 4500000, 4600000, 4700000. > > +- maxim,ichgin-lim: CHGIN input current limit (in microamps). Must be one of: > > + 95000, 190000, 285000, 380000, 475000. > > We already have richtek,min-input-voltage-regulation and > ti,minimum-sys-voltage and ti,in-dpm-voltage. > > This is not too consistent with with the rest.. and perhaps common > name should be used for those? > > See also ti,current-limit. That seems to be direct match. > Well I can't really use a TI-specific property name on a maxim part, can I? Bart PS This version was superseded by v4.
On Tue 2019-02-12 14:28:10, Bartosz Golaszewski wrote: > wt., 12 lut 2019 o 12:54 Pavel Machek <pavel@ucw.cz> napisał(a): > > > > Hi! > > > > > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > new file mode 100644 > > > index 000000000000..f3e00d41e299 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > @@ -0,0 +1,27 @@ > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > > + > > > +This module is part of the MAX77650 MFD device. For more details > > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > > + > > > +The charger is represented as a sub-node of the PMIC node on the device tree. > > > + > > > +Required properties: > > > +-------------------- > > > +- compatible: Must be "maxim,max77650-charger" > > > + > > > +Optional properties: > > > +-------------------- > > > +- maxim,vchgin-min: Minimum CHGIN regulation voltage (in microvolts). Must be > > > + one of: 4000000, 4100000, 4200000, 4300000, 4400000, > > > + 4500000, 4600000, 4700000. > > > +- maxim,ichgin-lim: CHGIN input current limit (in microamps). Must be one of: > > > + 95000, 190000, 285000, 380000, 475000. > > > > We already have richtek,min-input-voltage-regulation and > > ti,minimum-sys-voltage and ti,in-dpm-voltage. > > > > This is not too consistent with with the rest.. and perhaps common > > name should be used for those? > > > > See also ti,current-limit. That seems to be direct match. > > > > Well I can't really use a TI-specific property name on a maxim part, can I? Well, I'm saying that you should introduce common names for common stuff. "current-limit" sounds like reasonable name. Pavel
diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file mode 100644 index 000000000000..f3e00d41e299 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt @@ -0,0 +1,27 @@ +Battery charger driver for MAX77650 PMIC from Maxim Integrated. + +This module is part of the MAX77650 MFD device. For more details +see Documentation/devicetree/bindings/mfd/max77650.txt. + +The charger is represented as a sub-node of the PMIC node on the device tree. + +Required properties: +-------------------- +- compatible: Must be "maxim,max77650-charger" + +Optional properties: +-------------------- +- maxim,vchgin-min: Minimum CHGIN regulation voltage (in microvolts). Must be + one of: 4000000, 4100000, 4200000, 4300000, 4400000, + 4500000, 4600000, 4700000. +- maxim,ichgin-lim: CHGIN input current limit (in microamps). Must be one of: + 95000, 190000, 285000, 380000, 475000. + +Example: +-------- + + charger { + compatible = "maxim,max77650-charger"; + maxim,vchgin-min = <4200000>; + maxim,ichgin-lim = <285000>; + };