| Message ID | 20190211220738.GA5955@embeddedor (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (f71882fg) Mark expected switch fall-through | expand |
On Mon, Feb 11, 2019 at 04:07:38PM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’: > drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through [-Wimplicit-fallthrough=] > data->auto_point_temp_signed = 1; > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > drivers/hwmon/f71882fg.c:2459:3: note: here > case f71889fg: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/f71882fg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c > index ca54ce5c8e10..83023798e489 100644 > --- a/drivers/hwmon/f71882fg.c > +++ b/drivers/hwmon/f71882fg.c > @@ -2455,7 +2455,7 @@ static int f71882fg_probe(struct platform_device *pdev) > case f71869a: > /* These always have signed auto point temps */ > data->auto_point_temp_signed = 1; > - /* Fall through to select correct fan/pwm reg bank! */ > + /* Fall through - to select correct fan/pwm reg bank! */ > case f71889fg: > case f71889ed: > case f71889a:
On 2/12/19 3:51 PM, Guenter Roeck wrote: > On Mon, Feb 11, 2019 at 04:07:38PM -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’: >> drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through [-Wimplicit-fallthrough=] >> data->auto_point_temp_signed = 1; >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ >> drivers/hwmon/f71882fg.c:2459:3: note: here >> case f71889fg: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> Notice that, in this particular case, the code comment is modified >> in accordance with what GCC is expecting to find. >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied to hwmon-next. > Thanks, Guenter. -- Gustavo
diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c index ca54ce5c8e10..83023798e489 100644 --- a/drivers/hwmon/f71882fg.c +++ b/drivers/hwmon/f71882fg.c @@ -2455,7 +2455,7 @@ static int f71882fg_probe(struct platform_device *pdev) case f71869a: /* These always have signed auto point temps */ data->auto_point_temp_signed = 1; - /* Fall through to select correct fan/pwm reg bank! */ + /* Fall through - to select correct fan/pwm reg bank! */ case f71889fg: case f71889ed: case f71889a:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’: drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through [-Wimplicit-fallthrough=] data->auto_point_temp_signed = 1; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/hwmon/f71882fg.c:2459:3: note: here case f71889fg: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/hwmon/f71882fg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)