| Message ID | 20190212035205.23477-1-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qcom: spmi-gpio: Fix boundary conditions IRQ domain translate | expand |
On Mon, Feb 11, 2019 at 07:52:05PM -0800, Bjorn Andersson wrote: > GPIOs on the SPMI PMIC are numbered 1..ngpio, so the boundary check in > pmic_gpio_domain_translate() is off by one, correct this. > > Fixes: ca69e2d165eb ("qcom: spmi-gpio: add support for hierarchical IRQ chip") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Brian Masney <masneyb@onstation.org>
On Tue, Feb 12, 2019 at 4:52 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > GPIOs on the SPMI PMIC are numbered 1..ngpio, so the boundary check in > pmic_gpio_domain_translate() is off by one, correct this. > > Fixes: ca69e2d165eb ("qcom: spmi-gpio: add support for hierarchical IRQ chip") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Good catch! Patch applied with Brian's review tag. Yours, Linus Walleij
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index e01a556ac586..cb512c7a5251 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -962,7 +962,8 @@ static int pmic_gpio_domain_translate(struct irq_domain *domain, struct pmic_gpio_state, chip); - if (fwspec->param_count != 2 || fwspec->param[0] >= state->chip.ngpio) + if (fwspec->param_count != 2 || + fwspec->param[0] < 1 || fwspec->param[0] > state->chip.ngpio) return -EINVAL; *hwirq = fwspec->param[0] - PMIC_GPIO_PHYSICAL_OFFSET;
GPIOs on the SPMI PMIC are numbered 1..ngpio, so the boundary check in pmic_gpio_domain_translate() is off by one, correct this. Fixes: ca69e2d165eb ("qcom: spmi-gpio: add support for hierarchical IRQ chip") Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)