mbox series

[v5,0/2] Clean up UFSHC driver

Message ID 494cd639-89a7-8868-b63a-ea7cdcba9777@free.fr (mailing list archive)
Headers show
Series Clean up UFSHC driver | expand

Message

Marc Gonzalez Feb. 11, 2019, 1:31 p.m. UTC
Casting a wide net to get as many eyeballs on the subject as possible.

I'm splitting this mini series off from the main "UFS on APQ8098/MSM8998"
as it's 1) ufs/scsi specific 2) controversial (to my surprise)

Please send all your Reviewed-by: tags if you agree with the patch,
and/or voice your concerns ASAP.

This series removes the "disable-VCCQ-power-rail-for-some-Flash-chips" quirk,
and cleans up after the dust settles.

Marc Gonzalez (2):
  scsi: ufs: Do not disable vccq in UFSHC driver
  scsi: ufs: Remove unused device quirks

 drivers/scsi/ufs/ufs.h        |  1 -
 drivers/scsi/ufs/ufs_quirks.h | 29 ----------------
 drivers/scsi/ufs/ufshcd.c     | 63 +++--------------------------------
 3 files changed, 4 insertions(+), 89 deletions(-)

Comments

Alim Akhtar Feb. 13, 2019, 10:25 a.m. UTC | #1
Hi Marc,

On 11/02/19 7:01 PM, Marc Gonzalez wrote:
> Casting a wide net to get as many eyeballs on the subject as possible.
> 
> I'm splitting this mini series off from the main "UFS on APQ8098/MSM8998"
> as it's 1) ufs/scsi specific 2) controversial (to my surprise)
> 
> Please send all your Reviewed-by: tags if you agree with the patch,
> and/or voice your concerns ASAP.
> 
> This series removes the "disable-VCCQ-power-rail-for-some-Flash-chips" quirk,
> and cleans up after the dust settles.
> 
> Marc Gonzalez (2):
>    scsi: ufs: Do not disable vccq in UFSHC driver
>    scsi: ufs: Remove unused device quirks
> 
>   drivers/scsi/ufs/ufs.h        |  1 -
>   drivers/scsi/ufs/ufs_quirks.h | 29 ----------------
>   drivers/scsi/ufs/ufshcd.c     | 63 +++--------------------------------
>   3 files changed, 4 insertions(+), 89 deletions(-)
> 
For this series
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
As no other platform has claimed issues with this we can land this.
Others let us know if your opinion differs here.

Acked-by: Alim Akhtar <alim.akhtar@samsung.com>

Thanks!
Marc Gonzalez Feb. 23, 2019, 9:39 a.m. UTC | #2
Martin,

Could you send this series to -next so that it gets some exposure
and testing during the 5.1 RC cycle?

Regards.

On 11/02/2019 14:31, Marc Gonzalez wrote:

> Casting a wide net to get as many eyeballs on the subject as possible.
> 
> I'm splitting this mini series off from the main "UFS on APQ8098/MSM8998"
> as it's 1) ufs/scsi specific 2) controversial (to my surprise)
> 
> Please send all your Reviewed-by: tags if you agree with the patch,
> and/or voice your concerns ASAP.
> 
> This series removes the "disable-VCCQ-power-rail-for-some-Flash-chips" quirk,
> and cleans up after the dust settles.
> 
> Marc Gonzalez (2):
>   scsi: ufs: Do not disable vccq in UFSHC driver
>   scsi: ufs: Remove unused device quirks
> 
>  drivers/scsi/ufs/ufs.h        |  1 -
>  drivers/scsi/ufs/ufs_quirks.h | 29 ----------------
>  drivers/scsi/ufs/ufshcd.c     | 63 +++--------------------------------
>  3 files changed, 4 insertions(+), 89 deletions(-)
Lee Jones Feb. 26, 2019, 8:57 a.m. UTC | #3
On Sat, 23 Feb 2019, Marc Gonzalez wrote:

> Martin,
> 
> Could you send this series to -next so that it gets some exposure
> and testing during the 5.1 RC cycle?

Replying for the purpose of providing some gravitas to this set.

These patches are required to support some exciting consumer hardware
which has been recently released [0][1][2][3][4].  If they do not
find their way into Mainline very soon, it would mean that supporting
these devices in the most popular Linux distos will be difficult to
impossible.

Please consider them for the v5.1 merge window which opens in a week.

[0] https://joindiaspora.com/posts/4714199011120137995e0218b7b935a5
[1] https://liliputing.com/2019/02/now-you-can-run-linux-on-some-arm-laptops-designed-for-windows-10-on-arm.html
[2] https://www.phoronix.com/scan.php?page=news_item&px=Linux-On-The-Win-Arm-Laptops
[3] https://fossbytes.com/linux-on-windows-10-arm-laptops-project/
[4] https://www.techrepublic.com/article/open-source-project-aims-to-make-ubuntu-usable-on-arm-powered-windows-laptops/

> On 11/02/2019 14:31, Marc Gonzalez wrote:
> 
> > Casting a wide net to get as many eyeballs on the subject as possible.
> > 
> > I'm splitting this mini series off from the main "UFS on APQ8098/MSM8998"
> > as it's 1) ufs/scsi specific 2) controversial (to my surprise)
> > 
> > Please send all your Reviewed-by: tags if you agree with the patch,
> > and/or voice your concerns ASAP.
> > 
> > This series removes the "disable-VCCQ-power-rail-for-some-Flash-chips" quirk,
> > and cleans up after the dust settles.
> > 
> > Marc Gonzalez (2):
> >   scsi: ufs: Do not disable vccq in UFSHC driver
> >   scsi: ufs: Remove unused device quirks
> > 
> >  drivers/scsi/ufs/ufs.h        |  1 -
> >  drivers/scsi/ufs/ufs_quirks.h | 29 ----------------
> >  drivers/scsi/ufs/ufshcd.c     | 63 +++--------------------------------
> >  3 files changed, 4 insertions(+), 89 deletions(-)