| Message ID | 20190213134335.10838-3-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mfd: add support for max77650 PMIC | expand |
On Wed, Feb 13, 2019 at 02:43:26PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Add the DT binding document for the battery charger module of max77650. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > .../power/supply/max77650-charger.txt | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > new file mode 100644 > index 000000000000..16e24173c80e > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > @@ -0,0 +1,27 @@ > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > + > +This module is part of the MAX77650 MFD device. For more details > +see Documentation/devicetree/bindings/mfd/max77650.txt. > + > +The charger is represented as a sub-node of the PMIC node on the device tree. > + > +Required properties: > +-------------------- > +- compatible: Must be "maxim,max77650-charger" > + > +Optional properties: > +-------------------- > +- min-input-voltage: Minimum CHGIN regulation voltage (in microvolts). Must be > + one of: 4000000, 4100000, 4200000, 4300000, 4400000, > + 4500000, 4600000, 4700000. > +- current-limit: CHGIN input current limit (in microamps). Must be one of: > + 95000, 190000, 285000, 380000, 475000. Unit suffix? Really, these should be common properties. We have some I think. Charger bindings are a mess though... > + > +Example: > +-------- > + > + charger { > + compatible = "maxim,max77650-charger"; > + maxim,vchgin-min = <4200000>; > + maxim,ichgin-lim = <285000>; Doesn't match above. > + }; > -- > 2.20.1 >
śr., 13 lut 2019 o 21:48 Rob Herring <robh@kernel.org> napisał(a): > > On Wed, Feb 13, 2019 at 02:43:26PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Add the DT binding document for the battery charger module of max77650. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > .../power/supply/max77650-charger.txt | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > new file mode 100644 > > index 000000000000..16e24173c80e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > @@ -0,0 +1,27 @@ > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > + > > +This module is part of the MAX77650 MFD device. For more details > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > + > > +The charger is represented as a sub-node of the PMIC node on the device tree. > > + > > +Required properties: > > +-------------------- > > +- compatible: Must be "maxim,max77650-charger" > > + > > +Optional properties: > > +-------------------- > > +- min-input-voltage: Minimum CHGIN regulation voltage (in microvolts). Must be > > + one of: 4000000, 4100000, 4200000, 4300000, 4400000, > > + 4500000, 4600000, 4700000. > > +- current-limit: CHGIN input current limit (in microamps). Must be one of: > > + 95000, 190000, 285000, 380000, 475000. > > Unit suffix? Really, these should be common properties. We have > some I think. Charger bindings are a mess though... > Do you mean a suffix like: ua for microamps and uv for microvolts? I'm not seeing any other such properties. Bart > > + > > +Example: > > +-------- > > + > > + charger { > > + compatible = "maxim,max77650-charger"; > > + maxim,vchgin-min = <4200000>; > > + maxim,ichgin-lim = <285000>; > > Doesn't match above. > > > + }; > > -- > > 2.20.1 > >
> > > +Optional properties: > > > +-------------------- > > > +- min-input-voltage: Minimum CHGIN regulation voltage (in microvolts). Must be > > > + one of: 4000000, 4100000, 4200000, 4300000, 4400000, > > > + 4500000, 4600000, 4700000. > > > +- current-limit: CHGIN input current limit (in microamps). Must be one of: > > > + 95000, 190000, 285000, 380000, 475000. > > > > Unit suffix? Really, these should be common properties. We have > > some I think. Charger bindings are a mess though... > > > > Do you mean a suffix like: ua for microamps and uv for microvolts? I'm > not seeing any other such properties. Documentation/devicetree$ grep -ri microvolt . Pavel
On Thu, Feb 14, 2019 at 3:29 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > śr., 13 lut 2019 o 21:48 Rob Herring <robh@kernel.org> napisał(a): > > > > On Wed, Feb 13, 2019 at 02:43:26PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > Add the DT binding document for the battery charger module of max77650. > > > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > --- > > > .../power/supply/max77650-charger.txt | 27 +++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > > > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > new file mode 100644 > > > index 000000000000..16e24173c80e > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > @@ -0,0 +1,27 @@ > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > > + > > > +This module is part of the MAX77650 MFD device. For more details > > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > > + > > > +The charger is represented as a sub-node of the PMIC node on the device tree. > > > + > > > +Required properties: > > > +-------------------- > > > +- compatible: Must be "maxim,max77650-charger" > > > + > > > +Optional properties: > > > +-------------------- > > > +- min-input-voltage: Minimum CHGIN regulation voltage (in microvolts). Must be > > > + one of: 4000000, 4100000, 4200000, 4300000, 4400000, > > > + 4500000, 4600000, 4700000. > > > +- current-limit: CHGIN input current limit (in microamps). Must be one of: > > > + 95000, 190000, 285000, 380000, 475000. > > > > Unit suffix? Really, these should be common properties. We have > > some I think. Charger bindings are a mess though... > > > > Do you mean a suffix like: ua for microamps and uv for microvolts? I'm > not seeing any other such properties. See bindings/property-units.txt Rob
diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file mode 100644 index 000000000000..16e24173c80e --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt @@ -0,0 +1,27 @@ +Battery charger driver for MAX77650 PMIC from Maxim Integrated. + +This module is part of the MAX77650 MFD device. For more details +see Documentation/devicetree/bindings/mfd/max77650.txt. + +The charger is represented as a sub-node of the PMIC node on the device tree. + +Required properties: +-------------------- +- compatible: Must be "maxim,max77650-charger" + +Optional properties: +-------------------- +- min-input-voltage: Minimum CHGIN regulation voltage (in microvolts). Must be + one of: 4000000, 4100000, 4200000, 4300000, 4400000, + 4500000, 4600000, 4700000. +- current-limit: CHGIN input current limit (in microamps). Must be one of: + 95000, 190000, 285000, 380000, 475000. + +Example: +-------- + + charger { + compatible = "maxim,max77650-charger"; + maxim,vchgin-min = <4200000>; + maxim,ichgin-lim = <285000>; + };