| Message ID | f34970a034946bacda19202e2ce9973ca732c925.1550060544.git.baolin.wang@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 0419a75b1808dda225b17ba1509f195f23c0db88 |
| Headers | show |
| Series | Add new device nodes for Spreadtrum SC9860 platform | expand |
On Wed, Feb 13, 2019 at 1:34 PM Baolin Wang <baolin.wang@linaro.org> wrote: > > Remove wildcard compatible string. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Looks good to me. It does break using the new dtb file on older kernels, but I suppose this is not a case we care much about yet on your platform, given that both the dts file sand the drivers in the kernel are still work in progress. I had started the other reply I just sent before I saw this new mail. Arnd
On Wed, 13 Feb 2019 at 22:32, Arnd Bergmann <arnd@arndb.de> wrote: > > On Wed, Feb 13, 2019 at 1:34 PM Baolin Wang <baolin.wang@linaro.org> wrote: > > > > Remove wildcard compatible string. > > > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > > Looks good to me. It does break using the new dtb file on older kernels, > but I suppose this is not a case we care much about yet on your > platform, given that both the dts file sand the drivers in the > kernel are still work in progress. Right. Thanks for your reviewing. > > I had started the other reply I just sent before I saw this new mail. > > Arnd
On Thu, Feb 14, 2019 at 2:56 AM Baolin Wang <baolin.wang@linaro.org> wrote: > > On Wed, 13 Feb 2019 at 22:32, Arnd Bergmann <arnd@arndb.de> wrote: > > > > On Wed, Feb 13, 2019 at 1:34 PM Baolin Wang <baolin.wang@linaro.org> wrote: > > > > > > Remove wildcard compatible string. > > > > > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > > > > > Looks good to me. It does break using the new dtb file on older kernels, > > but I suppose this is not a case we care much about yet on your > > platform, given that both the dts file sand the drivers in the > > kernel are still work in progress. > > Right. Thanks for your reviewing. I have applied patches 1 through 5 now. Thanks, Arnd
diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi index 4a79ddf..e15409f 100644 --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi @@ -24,7 +24,7 @@ }; led-controller@200 { - compatible = "sprd,sc27xx-bltc", "sprd,sc2731-bltc"; + compatible = "sprd,sc2731-bltc"; reg = <0x200>; #address-cells = <1>; #size-cells = <0>; @@ -46,14 +46,14 @@ }; rtc@280 { - compatible = "sprd,sc27xx-rtc", "sprd,sc2731-rtc"; + compatible = "sprd,sc2731-rtc"; reg = <0x280>; interrupt-parent = <&sc2731_pmic>; interrupts = <2>; }; pmic_eic: gpio@300 { - compatible = "sprd,sc27xx-eic"; + compatible = "sprd,sc2731-eic"; reg = <0x300>; interrupt-parent = <&sc2731_pmic>; interrupts = <5>; @@ -64,7 +64,7 @@ }; efuse@380 { - compatible = "sprd,sc27xx-efuse", "sprd,sc2731-efuse"; + compatible = "sprd,sc2731-efuse"; reg = <0x380>; #address-cells = <1>; #size-cells = <1>; @@ -85,7 +85,7 @@ }; pmic_adc: adc@480 { - compatible = "sprd,sc27xx-adc", "sprd,sc2731-adc"; + compatible = "sprd,sc2731-adc"; reg = <0x480>; interrupt-parent = <&sc2731_pmic>; interrupts = <0>; @@ -109,12 +109,12 @@ }; vibrator@ec8 { - compatible = "sprd,sc27xx-vibrator", "sprd,sc2731-vibrator"; + compatible = "sprd,sc2731-vibrator"; reg = <0xec8>; }; regulators { - compatible = "sprd,sc27xx-regulator"; + compatible = "sprd,sc2731-regulator"; vddarm0: BUCK_CPU0 { regulator-name = "vddarm0";
Remove wildcard compatible string. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- arch/arm64/boot/dts/sprd/sc2731.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)