diff mbox series

[V4,4/4] MAINTAINERS: Added imx DDR performonitor driver maintainer information

Message ID 1550253761-26841-4-git-send-email-Frank.Li@nxp.com (mailing list archive)
State New, archived
Headers show
Series [V4,1/4] dt-bindings: perf: imx8-ddr: add imx8qxp ddr performance monitor | expand

Commit Message

Frank Li Feb. 15, 2019, 6:03 p.m. UTC 
Add DDR perf counter driver maintainer information

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
No change from v1 to v4

 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Uwe Kleine-König Feb. 15, 2019, 8:01 p.m. UTC | #1 
On Fri, Feb 15, 2019 at 06:03:16PM +0000, Frank Li wrote:
> Add DDR perf counter driver maintainer information
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> No change from v1 to v4
> 
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6ba068e..687be0f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6163,6 +6163,13 @@ L:	linux-i2c@vger.kernel.org
>  S:	Maintained
>  F:	drivers/i2c/busses/i2c-cpm.c
>  
> +FREESCALE IMX DDR Performance Monitor DRIVER
> +M:	Frank Li <Frank.li@nxp.com>
> +L:	linux-arm-kernel@lists.infradead.org
> +S:	Maintained
> +F:	drivers/perf/fsl_imx8_ddr_perf.c
> +F:	Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> +

With da8b7f0fb02b ("MAINTAINERS: add all files matching "imx" and "mxs"
to the IMX entry") that sits currently in next the "ARM/FREESCALE IMX /
MXC ARM ARCHITECTURE" also matches for these two files.

Is this good here or not?

Best regards
Uwe
Zhi Li Feb. 15, 2019, 9:13 p.m. UTC | #2 
On Fri, Feb 15, 2019 at 2:01 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> On Fri, Feb 15, 2019 at 06:03:16PM +0000, Frank Li wrote:
> > Add DDR perf counter driver maintainer information
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > No change from v1 to v4
> >
> >  MAINTAINERS | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6ba068e..687be0f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -6163,6 +6163,13 @@ L:     linux-i2c@vger.kernel.org
> >  S:   Maintained
> >  F:   drivers/i2c/busses/i2c-cpm.c
> >
> > +FREESCALE IMX DDR Performance Monitor DRIVER
> > +M:   Frank Li <Frank.li@nxp.com>
> > +L:   linux-arm-kernel@lists.infradead.org
> > +S:   Maintained
> > +F:   drivers/perf/fsl_imx8_ddr_perf.c
> > +F:   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > +
>
> With da8b7f0fb02b ("MAINTAINERS: add all files matching "imx" and "mxs"
> to the IMX entry") that sits currently in next the "ARM/FREESCALE IMX /
> MXC ARM ARCHITECTURE" also matches for these two files.
>
> Is this good here or not?

Yes! what's do you means?
Needn't these entry because da8b7f0fb02b?

>
> Best regards
> Uwe
>
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Uwe Kleine-König Feb. 15, 2019, 9:44 p.m. UTC | #3 
On Fri, Feb 15, 2019 at 03:13:00PM -0600, Zhi Li wrote:
> On Fri, Feb 15, 2019 at 2:01 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > On Fri, Feb 15, 2019 at 06:03:16PM +0000, Frank Li wrote:
> > > Add DDR perf counter driver maintainer information
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > No change from v1 to v4
> > >
> > >  MAINTAINERS | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 6ba068e..687be0f 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -6163,6 +6163,13 @@ L:     linux-i2c@vger.kernel.org
> > >  S:   Maintained
> > >  F:   drivers/i2c/busses/i2c-cpm.c
> > >
> > > +FREESCALE IMX DDR Performance Monitor DRIVER
> > > +M:   Frank Li <Frank.li@nxp.com>
> > > +L:   linux-arm-kernel@lists.infradead.org
> > > +S:   Maintained
> > > +F:   drivers/perf/fsl_imx8_ddr_perf.c
> > > +F:   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > > +
> >
> > With da8b7f0fb02b ("MAINTAINERS: add all files matching "imx" and "mxs"
> > to the IMX entry") that sits currently in next the "ARM/FREESCALE IMX /
> > MXC ARM ARCHITECTURE" also matches for these two files.
> >
> > Is this good here or not?
> 
> Yes! what's do you means?
> Needn't these entry because da8b7f0fb02b?

It's just that we then will have two entries that will match. In a tree
where I have both, this series and da8b7f0fb02b I see:

	$ scripts/get_maintainer.pl -f drivers/perf/fsl_imx8_ddr_perf.c
	Frank Li <Frank.li@nxp.com> (maintainer:FREESCALE IMX DDR Performance Monitor DRIVER)
	Will Deacon <will.deacon@arm.com> (maintainer:ARM PMU PROFILING AND DEBUGGING)
	Mark Rutland <mark.rutland@arm.com> (maintainer:ARM PMU PROFILING AND DEBUGGING)
	Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
	Sascha Hauer <s.hauer@pengutronix.de> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
	Pengutronix Kernel Team <kernel@pengutronix.de> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
	Fabio Estevam <fabio.estevam@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
	NXP Linux Team <linux-imx@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
	linux-arm-kernel@lists.infradead.org (open list:FREESCALE IMX DDR Performance Monitor DRIVER)
	linux-kernel@vger.kernel.org (open list)

That's not necessarily a bad thing, but something I want people to make
aware of.

Best regards
Uwe
Shawn Guo Feb. 18, 2019, 1:22 a.m. UTC | #4 
On Fri, Feb 15, 2019 at 10:44:44PM +0100, Uwe Kleine-König wrote:
> On Fri, Feb 15, 2019 at 03:13:00PM -0600, Zhi Li wrote:
> > On Fri, Feb 15, 2019 at 2:01 PM Uwe Kleine-König
> > <u.kleine-koenig@pengutronix.de> wrote:
> > >
> > > On Fri, Feb 15, 2019 at 06:03:16PM +0000, Frank Li wrote:
> > > > Add DDR perf counter driver maintainer information
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > > No change from v1 to v4
> > > >
> > > >  MAINTAINERS | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 6ba068e..687be0f 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -6163,6 +6163,13 @@ L:     linux-i2c@vger.kernel.org
> > > >  S:   Maintained
> > > >  F:   drivers/i2c/busses/i2c-cpm.c
> > > >
> > > > +FREESCALE IMX DDR Performance Monitor DRIVER
> > > > +M:   Frank Li <Frank.li@nxp.com>
> > > > +L:   linux-arm-kernel@lists.infradead.org
> > > > +S:   Maintained
> > > > +F:   drivers/perf/fsl_imx8_ddr_perf.c
> > > > +F:   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > > > +
> > >
> > > With da8b7f0fb02b ("MAINTAINERS: add all files matching "imx" and "mxs"
> > > to the IMX entry") that sits currently in next the "ARM/FREESCALE IMX /
> > > MXC ARM ARCHITECTURE" also matches for these two files.
> > >
> > > Is this good here or not?
> > 
> > Yes! what's do you means?
> > Needn't these entry because da8b7f0fb02b?
> 
> It's just that we then will have two entries that will match. In a tree
> where I have both, this series and da8b7f0fb02b I see:
> 
> 	$ scripts/get_maintainer.pl -f drivers/perf/fsl_imx8_ddr_perf.c
> 	Frank Li <Frank.li@nxp.com> (maintainer:FREESCALE IMX DDR Performance Monitor DRIVER)
> 	Will Deacon <will.deacon@arm.com> (maintainer:ARM PMU PROFILING AND DEBUGGING)
> 	Mark Rutland <mark.rutland@arm.com> (maintainer:ARM PMU PROFILING AND DEBUGGING)
> 	Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> 	Sascha Hauer <s.hauer@pengutronix.de> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> 	Pengutronix Kernel Team <kernel@pengutronix.de> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> 	Fabio Estevam <fabio.estevam@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> 	NXP Linux Team <linux-imx@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> 	linux-arm-kernel@lists.infradead.org (open list:FREESCALE IMX DDR Performance Monitor DRIVER)
> 	linux-kernel@vger.kernel.org (open list)
> 
> That's not necessarily a bad thing, but something I want people to make
> aware of.

For me, that's actually a good thing.  We, i.MX platform folks, get
copied on i.MX related driver changes in the right order - after driver
maintainers.

Shawn
Aisheng Dong Feb. 20, 2019, 6:28 a.m. UTC | #5 
> From: Uwe Kleine-König [mailto:u.kleine-koenig@pengutronix.de]
> Sent: Saturday, February 16, 2019 5:45 AM
> 
> On Fri, Feb 15, 2019 at 03:13:00PM -0600, Zhi Li wrote:
> > On Fri, Feb 15, 2019 at 2:01 PM Uwe Kleine-König
> > <u.kleine-koenig@pengutronix.de> wrote:
> > >
> > > On Fri, Feb 15, 2019 at 06:03:16PM +0000, Frank Li wrote:
> > > > Add DDR perf counter driver maintainer information
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > > No change from v1 to v4
> > > >
> > > >  MAINTAINERS | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS index 6ba068e..687be0f
> > > > 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -6163,6 +6163,13 @@ L:     linux-i2c@vger.kernel.org
> > > >  S:   Maintained
> > > >  F:   drivers/i2c/busses/i2c-cpm.c
> > > >
> > > > +FREESCALE IMX DDR Performance Monitor DRIVER
> > > > +M:   Frank Li <Frank.li@nxp.com>
> > > > +L:   linux-arm-kernel@lists.infradead.org
> > > > +S:   Maintained
> > > > +F:   drivers/perf/fsl_imx8_ddr_perf.c
> > > > +F:   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > > > +
> > >
> > > With da8b7f0fb02b ("MAINTAINERS: add all files matching "imx" and "mxs"
> > > to the IMX entry") that sits currently in next the "ARM/FREESCALE
> > > IMX / MXC ARM ARCHITECTURE" also matches for these two files.
> > >
> > > Is this good here or not?
> >
> > Yes! what's do you means?
> > Needn't these entry because da8b7f0fb02b?
> 
> It's just that we then will have two entries that will match. In a tree where I
> have both, this series and da8b7f0fb02b I see:
> 
> 	$ scripts/get_maintainer.pl -f drivers/perf/fsl_imx8_ddr_perf.c
> 	Frank Li <Frank.li@nxp.com> (maintainer:FREESCALE IMX DDR
> Performance Monitor DRIVER)
> 	Will Deacon <will.deacon@arm.com> (maintainer:ARM PMU PROFILING
> AND DEBUGGING)
> 	Mark Rutland <mark.rutland@arm.com> (maintainer:ARM PMU
> PROFILING AND DEBUGGING)
> 	Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE IMX /
> MXC ARM ARCHITECTURE)
> 	Sascha Hauer <s.hauer@pengutronix.de> (maintainer:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE)
> 	Pengutronix Kernel Team <kernel@pengutronix.de>
> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> 	Fabio Estevam <fabio.estevam@nxp.com> (reviewer:ARM/FREESCALE IMX
> / MXC ARM ARCHITECTURE)
> 	NXP Linux Team <linux-imx@nxp.com> (reviewer:ARM/FREESCALE IMX /
> MXC ARM ARCHITECTURE)
> 	linux-arm-kernel@lists.infradead.org (open list:FREESCALE IMX DDR
> Performance Monitor DRIVER)
> 	linux-kernel@vger.kernel.org (open list)
> 
> That's not necessarily a bad thing, but something I want people to make aware
> of.
> 

IMHO it's better to have a more specific maintainer in the MAINTAINER file
for a specific module.

Don't reply on the general pattern to filter all IMX patches to send ARCH
Maintainers to help review.

Regards
Dong Aisheng

> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 |
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> pengutronix.de%2F&amp;data=02%7C01%7Caisheng.dong%40nxp.com%7C88
> f88bc0bd7e4812d00008d6938ed1af%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C636858638948593375&amp;sdata=KwEG5SXUsLCgUU9pg8
> hnZ9JQq4%2FPGHA6EFhmF%2Bcmlo8%3D&amp;reserved=0  |
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 6ba068e..687be0f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6163,6 +6163,13 @@  L:	linux-i2c@vger.kernel.org
 S:	Maintained
 F:	drivers/i2c/busses/i2c-cpm.c
 
+FREESCALE IMX DDR Performance Monitor DRIVER
+M:	Frank Li <Frank.li@nxp.com>
+L:	linux-arm-kernel@lists.infradead.org
+S:	Maintained
+F:	drivers/perf/fsl_imx8_ddr_perf.c
+F:	Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
+
 FREESCALE IMX LPI2C DRIVER
 M:	Dong Aisheng <aisheng.dong@nxp.com>
 L:	linux-i2c@vger.kernel.org