| Message ID | 2be9d6de92507e5886433fb2cd55117c63b63d72.1550043082.git.baolin.wang@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6dcb144f7da634e4a0f8837e5076ef48e4d6ac12 |
| Headers | show |
| Series | [v2,1/3] spi: sprd: Add the SPI irq function for the SPI DMA mode | expand |
On Wed, Feb 13, 2019 at 1:37 AM Baolin Wang <baolin.wang@linaro.org> wrote: > > From: Lanqing Liu <lanqing.liu@unisoc.com> > > Add the DMA properties for the SPI dma mode. > > Signed-off-by: Lanqing Liu <lanqing.liu@unisoc.com> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > Changes from v1: > - Remove sprd,dma-slave-ids property. > --- > Documentation/devicetree/bindings/spi/spi-sprd.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-sprd.txt b/Documentation/devicetree/bindings/spi/spi-sprd.txt > index bad211a..3c7eacc 100644 > --- a/Documentation/devicetree/bindings/spi/spi-sprd.txt > +++ b/Documentation/devicetree/bindings/spi/spi-sprd.txt > @@ -14,6 +14,11 @@ Required properties: > address on the SPI bus. Should be set to 1. > - #size-cells: Should be set to 0. > > +Optional properties: > +dma-names: Should contain names of the SPI used DMA channel. > +dmas: Should contain DMA channels and DMA slave ids which the SPI used > + sorted in the same order as the dma-names property. These need to define the order and names. > + > Example: > spi0: spi@70a00000{ > compatible = "sprd,sc9860-spi"; > @@ -21,6 +26,8 @@ spi0: spi@70a00000{ > interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > clock-names = "spi", "source","enable"; > clocks = <&clk_spi0>, <&ext_26m>, <&clk_ap_apb_gates 5>; > + dma-names = "rx_chn", "tx_chn"; Everyone else uses "rx" and "tx". Do you really need something different? > + dmas = <&apdma 11 11>, <&apdma 12 12>; > #address-cells = <1>; > #size-cells = <0>; > }; > -- > 1.7.9.5 >
On Mon, 18 Feb 2019 at 22:02, Rob Herring <robh+dt@kernel.org> wrote: > > On Wed, Feb 13, 2019 at 1:37 AM Baolin Wang <baolin.wang@linaro.org> wrote: > > > > From: Lanqing Liu <lanqing.liu@unisoc.com> > > > > Add the DMA properties for the SPI dma mode. > > > > Signed-off-by: Lanqing Liu <lanqing.liu@unisoc.com> > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > --- > > Changes from v1: > > - Remove sprd,dma-slave-ids property. > > --- > > Documentation/devicetree/bindings/spi/spi-sprd.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-sprd.txt b/Documentation/devicetree/bindings/spi/spi-sprd.txt > > index bad211a..3c7eacc 100644 > > --- a/Documentation/devicetree/bindings/spi/spi-sprd.txt > > +++ b/Documentation/devicetree/bindings/spi/spi-sprd.txt > > @@ -14,6 +14,11 @@ Required properties: > > address on the SPI bus. Should be set to 1. > > - #size-cells: Should be set to 0. > > > > +Optional properties: > > +dma-names: Should contain names of the SPI used DMA channel. > > +dmas: Should contain DMA channels and DMA slave ids which the SPI used > > + sorted in the same order as the dma-names property. > > These need to define the order and names. Sure. > > > + > > Example: > > spi0: spi@70a00000{ > > compatible = "sprd,sc9860-spi"; > > @@ -21,6 +26,8 @@ spi0: spi@70a00000{ > > interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > > clock-names = "spi", "source","enable"; > > clocks = <&clk_spi0>, <&ext_26m>, <&clk_ap_apb_gates 5>; > > + dma-names = "rx_chn", "tx_chn"; > > Everyone else uses "rx" and "tx". Do you really need something different? Okay, will change to use "rx" and "tx". I will send incremental patch to fix ths issues you pointed out. Thanks.
diff --git a/Documentation/devicetree/bindings/spi/spi-sprd.txt b/Documentation/devicetree/bindings/spi/spi-sprd.txt index bad211a..3c7eacc 100644 --- a/Documentation/devicetree/bindings/spi/spi-sprd.txt +++ b/Documentation/devicetree/bindings/spi/spi-sprd.txt @@ -14,6 +14,11 @@ Required properties: address on the SPI bus. Should be set to 1. - #size-cells: Should be set to 0. +Optional properties: +dma-names: Should contain names of the SPI used DMA channel. +dmas: Should contain DMA channels and DMA slave ids which the SPI used + sorted in the same order as the dma-names property. + Example: spi0: spi@70a00000{ compatible = "sprd,sc9860-spi"; @@ -21,6 +26,8 @@ spi0: spi@70a00000{ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; clock-names = "spi", "source","enable"; clocks = <&clk_spi0>, <&ext_26m>, <&clk_ap_apb_gates 5>; + dma-names = "rx_chn", "tx_chn"; + dmas = <&apdma 11 11>, <&apdma 12 12>; #address-cells = <1>; #size-cells = <0>; };