| Message ID | 20190213090031.921130-1-haakon.bugge@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Update MAINTAINERS | expand |
> Add Mark and the undersigned as maintainers, removed Sean and Hal. > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> Acked-by: Sean Hefty <sean.hefty@intel.com>
Am Mittwoch, den 13.02.2019, 10:00 +0100 schrieb Håkon Bugge: > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4a420b62..14c4fede 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -80,8 +80,8 @@ S: Supported > F: providers/i40iw/ > > RDMA Communication Manager Assistant (for librdmacm.so) > -M: Sean Hefty <sean.hefty@intel.com> > -M: Hal Rosenstock <hal@dev.mellanox.co.il> > +M: Håkon Bugge <haakon.bugge@oracle.com> > +M: Mark Haywood <mark.haywood@oracle.com>> Two >> instead of one >.
On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> Thanks applied with fix from Benjamin. Håkon, I would like you to ask you do not use special symbols in git patches, it doesn't survive git am/patchworks. Thanks
> On 17 Feb 2019, at 18:24, Leon Romanovsky <leon@kernel.org> wrote: > > > Håkon, I would like you to ask you do not use special symbols in git > patches, it doesn't survive git am/patchworks. Thanks, you mean the aring which you transformed into a double "a"? Yes, I will refrain from using it :-) Thxs, Håkon
Am Sonntag, den 17.02.2019, 19:24 +0200 schrieb Leon Romanovsky: > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > Thanks applied with fix from Benjamin. > > Håkon, I would like you to ask you do not use special symbols in git > patches, it doesn't survive git am/patchworks. Special symbols? We should stick to ASCII, because UTF-8 is too new and tools have problems dealing with it? That's sad.
On Mon, Feb 18, 2019 at 03:50:12PM +0100, Håkon Bugge wrote: > > > > On 17 Feb 2019, at 18:24, Leon Romanovsky <leon@kernel.org> wrote: > > > > > > Håkon, I would like you to ask you do not use special symbols in git > > patches, it doesn't survive git am/patchworks. > > > Thanks, you mean the aring which you transformed into a double "a"? Yes, I used the same transliteration as in your email address haakon.b.... > > Yes, I will refrain from using it :-) > Thanks > > Thxs, Håkon > >
On Mon, Feb 18, 2019 at 04:12:50PM +0100, Benjamin Drung wrote: > Am Sonntag, den 17.02.2019, 19:24 +0200 schrieb Leon Romanovsky: > > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > > > Thanks applied with fix from Benjamin. > > > > Håkon, I would like you to ask you do not use special symbols in git > > patches, it doesn't survive git am/patchworks. > > Special symbols? We should stick to ASCII, because UTF-8 is too new and > tools have problems dealing with it? That's sad. Yes, patches should be in ASCII. > > -- > Benjamin Drung > System Developer > Debian & Ubuntu Developer > > 1&1 IONOS Cloud GmbH | Greifswalder Str. 207 | 10405 Berlin | Germany > E-mail: benjamin.drung@cloud.ionos.com | Web: www.ionos.de > > Head Office: Berlin, Germany > District Court Berlin Charlottenburg, Registration number: HRB 125506 B > Executive Management: Christoph Steffens, Matthias Steinberg, Achim > Weiss > > Member of United Internet >
On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > Thanks applied with fix from Benjamin. > > Håkon, I would like you to ask you do not use special symbols in git > patches, it doesn't survive git am/patchworks. What flow did you use? I tested it and I didn't see a problem. IMHO this is a tooling bug. I've been careful to keep things UTF-8 clean as it seems appropriate to keep special characters in people's names. (and somone once yelled at me for not using °C in a patch) Jason
On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > > > Thanks applied with fix from Benjamin. > > > > Håkon, I would like you to ask you do not use special symbols in git > > patches, it doesn't survive git am/patchworks. > > What flow did you use? I tested it and I didn't see a problem. IMHO > this is a tooling bug. > > I've been careful to keep things UTF-8 clean as it seems appropriate > to keep special characters in people's names. (and somone once yelled > at me for not using °C in a patch) wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s Thanks > > Jason
On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: > On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > > On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > > > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > > > > > Thanks applied with fix from Benjamin. > > > > > > Håkon, I would like you to ask you do not use special symbols in git > > > patches, it doesn't survive git am/patchworks. > > > > What flow did you use? I tested it and I didn't see a problem. IMHO > > this is a tooling bug. > > > > I've been careful to keep things UTF-8 clean as it seems appropriate > > to keep special characters in people's names. (and somone once yelled > > at me for not using °C in a patch) > > wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s Worked OK for me.. wget does locale conversions however, so your LANG= is probably not in a UTF-8 setting, or otherwise. Jason
On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: > On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: > > On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > > > On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > > > > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > > > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > > > > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > > > > > > > Thanks applied with fix from Benjamin. > > > > > > > > Håkon, I would like you to ask you do not use special symbols in git > > > > patches, it doesn't survive git am/patchworks. > > > > > > What flow did you use? I tested it and I didn't see a problem. IMHO > > > this is a tooling bug. > > > > > > I've been careful to keep things UTF-8 clean as it seems appropriate > > > to keep special characters in people's names. (and somone once yelled > > > at me for not using °C in a patch) > > > > wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s > > Worked OK for me.. wget does locale conversions however, so your LANG= > is probably not in a UTF-8 setting, or otherwise. _ kernel git:(rdma-next) locale LANG=en_US.UTF-8 LC_CTYPE="C" LC_NUMERIC="C" LC_TIME="C" LC_COLLATE="C" LC_MONETARY="C" LC_MESSAGES="C" LC_PAPER="C" LC_NAME="C" LC_ADDRESS="C" LC_TELEPHONE="C" LC_MEASUREMENT="C" LC_IDENTIFICATION="C" LC_ALL=C Thanks > > Jason
> On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: > > On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: >> On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: >>> On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: >>>> On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: >>>>> On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: >>>>>> Add Mark and the undersigned as maintainers, removed Sean and Hal. >>>>>> >>>>>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> >>>>> >>>>> Thanks applied with fix from Benjamin. >>>>> >>>>> Håkon, I would like you to ask you do not use special symbols in git >>>>> patches, it doesn't survive git am/patchworks. >>>> >>>> What flow did you use? I tested it and I didn't see a problem. IMHO >>>> this is a tooling bug. >>>> >>>> I've been careful to keep things UTF-8 clean as it seems appropriate >>>> to keep special characters in people's names. (and somone once yelled >>>> at me for not using °C in a patch) >>> >>> wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s >> >> Worked OK for me.. wget does locale conversions however, so your LANG= >> is probably not in a UTF-8 setting, or otherwise. > > _ kernel git:(rdma-next) locale > LANG=en_US.UTF-8 > LC_CTYPE="C" > LC_NUMERIC="C" > LC_TIME="C" > LC_COLLATE="C" > LC_MONETARY="C" > LC_MESSAGES="C" > LC_PAPER="C" > LC_NAME="C" > LC_ADDRESS="C" > LC_TELEPHONE="C" > LC_MEASUREMENT="C" > LC_IDENTIFICATION="C" > LC_ALL=C Looks like most maintainers ar eable to cope with my "å": git log --author=Håkon --oneline --format="%h %Cblue%an%Creset %s" b4c542df5ae8 Håkon Bugge IB/mlx4: Add port and TID to MAD debug print 0a094ff06196 Håkon Bugge IB/mlx4: Enable debug print of SMPs 6a12709da354 Håkon Bugge net: if_arp: use define instead of hard-coded value 30f8eb55873e Håkon Bugge net: if_arp: Fix incorrect indents 802fa45cd320 Håkon Bugge RDMA/i40iw: Fix incorrect iterator type fa52531eb440 Håkon Bugge net/rds: Remove unnecessary variable bfd427116917 Håkon Bugge net/rds: void function cannot return -1 87a37ce9e400 Håkon Bugge IB/cm: Remove unused and erroneous msg sequence encoding [] and git log --author=Håkon --oneline --format="%h %Cblue%an%Creset %s" 57cccd20 Håkon Bugge Update MAINTAINERS d18c9471 Håkon Bugge ibacm: Fix acm_log_once f78ef906 Håkon Bugge ibacm: Log requests from kernel with unknown NL client ID 51c084b2 Håkon Bugge ibacm: Introduce acm_log_once() 625c16e0 Håkon Bugge ibacm: Use alias name when possible 6791c306 Håkon Bugge ibacm: Unable to resurrect an interface 4e64a008 Håkon Bugge ibacm: Print correct pkey db109a15 Håkon Bugge ibacm: Replace ioctl with netlink 77d56e3a Håkon Bugge ibacm: acme supports only one port f738aa0f Håkon Bugge ibacm: Remove dup defines and cleanup of hdr.data usage e0bfdec8 Håkon Bugge ibacm: Remove trailing blanks in acm.h c73f5d79 Håkon Bugge ibacm: Copy correct number of address bytes before calling provider [] Thxs, Håkon > > Thanks > >> >> Jason
On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote: > > > > On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: > > > > On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: > >> On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: > >>> On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > >>>> On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > >>>>> On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > >>>>>> Add Mark and the undersigned as maintainers, removed Sean and Hal. > >>>>>> > >>>>>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > >>>>> > >>>>> Thanks applied with fix from Benjamin. > >>>>> > >>>>> Håkon, I would like you to ask you do not use special symbols in git > >>>>> patches, it doesn't survive git am/patchworks. > >>>> > >>>> What flow did you use? I tested it and I didn't see a problem. IMHO > >>>> this is a tooling bug. > >>>> > >>>> I've been careful to keep things UTF-8 clean as it seems appropriate > >>>> to keep special characters in people's names. (and somone once yelled > >>>> at me for not using °C in a patch) > >>> > >>> wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s > >> > >> Worked OK for me.. wget does locale conversions however, so your LANG= > >> is probably not in a UTF-8 setting, or otherwise. > > > > _ kernel git:(rdma-next) locale > > LANG=en_US.UTF-8 > > LC_CTYPE="C" > > LC_NUMERIC="C" > > LC_TIME="C" > > LC_COLLATE="C" > > LC_MONETARY="C" > > LC_MESSAGES="C" > > LC_PAPER="C" > > LC_NAME="C" > > LC_ADDRESS="C" > > LC_TELEPHONE="C" > > LC_MEASUREMENT="C" > > LC_IDENTIFICATION="C" > > LC_ALL=C > > Looks like most maintainers ar eable to cope with my "å": Give me idea what should I need to change on my default linux machine and I'll be able to cope with å too. Thanks > > git log --author=Håkon --oneline --format="%h %Cblue%an%Creset %s" > b4c542df5ae8 Håkon Bugge IB/mlx4: Add port and TID to MAD debug print > 0a094ff06196 Håkon Bugge IB/mlx4: Enable debug print of SMPs > 6a12709da354 Håkon Bugge net: if_arp: use define instead of hard-coded value > 30f8eb55873e Håkon Bugge net: if_arp: Fix incorrect indents > 802fa45cd320 Håkon Bugge RDMA/i40iw: Fix incorrect iterator type > fa52531eb440 Håkon Bugge net/rds: Remove unnecessary variable > bfd427116917 Håkon Bugge net/rds: void function cannot return -1 > 87a37ce9e400 Håkon Bugge IB/cm: Remove unused and erroneous msg sequence encoding > [] > > and > > git log --author=Håkon --oneline --format="%h %Cblue%an%Creset %s" > 57cccd20 Håkon Bugge Update MAINTAINERS > d18c9471 Håkon Bugge ibacm: Fix acm_log_once > f78ef906 Håkon Bugge ibacm: Log requests from kernel with unknown NL client ID > 51c084b2 Håkon Bugge ibacm: Introduce acm_log_once() > 625c16e0 Håkon Bugge ibacm: Use alias name when possible > 6791c306 Håkon Bugge ibacm: Unable to resurrect an interface > 4e64a008 Håkon Bugge ibacm: Print correct pkey > db109a15 Håkon Bugge ibacm: Replace ioctl with netlink > 77d56e3a Håkon Bugge ibacm: acme supports only one port > f738aa0f Håkon Bugge ibacm: Remove dup defines and cleanup of hdr.data usage > e0bfdec8 Håkon Bugge ibacm: Remove trailing blanks in acm.h > c73f5d79 Håkon Bugge ibacm: Copy correct number of address bytes before calling provider > [] > > > Thxs, Håkon > > > > > > > > > Thanks > > > >> > >> Jason >
> On 19 Feb 2019, at 13:39, Leon Romanovsky <leon@kernel.org> wrote: > > On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote: >> >> >>> On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: >>> >>> On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: >>>> On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: >>>>> On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: >>>>>> On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: >>>>>>> On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: >>>>>>>> Add Mark and the undersigned as maintainers, removed Sean and Hal. >>>>>>>> >>>>>>>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> >>>>>>> >>>>>>> Thanks applied with fix from Benjamin. >>>>>>> >>>>>>> Håkon, I would like you to ask you do not use special symbols in git >>>>>>> patches, it doesn't survive git am/patchworks. >>>>>> >>>>>> What flow did you use? I tested it and I didn't see a problem. IMHO >>>>>> this is a tooling bug. >>>>>> >>>>>> I've been careful to keep things UTF-8 clean as it seems appropriate >>>>>> to keep special characters in people's names. (and somone once yelled >>>>>> at me for not using °C in a patch) >>>>> >>>>> wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s >>>> >>>> Worked OK for me.. wget does locale conversions however, so your LANG= >>>> is probably not in a UTF-8 setting, or otherwise. >>> >>> _ kernel git:(rdma-next) locale >>> LANG=en_US.UTF-8 >>> LC_CTYPE="C" >>> LC_NUMERIC="C" >>> LC_TIME="C" >>> LC_COLLATE="C" >>> LC_MONETARY="C" >>> LC_MESSAGES="C" >>> LC_PAPER="C" >>> LC_NAME="C" >>> LC_ADDRESS="C" >>> LC_TELEPHONE="C" >>> LC_MEASUREMENT="C" >>> LC_IDENTIFICATION="C" >>> LC_ALL=C >> >> Looks like most maintainers ar eable to cope with my "å": > > Give me idea what should I need to change on my default linux machine > and I'll be able to cope with å too. I have: > locale LANG=en_US.UTF-8 LC_CTYPE="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_PAPER="en_US.UTF-8" LC_NAME="en_US.UTF-8" LC_ADDRESS="en_US.UTF-8" LC_TELEPHONE="en_US.UTF-8" LC_MEASUREMENT="en_US.UTF-8" LC_IDENTIFICATION="en_US.UTF-8" LC_ALL= and I am using git version 2.20.1 Thxs, Håkon
On Tue, Feb 19, 2019 at 01:58:02PM +0100, Håkon Bugge wrote: > > > > On 19 Feb 2019, at 13:39, Leon Romanovsky <leon@kernel.org> wrote: > > > > On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote: > >> > >> > >>> On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: > >>> > >>> On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: > >>>> On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: > >>>>> On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > >>>>>> On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > >>>>>>> On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > >>>>>>>> Add Mark and the undersigned as maintainers, removed Sean and Hal. > >>>>>>>> > >>>>>>>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > >>>>>>> > >>>>>>> Thanks applied with fix from Benjamin. > >>>>>>> > >>>>>>> Håkon, I would like you to ask you do not use special symbols in git > >>>>>>> patches, it doesn't survive git am/patchworks. > >>>>>> > >>>>>> What flow did you use? I tested it and I didn't see a problem. IMHO > >>>>>> this is a tooling bug. > >>>>>> > >>>>>> I've been careful to keep things UTF-8 clean as it seems appropriate > >>>>>> to keep special characters in people's names. (and somone once yelled > >>>>>> at me for not using °C in a patch) > >>>>> > >>>>> wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s > >>>> > >>>> Worked OK for me.. wget does locale conversions however, so your LANG= > >>>> is probably not in a UTF-8 setting, or otherwise. > >>> > >>> _ kernel git:(rdma-next) locale > >>> LANG=en_US.UTF-8 > >>> LC_CTYPE="C" > >>> LC_NUMERIC="C" > >>> LC_TIME="C" > >>> LC_COLLATE="C" > >>> LC_MONETARY="C" > >>> LC_MESSAGES="C" > >>> LC_PAPER="C" > >>> LC_NAME="C" > >>> LC_ADDRESS="C" > >>> LC_TELEPHONE="C" > >>> LC_MEASUREMENT="C" > >>> LC_IDENTIFICATION="C" > >>> LC_ALL=C > >> > >> Looks like most maintainers ar eable to cope with my "å": > > > > Give me idea what should I need to change on my default linux machine > > and I'll be able to cope with å too. > > I have: > > > locale > LANG=en_US.UTF-8 > LC_CTYPE="en_US.UTF-8" > LC_NUMERIC="en_US.UTF-8" > LC_TIME="en_US.UTF-8" > LC_COLLATE="en_US.UTF-8" > LC_MONETARY="en_US.UTF-8" > LC_MESSAGES="en_US.UTF-8" > LC_PAPER="en_US.UTF-8" > LC_NAME="en_US.UTF-8" > LC_ADDRESS="en_US.UTF-8" > LC_TELEPHONE="en_US.UTF-8" > LC_MEASUREMENT="en_US.UTF-8" > LC_IDENTIFICATION="en_US.UTF-8" > LC_ALL= > > > and I am using git version 2.20.1 The problem is with wget and not with git. It is wget who rewrites å to something else. Thanks > > Thxs, Håkon >
> On 19 Feb 2019, at 14:10, Leon Romanovsky <leon@kernel.org> wrote: > > On Tue, Feb 19, 2019 at 01:58:02PM +0100, Håkon Bugge wrote: >> >> >>> On 19 Feb 2019, at 13:39, Leon Romanovsky <leon@kernel.org> wrote: >>> >>> On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote: >>>> >>>> >>>>> On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: >>>>> >>>>> On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: >>>>>> On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: >>>>>>> On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: >>>>>>>> On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: >>>>>>>>> On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: >>>>>>>>>> Add Mark and the undersigned as maintainers, removed Sean and Hal. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> >>>>>>>>> >>>>>>>>> Thanks applied with fix from Benjamin. >>>>>>>>> >>>>>>>>> Håkon, I would like you to ask you do not use special symbols in git >>>>>>>>> patches, it doesn't survive git am/patchworks. >>>>>>>> >>>>>>>> What flow did you use? I tested it and I didn't see a problem. IMHO >>>>>>>> this is a tooling bug. >>>>>>>> >>>>>>>> I've been careful to keep things UTF-8 clean as it seems appropriate >>>>>>>> to keep special characters in people's names. (and somone once yelled >>>>>>>> at me for not using °C in a patch) >>>>>>> >>>>>>> wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s >>>>>> >>>>>> Worked OK for me.. wget does locale conversions however, so your LANG= >>>>>> is probably not in a UTF-8 setting, or otherwise. >>>>> >>>>> _ kernel git:(rdma-next) locale >>>>> LANG=en_US.UTF-8 >>>>> LC_CTYPE="C" >>>>> LC_NUMERIC="C" >>>>> LC_TIME="C" >>>>> LC_COLLATE="C" >>>>> LC_MONETARY="C" >>>>> LC_MESSAGES="C" >>>>> LC_PAPER="C" >>>>> LC_NAME="C" >>>>> LC_ADDRESS="C" >>>>> LC_TELEPHONE="C" >>>>> LC_MEASUREMENT="C" >>>>> LC_IDENTIFICATION="C" >>>>> LC_ALL=C >>>> >>>> Looks like most maintainers ar eable to cope with my "å": >>> >>> Give me idea what should I need to change on my default linux machine >>> and I'll be able to cope with å too. >> >> I have: >> >>> locale >> LANG=en_US.UTF-8 >> LC_CTYPE="en_US.UTF-8" >> LC_NUMERIC="en_US.UTF-8" >> LC_TIME="en_US.UTF-8" >> LC_COLLATE="en_US.UTF-8" >> LC_MONETARY="en_US.UTF-8" >> LC_MESSAGES="en_US.UTF-8" >> LC_PAPER="en_US.UTF-8" >> LC_NAME="en_US.UTF-8" >> LC_ADDRESS="en_US.UTF-8" >> LC_TELEPHONE="en_US.UTF-8" >> LC_MEASUREMENT="en_US.UTF-8" >> LC_IDENTIFICATION="en_US.UTF-8" >> LC_ALL= >> >> >> and I am using git version 2.20.1 > > The problem is with wget and not with git. > It is wget who rewrites å to something else. Knut, Any idea as to Leon's UTF issue? Thxs, Håkon
On Tue, Feb 19, 2019 at 03:10:26PM +0200, Leon Romanovsky wrote: > On Tue, Feb 19, 2019 at 01:58:02PM +0100, Håkon Bugge wrote: > > > > > > > On 19 Feb 2019, at 13:39, Leon Romanovsky <leon@kernel.org> wrote: > > > > > > On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote: > > >> > > >> > > >>> On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: > > >>> > > >>> On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: > > >>>> On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: > > >>>>> On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > > >>>>>> On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > > >>>>>>> On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > >>>>>>>> Add Mark and the undersigned as maintainers, removed Sean and Hal. > > >>>>>>>> > > >>>>>>>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > >>>>>>> > > >>>>>>> Thanks applied with fix from Benjamin. > > >>>>>>> > > >>>>>>> Håkon, I would like you to ask you do not use special symbols in git > > >>>>>>> patches, it doesn't survive git am/patchworks. > > >>>>>> > > >>>>>> What flow did you use? I tested it and I didn't see a problem. IMHO > > >>>>>> this is a tooling bug. > > >>>>>> > > >>>>>> I've been careful to keep things UTF-8 clean as it seems appropriate > > >>>>>> to keep special characters in people's names. (and somone once yelled > > >>>>>> at me for not using °C in a patch) > > >>>>> > > >>>>> wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s > > >>>> > > >>>> Worked OK for me.. wget does locale conversions however, so your LANG= > > >>>> is probably not in a UTF-8 setting, or otherwise. > > >>> > > >>> _ kernel git:(rdma-next) locale > > >>> LANG=en_US.UTF-8 > > >>> LC_CTYPE="C" > > >>> LC_NUMERIC="C" > > >>> LC_TIME="C" > > >>> LC_COLLATE="C" > > >>> LC_MONETARY="C" > > >>> LC_MESSAGES="C" > > >>> LC_PAPER="C" > > >>> LC_NAME="C" > > >>> LC_ADDRESS="C" > > >>> LC_TELEPHONE="C" > > >>> LC_MEASUREMENT="C" > > >>> LC_IDENTIFICATION="C" > > >>> LC_ALL=C > > >> > > >> Looks like most maintainers ar eable to cope with my "å": > > > > > > Give me idea what should I need to change on my default linux machine > > > and I'll be able to cope with å too. > > > > I have: > > > > > locale > > LANG=en_US.UTF-8 > > LC_CTYPE="en_US.UTF-8" > > LC_NUMERIC="en_US.UTF-8" > > LC_TIME="en_US.UTF-8" > > LC_COLLATE="en_US.UTF-8" > > LC_MONETARY="en_US.UTF-8" > > LC_MESSAGES="en_US.UTF-8" > > LC_PAPER="en_US.UTF-8" > > LC_NAME="en_US.UTF-8" > > LC_ADDRESS="en_US.UTF-8" > > LC_TELEPHONE="en_US.UTF-8" > > LC_MEASUREMENT="en_US.UTF-8" > > LC_IDENTIFICATION="en_US.UTF-8" > > LC_ALL= > > > > > > and I am using git version 2.20.1 > > The problem is with wget and not with git. > It is wget who rewrites å to something else. I have the same settings as Hakon. I think your problem is LC_ALL=C, but this stuff always confused me. The problem is that wget is using the wrong locale, so one of those settings must fix it. You can also pass a command line option to wget to use the right url, or just don't use wget.. K had a link to modern patchworks tools. Jason
On Tue, 2019-02-19 at 19:57 +0100, Håkon Bugge wrote: > > On 19 Feb 2019, at 14:10, Leon Romanovsky <leon@kernel.org> wrote: > > > > On Tue, Feb 19, 2019 at 01:58:02PM +0100, Håkon Bugge wrote: > > > > > > > On 19 Feb 2019, at 13:39, Leon Romanovsky <leon@kernel.org> wrote: > > > > > > > > On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote: > > > > > > > > > > > On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: > > > > > > > > > > > > On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: > > > > > > > On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: > > > > > > > > On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > > > > > > > > > On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > > > > > > > > > > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > > > > > > > > > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > > > > > > > > > > > > > > > > > > > Thanks applied with fix from Benjamin. > > > > > > > > > > > > > > > > > > > > Håkon, I would like you to ask you do not use special symbols in git > > > > > > > > > > patches, it doesn't survive git am/patchworks. > > > > > > > > > > > > > > > > > > What flow did you use? I tested it and I didn't see a problem. IMHO > > > > > > > > > this is a tooling bug. > > > > > > > > > > > > > > > > > > I've been careful to keep things UTF-8 clean as it seems appropriate > > > > > > > > > to keep special characters in people's names. (and somone once yelled > > > > > > > > > at me for not using °C in a patch) > > > > > > > > > > > > > > > > wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s > > > > > > > > > > > > > > Worked OK for me.. wget does locale conversions however, so your LANG= > > > > > > > is probably not in a UTF-8 setting, or otherwise. > > > > > > > > > > > > _ kernel git:(rdma-next) locale > > > > > > LANG=en_US.UTF-8 > > > > > > LC_CTYPE="C" > > > > > > LC_NUMERIC="C" > > > > > > LC_TIME="C" > > > > > > LC_COLLATE="C" > > > > > > LC_MONETARY="C" > > > > > > LC_MESSAGES="C" > > > > > > LC_PAPER="C" > > > > > > LC_NAME="C" > > > > > > LC_ADDRESS="C" > > > > > > LC_TELEPHONE="C" > > > > > > LC_MEASUREMENT="C" > > > > > > LC_IDENTIFICATION="C" > > > > > > LC_ALL=C > > > > > > > > > > Looks like most maintainers ar eable to cope with my "å": > > > > > > > > Give me idea what should I need to change on my default linux machine > > > > and I'll be able to cope with å too. > > > > > > I have: > > > > > > > locale > > > LANG=en_US.UTF-8 > > > LC_CTYPE="en_US.UTF-8" > > > LC_NUMERIC="en_US.UTF-8" > > > LC_TIME="en_US.UTF-8" > > > LC_COLLATE="en_US.UTF-8" > > > LC_MONETARY="en_US.UTF-8" > > > LC_MESSAGES="en_US.UTF-8" > > > LC_PAPER="en_US.UTF-8" > > > LC_NAME="en_US.UTF-8" > > > LC_ADDRESS="en_US.UTF-8" > > > LC_TELEPHONE="en_US.UTF-8" > > > LC_MEASUREMENT="en_US.UTF-8" > > > LC_IDENTIFICATION="en_US.UTF-8" > > > LC_ALL= > > > > > > > > > and I am using git version 2.20.1 > > > > The problem is with wget and not with git. > > It is wget who rewrites å to something else. > > Knut, > > Any idea as to Leon's UTF issue? I would have suspected the LC_ALL=C setting like Jason, but my wget does not seem to change behaviour if I set LC_ALL=C, whether set in .bashrc or just exported or set with env in the shell. Leon, could it be that you have settings in a local ~/.wgetrc that causes issues? I tried setting localencoding and/or remoteencoding myself but at least my wget seems to completely refuse to do anything wrong with the proper encoded patchwork example above, whatever I try.. The documentation for wget says: Wget use the function "nl_langinfo()" and then the "CHARSET" environment variable to get the locale. If it fails, ASCII is used. but I wasn't able to make it break Håkon's "å" with CHARSET either.. Maybe your nl_langinfo somehow picks up the wrong info? Which wget do you run? I have wget-1.20.1-1.fc29.x86_64 Knut > > Thxs, Håkon >
On Wed, Feb 20, 2019 at 08:37:48AM +0100, Knut Omang wrote: > On Tue, 2019-02-19 at 19:57 +0100, Håkon Bugge wrote: > > > On 19 Feb 2019, at 14:10, Leon Romanovsky <leon@kernel.org> wrote: > > > > > > On Tue, Feb 19, 2019 at 01:58:02PM +0100, Håkon Bugge wrote: > > > > > > > > > On 19 Feb 2019, at 13:39, Leon Romanovsky <leon@kernel.org> wrote: > > > > > > > > > > On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote: > > > > > > > > > > > > > On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@kernel.org> wrote: > > > > > > > > > > > > > > On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote: > > > > > > > > On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote: > > > > > > > > > On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote: > > > > > > > > > > On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote: > > > > > > > > > > > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote: > > > > > > > > > > > > Add Mark and the undersigned as maintainers, removed Sean and Hal. > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > > > > > > > > > > > > > > > > > > > > > Thanks applied with fix from Benjamin. > > > > > > > > > > > > > > > > > > > > > > Håkon, I would like you to ask you do not use special symbols in git > > > > > > > > > > > patches, it doesn't survive git am/patchworks. > > > > > > > > > > > > > > > > > > > > What flow did you use? I tested it and I didn't see a problem. IMHO > > > > > > > > > > this is a tooling bug. > > > > > > > > > > > > > > > > > > > > I've been careful to keep things UTF-8 clean as it seems appropriate > > > > > > > > > > to keep special characters in people's names. (and somone once yelled > > > > > > > > > > at me for not using °C in a patch) > > > > > > > > > > > > > > > > > > wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s > > > > > > > > > > > > > > > > Worked OK for me.. wget does locale conversions however, so your LANG= > > > > > > > > is probably not in a UTF-8 setting, or otherwise. > > > > > > > > > > > > > > _ kernel git:(rdma-next) locale > > > > > > > LANG=en_US.UTF-8 > > > > > > > LC_CTYPE="C" > > > > > > > LC_NUMERIC="C" > > > > > > > LC_TIME="C" > > > > > > > LC_COLLATE="C" > > > > > > > LC_MONETARY="C" > > > > > > > LC_MESSAGES="C" > > > > > > > LC_PAPER="C" > > > > > > > LC_NAME="C" > > > > > > > LC_ADDRESS="C" > > > > > > > LC_TELEPHONE="C" > > > > > > > LC_MEASUREMENT="C" > > > > > > > LC_IDENTIFICATION="C" > > > > > > > LC_ALL=C > > > > > > > > > > > > Looks like most maintainers ar eable to cope with my "å": > > > > > > > > > > Give me idea what should I need to change on my default linux machine > > > > > and I'll be able to cope with å too. > > > > > > > > I have: > > > > > > > > > locale > > > > LANG=en_US.UTF-8 > > > > LC_CTYPE="en_US.UTF-8" > > > > LC_NUMERIC="en_US.UTF-8" > > > > LC_TIME="en_US.UTF-8" > > > > LC_COLLATE="en_US.UTF-8" > > > > LC_MONETARY="en_US.UTF-8" > > > > LC_MESSAGES="en_US.UTF-8" > > > > LC_PAPER="en_US.UTF-8" > > > > LC_NAME="en_US.UTF-8" > > > > LC_ADDRESS="en_US.UTF-8" > > > > LC_TELEPHONE="en_US.UTF-8" > > > > LC_MEASUREMENT="en_US.UTF-8" > > > > LC_IDENTIFICATION="en_US.UTF-8" > > > > LC_ALL= > > > > > > > > > > > > and I am using git version 2.20.1 > > > > > > The problem is with wget and not with git. > > > It is wget who rewrites å to something else. > > > > Knut, > > > > Any idea as to Leon's UTF issue? > > I would have suspected the LC_ALL=C setting like Jason, > but my wget does not seem to change behaviour if I set LC_ALL=C, > whether set in .bashrc or just exported or set with env in the shell. > > Leon, could it be that you have settings in a local ~/.wgetrc that causes > issues? > > I tried setting localencoding and/or remoteencoding myself > but at least my wget seems to completely refuse to do anything wrong > with the proper encoded patchwork example above, whatever I try.. > > The documentation for wget says: > > Wget use the function "nl_langinfo()" and then the "CHARSET" environment variable > to get the locale. If it fails, ASCII is used. > > but I wasn't able to make it break Håkon's "å" with CHARSET either.. > Maybe your nl_langinfo somehow picks up the wrong info? > > Which wget do you run? > > I have wget-1.20.1-1.fc29.x86_64 _ kernel git:(rdma-next) wget --version GNU Wget 1.19.5 built on linux-gnu. -cares +digest +gpgme +https +ipv6 +iri +large-file +metalink +nls +ntlm +opie +psl +ssl/gnutls Wgetrc: /etc/wgetrc (system) I tried to change in global wgetrc: #localencoding = UTF-8 to be localencoding = UTF-8 and run the following test: kernel git:(rdma-next) wget https://patchwork.kernel.org/patch/10809371/mbox/ && grep Signed-off-by index.html && rm index.html Signed-off-by: H_kon Bugge <haakon.bugge@oracle.com> "å" is not visible On my laptop, which has the same FC29 as on my server, I got proper SOB without any changes in /etc/wgetrc Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> With locale on "working" system is similar to yours: ➜ patches locale LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_IL.UTF-8 LC_TIME=en_IL.UTF-8 LC_COLLATE="en_US.UTF-8" LC_MONETARY=en_IL.UTF-8 LC_MESSAGES="en_US.UTF-8" LC_PAPER=en_IL.UTF-8 LC_NAME="en_US.UTF-8" LC_ADDRESS="en_US.UTF-8" LC_TELEPHONE="en_US.UTF-8" LC_MEASUREMENT=en_IL.UTF-8 LC_IDENTIFICATION="en_US.UTF-8" LC_ALL= I put the same values on my not-working machine and it didn't help. Thanks > > Knut > > > > > Thxs, Håkon > > >
On Wed, Feb 20, 2019 at 12:57:18PM +0200, Leon Romanovsky wrote:
> I put the same values on my not-working machine and it didn't help.
Perhaps that system doesn't have the right compiled locale data ? Make
sure locale-gen build it.
Jason
On Wed, Feb 20, 2019 at 04:57:46PM +0000, Jason Gunthorpe wrote: > On Wed, Feb 20, 2019 at 12:57:18PM +0200, Leon Romanovsky wrote: > > > I put the same values on my not-working machine and it didn't help. > > Perhaps that system doesn't have the right compiled locale data ? Make > sure locale-gen build it. I think that it has, I'll take offline my debug attempts. Thanks > > Jason
diff --git a/MAINTAINERS b/MAINTAINERS index 4a420b62..14c4fede 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -80,8 +80,8 @@ S: Supported F: providers/i40iw/ RDMA Communication Manager Assistant (for librdmacm.so) -M: Sean Hefty <sean.hefty@intel.com> -M: Hal Rosenstock <hal@dev.mellanox.co.il> +M: Håkon Bugge <haakon.bugge@oracle.com> +M: Mark Haywood <mark.haywood@oracle.com>> S: Supported F: ibacm/*
Add Mark and the undersigned as maintainers, removed Sean and Hal. Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)