| Message ID | 20190218080846.187942-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e4d1b2716b8859199c28f2ac5f984bd05a146a6b |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | brcmfmac: remove set but not used variable 'old_state' | expand |
On 2/18/2019 9:08 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c: In function 'brcmf_usb_state_change': > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:578:6: warning: > variable 'old_state' set but not used [-Wunused-but-set-variable] > > It's never used and can be removed. Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 2 -- > 1 file changed, 2 deletions(-)
YueHaibing <yuehaibing@huawei.com> wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c: In function 'brcmf_usb_state_change': > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:578:6: warning: > variable 'old_state' set but not used [-Wunused-but-set-variable] > > It's never used and can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-drivers-next.git, thanks. e4d1b2716b88 brcmfmac: remove set but not used variable 'old_state'
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index 76cfaf6999c8..398536b30b7a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c @@ -575,7 +575,6 @@ static void brcmf_usb_state_change(struct brcmf_usbdev_info *devinfo, int state) { struct brcmf_bus *bcmf_bus = devinfo->bus_pub.bus; - int old_state; brcmf_dbg(USB, "Enter, current state=%d, new state=%d\n", devinfo->bus_pub.state, state); @@ -583,7 +582,6 @@ brcmf_usb_state_change(struct brcmf_usbdev_info *devinfo, int state) if (devinfo->bus_pub.state == state) return; - old_state = devinfo->bus_pub.state; devinfo->bus_pub.state = state; /* update state of upper layer */
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c: In function 'brcmf_usb_state_change': drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:578:6: warning: variable 'old_state' set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 2 -- 1 file changed, 2 deletions(-)