| Message ID | 20190221103731.28978-1-horia.geanta@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | ae23a0fe58887a1c0518062b49bf8ac30209c26c |
| Headers | show |
| Series | soc: fsl: guts: make fsl_guts_get_svr() static | expand |
> -----Original Message----- > From: Horia Geantă <horia.geanta@nxp.com> > Sent: Thursday, February 21, 2019 6:38 PM > To: Leo Li <leoyang.li@nxp.com> > Cc: Y.b. Lu <yangbo.lu@nxp.com>; linuxppc-dev@lists.ozlabs.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: [PATCH] soc: fsl: guts: make fsl_guts_get_svr() static > > The export of fsl_guts_get_svr() is a left-over, it's currently used only internally > and users needing SoC information should use the generic soc_device > infrastructure. > [Y.b. Lu] Acked-by: Yangbo Lu <yangbo.lu@nxp.com> > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > --- > drivers/soc/fsl/guts.c | 3 +-- > include/linux/fsl/guts.h | 2 -- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index > 4f9655087bd7..63f6df86f9e5 100644 > --- a/drivers/soc/fsl/guts.c > +++ b/drivers/soc/fsl/guts.c > @@ -115,7 +115,7 @@ static const struct fsl_soc_die_attr > *fsl_soc_die_match( > return NULL; > } > > -u32 fsl_guts_get_svr(void) > +static u32 fsl_guts_get_svr(void) > { > u32 svr = 0; > > @@ -129,7 +129,6 @@ u32 fsl_guts_get_svr(void) > > return svr; > } > -EXPORT_SYMBOL(fsl_guts_get_svr); > > static int fsl_guts_probe(struct platform_device *pdev) { diff --git > a/include/linux/fsl/guts.h b/include/linux/fsl/guts.h index > 941b11811f85..1fc0edd71c52 100644 > --- a/include/linux/fsl/guts.h > +++ b/include/linux/fsl/guts.h > @@ -135,8 +135,6 @@ struct ccsr_guts { > u32 srds2cr1; /* 0x.0f44 - SerDes2 Control Register 0 */ > } __attribute__ ((packed)); > > -u32 fsl_guts_get_svr(void); > - > /* Alternate function signal multiplex control */ #define > MPC85xx_PMUXCR_QE(x) (0x8000 >> (x)) > > -- > 2.16.2
On Fri, Feb 22, 2019 at 2:09 AM Y.b. Lu <yangbo.lu@nxp.com> wrote: > > > > > -----Original Message----- > > From: Horia Geantă <horia.geanta@nxp.com> > > Sent: Thursday, February 21, 2019 6:38 PM > > To: Leo Li <leoyang.li@nxp.com> > > Cc: Y.b. Lu <yangbo.lu@nxp.com>; linuxppc-dev@lists.ozlabs.org; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > > Subject: [PATCH] soc: fsl: guts: make fsl_guts_get_svr() static > > > > The export of fsl_guts_get_svr() is a left-over, it's currently used only internally > > and users needing SoC information should use the generic soc_device > > infrastructure. > > > > [Y.b. Lu] Acked-by: Yangbo Lu <yangbo.lu@nxp.com> Applied for next. Thanks. > > > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > > --- > > drivers/soc/fsl/guts.c | 3 +-- > > include/linux/fsl/guts.h | 2 -- > > 2 files changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index > > 4f9655087bd7..63f6df86f9e5 100644 > > --- a/drivers/soc/fsl/guts.c > > +++ b/drivers/soc/fsl/guts.c > > @@ -115,7 +115,7 @@ static const struct fsl_soc_die_attr > > *fsl_soc_die_match( > > return NULL; > > } > > > > -u32 fsl_guts_get_svr(void) > > +static u32 fsl_guts_get_svr(void) > > { > > u32 svr = 0; > > > > @@ -129,7 +129,6 @@ u32 fsl_guts_get_svr(void) > > > > return svr; > > } > > -EXPORT_SYMBOL(fsl_guts_get_svr); > > > > static int fsl_guts_probe(struct platform_device *pdev) { diff --git > > a/include/linux/fsl/guts.h b/include/linux/fsl/guts.h index > > 941b11811f85..1fc0edd71c52 100644 > > --- a/include/linux/fsl/guts.h > > +++ b/include/linux/fsl/guts.h > > @@ -135,8 +135,6 @@ struct ccsr_guts { > > u32 srds2cr1; /* 0x.0f44 - SerDes2 Control Register 0 */ > > } __attribute__ ((packed)); > > > > -u32 fsl_guts_get_svr(void); > > - > > /* Alternate function signal multiplex control */ #define > > MPC85xx_PMUXCR_QE(x) (0x8000 >> (x)) > > > > -- > > 2.16.2 >
diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 4f9655087bd7..63f6df86f9e5 100644 --- a/drivers/soc/fsl/guts.c +++ b/drivers/soc/fsl/guts.c @@ -115,7 +115,7 @@ static const struct fsl_soc_die_attr *fsl_soc_die_match( return NULL; } -u32 fsl_guts_get_svr(void) +static u32 fsl_guts_get_svr(void) { u32 svr = 0; @@ -129,7 +129,6 @@ u32 fsl_guts_get_svr(void) return svr; } -EXPORT_SYMBOL(fsl_guts_get_svr); static int fsl_guts_probe(struct platform_device *pdev) { diff --git a/include/linux/fsl/guts.h b/include/linux/fsl/guts.h index 941b11811f85..1fc0edd71c52 100644 --- a/include/linux/fsl/guts.h +++ b/include/linux/fsl/guts.h @@ -135,8 +135,6 @@ struct ccsr_guts { u32 srds2cr1; /* 0x.0f44 - SerDes2 Control Register 0 */ } __attribute__ ((packed)); -u32 fsl_guts_get_svr(void); - /* Alternate function signal multiplex control */ #define MPC85xx_PMUXCR_QE(x) (0x8000 >> (x))
The export of fsl_guts_get_svr() is a left-over, it's currently used only internally and users needing SoC information should use the generic soc_device infrastructure. Signed-off-by: Horia Geantă <horia.geanta@nxp.com> --- drivers/soc/fsl/guts.c | 3 +-- include/linux/fsl/guts.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-)