| Message ID | 20190219101629.15977-1-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | input: touchscreen: Add goodix GT5553 CTP support | expand |
Hi Dmitry, On Tue, Feb 19, 2019 at 3:46 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > This is v6 patchset for supporting goodix GT5553 CTP. Here is the > previous version[1] > > Changes for v5: > - document bindings for required regulators, which are need during > power-on sequence > - enable, disable required regulators as described in power-on sequence > using normal regulator calls > - update the proper commi messages > Changes for v4: > - document AVDD22, DVDD12, VDDIO as optional properties > - use regulator bulk calls, for get, enable and disable functionalities > Changes for v4: > - devm_add_action_or_reset for disabling regulator > Changes for v3: > - add cover-letter > - s/ADVV28/AVDD28 on commit head > - fix few typo > Changes for v2: > - Rename vcc-supply with AVDD28-supply > - disable regulator in remove > - fix to setup regulator in probe code > - add chipdata > - drop example node in dt-bindings > > [1] https://patchwork.kernel.org/cover/10816901/ > > Jagan Teki (4): > dt-bindings: input: touchscreen: goodix: Document regulator properties > Input: goodix - Add regulators suppot > dt-bindings: input: touchscreen: goodix: Add GT5663 compatible > Input: goodix - Add GT5663 CTP support > > .../bindings/input/touchscreen/goodix.txt | 3 + > drivers/input/touchscreen/goodix.c | 60 +++++++++++++++++++ > 2 files changed, 63 insertions(+) Let me know if you have any further comments on regulator patch, fyi Rob reviewed it already.
Hi Dmitry, On Tue, Feb 26, 2019 at 11:43 AM Jagan Teki <jagan@amarulasolutions.com> wrote: > > Hi Dmitry, > > On Tue, Feb 19, 2019 at 3:46 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > This is v6 patchset for supporting goodix GT5553 CTP. Here is the > > previous version[1] > > > > Changes for v5: > > - document bindings for required regulators, which are need during > > power-on sequence > > - enable, disable required regulators as described in power-on sequence > > using normal regulator calls > > - update the proper commi messages > > Changes for v4: > > - document AVDD22, DVDD12, VDDIO as optional properties > > - use regulator bulk calls, for get, enable and disable functionalities > > Changes for v4: > > - devm_add_action_or_reset for disabling regulator > > Changes for v3: > > - add cover-letter > > - s/ADVV28/AVDD28 on commit head > > - fix few typo > > Changes for v2: > > - Rename vcc-supply with AVDD28-supply > > - disable regulator in remove > > - fix to setup regulator in probe code > > - add chipdata > > - drop example node in dt-bindings > > > > [1] https://patchwork.kernel.org/cover/10816901/ > > > > Jagan Teki (4): > > dt-bindings: input: touchscreen: goodix: Document regulator properties > > Input: goodix - Add regulators suppot > > dt-bindings: input: touchscreen: goodix: Add GT5663 compatible > > Input: goodix - Add GT5663 CTP support > > > > .../bindings/input/touchscreen/goodix.txt | 3 + > > drivers/input/touchscreen/goodix.c | 60 +++++++++++++++++++ > > 2 files changed, 63 insertions(+) > > Let me know if you have any further comments on regulator patch, fyi > Rob reviewed it already. Would you comment on this? few dts changes are pending for this to support. Jagan.
On Wed, Mar 6, 2019 at 10:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > Hi Dmitry, > > On Tue, Feb 26, 2019 at 11:43 AM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > Hi Dmitry, > > > > On Tue, Feb 19, 2019 at 3:46 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > > > This is v6 patchset for supporting goodix GT5553 CTP. Here is the > > > previous version[1] > > > > > > Changes for v5: > > > - document bindings for required regulators, which are need during > > > power-on sequence > > > - enable, disable required regulators as described in power-on sequence > > > using normal regulator calls > > > - update the proper commi messages > > > Changes for v4: > > > - document AVDD22, DVDD12, VDDIO as optional properties > > > - use regulator bulk calls, for get, enable and disable functionalities > > > Changes for v4: > > > - devm_add_action_or_reset for disabling regulator > > > Changes for v3: > > > - add cover-letter > > > - s/ADVV28/AVDD28 on commit head > > > - fix few typo > > > Changes for v2: > > > - Rename vcc-supply with AVDD28-supply > > > - disable regulator in remove > > > - fix to setup regulator in probe code > > > - add chipdata > > > - drop example node in dt-bindings > > > > > > [1] https://patchwork.kernel.org/cover/10816901/ > > > > > > Jagan Teki (4): > > > dt-bindings: input: touchscreen: goodix: Document regulator properties > > > Input: goodix - Add regulators suppot > > > dt-bindings: input: touchscreen: goodix: Add GT5663 compatible > > > Input: goodix - Add GT5663 CTP support > > > > > > .../bindings/input/touchscreen/goodix.txt | 3 + > > > drivers/input/touchscreen/goodix.c | 60 +++++++++++++++++++ > > > 2 files changed, 63 insertions(+) > > > > Let me know if you have any further comments on regulator patch, fyi > > Rob reviewed it already. > > Would you comment on this? few dts changes are pending for this to support. Gentle remainder.
Hi Dmitry, On Mon, Mar 11, 2019 at 7:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > On Wed, Mar 6, 2019 at 10:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > Hi Dmitry, > > > > On Tue, Feb 26, 2019 at 11:43 AM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > > > Hi Dmitry, > > > > > > On Tue, Feb 19, 2019 at 3:46 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > > > > > This is v6 patchset for supporting goodix GT5553 CTP. Here is the > > > > previous version[1] > > > > > > > > Changes for v5: > > > > - document bindings for required regulators, which are need during > > > > power-on sequence > > > > - enable, disable required regulators as described in power-on sequence > > > > using normal regulator calls > > > > - update the proper commi messages > > > > Changes for v4: > > > > - document AVDD22, DVDD12, VDDIO as optional properties > > > > - use regulator bulk calls, for get, enable and disable functionalities > > > > Changes for v4: > > > > - devm_add_action_or_reset for disabling regulator > > > > Changes for v3: > > > > - add cover-letter > > > > - s/ADVV28/AVDD28 on commit head > > > > - fix few typo > > > > Changes for v2: > > > > - Rename vcc-supply with AVDD28-supply > > > > - disable regulator in remove > > > > - fix to setup regulator in probe code > > > > - add chipdata > > > > - drop example node in dt-bindings > > > > > > > > [1] https://patchwork.kernel.org/cover/10816901/ > > > > > > > > Jagan Teki (4): > > > > dt-bindings: input: touchscreen: goodix: Document regulator properties > > > > Input: goodix - Add regulators suppot > > > > dt-bindings: input: touchscreen: goodix: Add GT5663 compatible > > > > Input: goodix - Add GT5663 CTP support > > > > > > > > .../bindings/input/touchscreen/goodix.txt | 3 + > > > > drivers/input/touchscreen/goodix.c | 60 +++++++++++++++++++ > > > > 2 files changed, 63 insertions(+) > > > > > > Let me know if you have any further comments on regulator patch, fyi > > > Rob reviewed it already. > > > > Would you comment on this? few dts changes are pending for this to support. > > Gentle remainder. It's been several weeks, any further comments?