mbox series

[v6,0/3] drm & vgaarb: handle vgacon removal in vgaarb.

Message ID 20190225083009.16082-1-kraxel@redhat.com (mailing list archive)
Headers show
Series drm & vgaarb: handle vgacon removal in vgaarb. | expand

Message

Gerd Hoffmann Feb. 25, 2019, 8:30 a.m. UTC
v6: buildfix.

Gerd Hoffmann (3):
  drm: move i915_kick_out_vgacon to vgaarb
  drm/fb-helper: call vga_remove_vgacon automatically.
  drm/qxl: remove conflicting framebuffers earlier

 include/drm/drm_fb_helper.h     | 14 +++++++++---
 include/linux/vgaarb.h          |  2 ++
 drivers/gpu/drm/i915/i915_drv.c | 35 +-----------------------------
 drivers/gpu/drm/qxl/qxl_drv.c   |  5 ++++-
 drivers/gpu/vga/vgaarb.c        | 48 +++++++++++++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+), 38 deletions(-)

Comments

Daniel Vetter Feb. 28, 2019, 10:52 a.m. UTC | #1
Adding intel-gfx and CI folks.

On Thu, Feb 28, 2019 at 9:22 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
> Quick question on the Intel CI:  How does it work?  I've seen it sending
> mails.  Does it report failures only, i.e. no news is good news?  How
> long does it usually take to run the tests?  Is waiting a day enough?
> Is there a website where I can see the test results?

It always reports, and result links also get dumped onto patchwork (in
the series view). There's 2 main runs: BAT and IGT (first with more
machines, 2nd with more tests). BAT should be there within a few hours
at most, IGT sometimes takes 1 day when there's a big backlog.

-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Arkadiusz Hiler Feb. 28, 2019, 11:03 a.m. UTC | #2
On Thu, Feb 28, 2019 at 11:52:39AM +0100, Daniel Vetter wrote:
> Adding intel-gfx and CI folks.
> 
> On Thu, Feb 28, 2019 at 9:22 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Quick question on the Intel CI:  How does it work?  I've seen it sending
> > mails.  Does it report failures only, i.e. no news is good news?  How
> > long does it usually take to run the tests?  Is waiting a day enough?
> > Is there a website where I can see the test results?
> 
> It always reports, and result links also get dumped onto patchwork (in
> the series view). There's 2 main runs: BAT and IGT (first with more
> machines, 2nd with more tests). BAT should be there within a few hours
> at most, IGT sometimes takes 1 day when there's a big backlog.
> 
> -Daniel

Hey,

We try to explain our CI here: https://intel-gfx-ci.01.org/

By the questions you have asked I already see that we should add
information on the results being sent out for successes too and give
some time estimations.

If you see anything elase missing and/or have suggestions on how to
improve what is already there it would be greatly appreciated :-)
Gerd Hoffmann Feb. 28, 2019, 1:27 p.m. UTC | #3
On Thu, Feb 28, 2019 at 01:03:14PM +0200, Arkadiusz Hiler wrote:
> On Thu, Feb 28, 2019 at 11:52:39AM +0100, Daniel Vetter wrote:
> > Adding intel-gfx and CI folks.
> > 
> > On Thu, Feb 28, 2019 at 9:22 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
> > > Quick question on the Intel CI:  How does it work?  I've seen it sending
> > > mails.  Does it report failures only, i.e. no news is good news?  How
> > > long does it usually take to run the tests?  Is waiting a day enough?
> > > Is there a website where I can see the test results?
> > 
> > It always reports, and result links also get dumped onto patchwork (in
> > the series view). There's 2 main runs: BAT and IGT (first with more
> > machines, 2nd with more tests). BAT should be there within a few hours
> > at most, IGT sometimes takes 1 day when there's a big backlog.
> > 
> > -Daniel
> 
> Hey,
> 
> We try to explain our CI here: https://intel-gfx-ci.01.org/
> 
> By the questions you have asked I already see that we should add
> information on the results being sent out for successes too and give
> some time estimations.

Hmm, I see the test results in patchwork, but I can't remember having
seen a mail.  So the next question: where the results are sent to?

cheers,
  Gerd
Saarinen, Jani Feb. 28, 2019, 3:20 p.m. UTC | #4
HI, 

> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of Gerd
> Hoffmann
> Sent: torstai 28. helmikuuta 2019 15.28
> To: Hiler, Arkadiusz <arkadiusz.hiler@intel.com>
> Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; intel-gfx <intel-
> gfx@lists.freedesktop.org>
> Subject: Re: [Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in
> vgaarb.
> 
> On Thu, Feb 28, 2019 at 01:03:14PM +0200, Arkadiusz Hiler wrote:
> > On Thu, Feb 28, 2019 at 11:52:39AM +0100, Daniel Vetter wrote:
> > > Adding intel-gfx and CI folks.
> > >
> > > On Thu, Feb 28, 2019 at 9:22 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
> > > > Quick question on the Intel CI:  How does it work?  I've seen it
> > > > sending mails.  Does it report failures only, i.e. no news is good
> > > > news?  How long does it usually take to run the tests?  Is waiting a day enough?
> > > > Is there a website where I can see the test results?
> > >
> > > It always reports, and result links also get dumped onto patchwork
> > > (in the series view). There's 2 main runs: BAT and IGT (first with
> > > more machines, 2nd with more tests). BAT should be there within a
> > > few hours at most, IGT sometimes takes 1 day when there's a big backlog.
> > >
> > > -Daniel
> >
> > Hey,
> >
> > We try to explain our CI here: https://intel-gfx-ci.01.org/
> >
> > By the questions you have asked I already see that we should add
> > information on the results being sent out for successes too and give
> > some time estimations.
> 
> Hmm, I see the test results in patchwork, but I can't remember having seen a mail.
> So the next question: where the results are sent to?
From page above sent by Arek:
" Since we accept patches through mailing lists, this is where you can find the results - they are sent out as a replies to the original mail. Here are the mailing lists we currently support:"

> 
> cheers,
>   Gerd
Br,
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Gerd Hoffmann March 1, 2019, 6:12 a.m. UTC | #5
Hi,

> > Hmm, I see the test results in patchwork, but I can't remember having seen a mail.
> > So the next question: where the results are sent to?
> From page above sent by Arek:
> " Since we accept patches through mailing lists, this is where you can
> find the results - they are sent out as a replies to the original
> mail. Here are the mailing lists we currently support:"

Hmm, I'm not subscribed to intel-gfx, so that explains why I havn't
seen the result mails.  Any chance to sent the results also to the
patch submitter?

thanks,
  Gerd
Saarinen, Jani March 1, 2019, 7:07 a.m. UTC | #6
Hi,

> -----Original Message-----
> From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> Sent: perjantai 1. maaliskuuta 2019 8.12
> To: Saarinen, Jani <jani.saarinen@intel.com>
> Cc: Hiler, Arkadiusz <arkadiusz.hiler@intel.com>; Sarvela, Tomi P
> <tomi.p.sarvela@intel.com>; intel-gfx <intel-gfx@lists.freedesktop.org>
> Subject: Re: [Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in
> vgaarb.
> 
>   Hi,
> 
> > > Hmm, I see the test results in patchwork, but I can't remember having seen a
> mail.
> > > So the next question: where the results are sent to?
> > From page above sent by Arek:
> > " Since we accept patches through mailing lists, this is where you can
> > find the results - they are sent out as a replies to the original
> > mail. Here are the mailing lists we currently support:"
> 
> Hmm, I'm not subscribed to intel-gfx, so that explains why I havn't seen the result
> mails.  Any chance to sent the results also to the patch submitter?
It patches are sent to mailing list(s) (intel-gfx, trybot or igt-dev) and patches apply or not cleanly to latest drm-tip then results are sent both to developer and list as cc. 
Arek, Tomi, any other comments?

> 
> thanks,
>   Gerd
Arkadiusz Hiler March 1, 2019, 10:37 a.m. UTC | #7
On Fri, Mar 01, 2019 at 07:12:04AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > Hmm, I see the test results in patchwork, but I can't remember having seen a mail.
> > > So the next question: where the results are sent to?
> > From page above sent by Arek:
> > " Since we accept patches through mailing lists, this is where you can
> > find the results - they are sent out as a replies to the original
> > mail. Here are the mailing lists we currently support:"
> 
> Hmm, I'm not subscribed to intel-gfx, so that explains why I havn't
> seen the result mails.  Any chance to sent the results also to the
> patch submitter?

Yes, this is the case now. I re-enabled sending the result emails to the
authors just yesterday.

We had it like that since forever, but recently there was an change to
fdo mailing lists which was overwritting "From" headers to workaround
some delivery issues, so this feature had to be temporaily disabled.

Sorry for the incovenience.