fix usb2 on rock64

Commit Message

Dan Johansen March 8, 2019, 7:35 a.m. UTC

From 5d027bc9dc27b7bb46268e2f92e853368e5f097f Mon Sep 17 00:00:00 2001
 From: Strit <[e-mail]>
Date: Tue, 5 Mar 2019 16:35:48 +0100
Subject: [PATCH] fix usb2 port on rock64

Fix the issue with usb not getting power on the rock64 board from 
pine64.org.

Signed-off-by: Dan Johansen <[e-mail]>

---
  arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tomohiro Mayama March 8, 2019, 10:48 a.m. UTC | #1

Hello Dan,

On 2019/03/08 16:35, Dan Johansen wrote:
> -        gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> +        gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>;

According to Robin's advice by reading the schematic, correct GPIO pin
assignment is RK_PA2, but GPIO_ACTIVE_LOW. This fixed the USB problem
for me.

Please see the following thread:
https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023298.html

Also please see this patch:
https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023300.html

Or won't your problem be fixed with this patch?

Regards,
Tomohiro

Dan Johansen Aug. 23, 2019, 9:56 a.m. UTC | #2

Tomohiro Mayama skrev den 2019-03-08 11:48:
> Hello Dan,
> 
> On 2019/03/08 16:35, Dan Johansen wrote:
>> -        gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
>> +        gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>;
> 
> According to Robin's advice by reading the schematic, correct GPIO pin
> assignment is RK_PA2, but GPIO_ACTIVE_LOW. This fixed the USB problem
> for me.
> 
> Please see the following thread:
> https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023298.html
> 
> Also please see this patch:
> https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023300.html
> 
> Or won't your problem be fixed with this patch?
> 
> Regards,
> Tomohiro

Ah, didn't see that one.
Yes it does.
Sorry. Please remove this patch submission.

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts 
b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 040b36ef0dd2..4877eb1c095a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -47,7 +47,7 @@ 
  	vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
  		compatible = "regulator-fixed";
  		enable-active-high;
-		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>;
  		pinctrl-names = "default";
  		pinctrl-0 = <&usb20_host_drv>;
  		regulator-name = "vcc_host1_5v";
@@ -266,7 +266,7 @@ 

  	usb2 {
  		usb20_host_drv: usb20-host-drv {
-			rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
+			rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>;
  		};
  	};