Message ID | 66af3908ab0a63a6768f3d75a87abf4056a9f8cf.camel@perches.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW) | expand |
On Thu, Mar 07, 2019 at 03:56:34PM -0800, Joe Perches wrote: > IS_ENABLED should generally use CONFIG_ prefaced symbols and > it doesn't appear as if there is a CMODEL_MEDLOW define. > > Signed-off-by: Joe Perches <joe@perches.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
On Fri, 08 Mar 2019 06:53:02 PST (-0800), Christoph Hellwig wrote: > On Thu, Mar 07, 2019 at 03:56:34PM -0800, Joe Perches wrote: >> IS_ENABLED should generally use CONFIG_ prefaced symbols and >> it doesn't appear as if there is a CMODEL_MEDLOW define. >> >> Signed-off-by: Joe Perches <joe@perches.com> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> Thanks. This one is also in the list for the next RC.
diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c index 7dd308129b40..2872edce894d 100644 --- a/arch/riscv/kernel/module.c +++ b/arch/riscv/kernel/module.c @@ -141,7 +141,7 @@ static int apply_r_riscv_hi20_rela(struct module *me, u32 *location, { s32 hi20; - if (IS_ENABLED(CMODEL_MEDLOW)) { + if (IS_ENABLED(CONFIG_CMODEL_MEDLOW)) { pr_err( "%s: target %016llx can not be addressed by the 32-bit offset from PC = %p\n", me->name, (long long)v, location);
IS_ENABLED should generally use CONFIG_ prefaced symbols and it doesn't appear as if there is a CMODEL_MEDLOW define. Signed-off-by: Joe Perches <joe@perches.com> --- arch/riscv/kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)