diff mbox series

[v1] HID: quirks: Drop misused kernel-doc annotation

Message ID 20190305111525.25800-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Mainlined
Commit 78b92f5f00cb3dbca0553f50847232eef60ccff4
Delegated to: Jiri Kosina
Headers show
Series [v1] HID: quirks: Drop misused kernel-doc annotation | expand

Commit Message

Andy Shevchenko March 5, 2019, 11:15 a.m. UTC
The kernel-doc annotation is misused for hid_mouse_ignore_list. The script
complains about it:

drivers/hid/hid-quirks.c:894: warning: cannot understand function prototype: 'const struct hid_device_id hid_mouse_ignore_list[] = '

Drop the annotation to make script happy.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/hid/hid-quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Benjamin Tissoires March 11, 2019, 2:55 p.m. UTC | #1
On Tue, Mar 5, 2019 at 12:15 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The kernel-doc annotation is misused for hid_mouse_ignore_list. The script
> complains about it:
>
> drivers/hid/hid-quirks.c:894: warning: cannot understand function prototype: 'const struct hid_device_id hid_mouse_ignore_list[] = '
>
> Drop the annotation to make script happy.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Applied to for-5.1/upstream-fixes

Cheers,
Benjamin

>  drivers/hid/hid-quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> index 94088c0ed68a..955451cad564 100644
> --- a/drivers/hid/hid-quirks.c
> +++ b/drivers/hid/hid-quirks.c
> @@ -884,7 +884,7 @@ static const struct hid_device_id hid_ignore_list[] = {
>         { }
>  };
>
> -/**
> +/*
>   * hid_mouse_ignore_list - mouse devices which should not be handled by the hid layer
>   *
>   * There are composite devices for which we want to ignore only a certain
> --
> 2.20.1
>
diff mbox series

Patch

diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index 94088c0ed68a..955451cad564 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -884,7 +884,7 @@  static const struct hid_device_id hid_ignore_list[] = {
 	{ }
 };
 
-/**
+/*
  * hid_mouse_ignore_list - mouse devices which should not be handled by the hid layer
  *
  * There are composite devices for which we want to ignore only a certain