diff mbox series

[v6,09/11] hw/pvrdma: Delete pvrdma_exit function

Message ID 1552300155-25216-10-git-send-email-yuval.shaia@oracle.com (mailing list archive)
State New, archived
Headers show
Series Misc fixes to pvrdma device | expand

Commit Message

Yuval Shaia March 11, 2019, 10:29 a.m. UTC 
This hook is not called and was implemented by mistake.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
 hw/rdma/vmw/pvrdma_main.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Kamal Heib March 12, 2019, 9:07 a.m. UTC | #1 
On 3/11/19 12:29 PM, Yuval Shaia wrote:
> This hook is not called and was implemented by mistake.
> 
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> ---
>  hw/rdma/vmw/pvrdma_main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index 04845f4..a4afced 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -654,11 +654,6 @@ out:
>      }
>  }
>  
> -static void pvrdma_exit(PCIDevice *pdev)
> -{
> -    pvrdma_fini(pdev);
> -}
> -
>  static void pvrdma_class_init(ObjectClass *klass, void *data)
>  {
>      DeviceClass *dc = DEVICE_CLASS(klass);
> @@ -666,7 +661,6 @@ static void pvrdma_class_init(ObjectClass *klass, void *data)
>      RdmaProviderClass *ir = INTERFACE_RDMA_PROVIDER_CLASS(klass);
>  
>      k->realize = pvrdma_realize;
> -    k->exit = pvrdma_exit;
>      k->vendor_id = PCI_VENDOR_ID_VMWARE;
>      k->device_id = PCI_DEVICE_ID_VMWARE_PVRDMA;
>      k->revision = 0x00;
> 

Reviewed-by: Kamal Heib <kamalheib1@gmail.com>
diff mbox series

Patch

diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 04845f4..a4afced 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -654,11 +654,6 @@  out:
     }
 }
 
-static void pvrdma_exit(PCIDevice *pdev)
-{
-    pvrdma_fini(pdev);
-}
-
 static void pvrdma_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
@@ -666,7 +661,6 @@  static void pvrdma_class_init(ObjectClass *klass, void *data)
     RdmaProviderClass *ir = INTERFACE_RDMA_PROVIDER_CLASS(klass);
 
     k->realize = pvrdma_realize;
-    k->exit = pvrdma_exit;
     k->vendor_id = PCI_VENDOR_ID_VMWARE;
     k->device_id = PCI_DEVICE_ID_VMWARE_PVRDMA;
     k->revision = 0x00;