diff mbox series

[v2,2/2] arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config

Message ID 20190313105816.8592-3-horms+renesas@verge.net.au (mailing list archive)
State Accepted
Commit 474706117c2baa68bf053f16cd35618d30bf4c06
Delegated to: Simon Horman
Headers show
Series arm64: dts: renesas: ebisu: support S2RAM | expand

Commit Message

Simon Horman March 13, 2019, 10:58 a.m. UTC
On Ebisu the DDR0 power rail needs to be kept powered when backup mode is
enabled.  Reflect this in the "rohm,ddr-backup-power" property for the
BD9571MWV PMIC node.

The accessory power switch (SW23) is a toggle switch, hence specify
"rohm,rstbmode-level".

Based on advice from Geert Uytterhoeven.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven March 13, 2019, 12:17 p.m. UTC | #1
On Wed, Mar 13, 2019 at 11:58 AM Simon Horman
<horms+renesas@verge.net.au> wrote:
> On Ebisu the DDR0 power rail needs to be kept powered when backup mode is
> enabled.  Reflect this in the "rohm,ddr-backup-power" property for the
> BD9571MWV PMIC node.
>
> The accessory power switch (SW23) is a toggle switch, hence specify
> "rohm,rstbmode-level".
>
> Based on advice from Geert Uytterhoeven.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Simon Horman March 14, 2019, 10:44 a.m. UTC | #2
On Wed, Mar 13, 2019 at 01:17:30PM +0100, Geert Uytterhoeven wrote:
> On Wed, Mar 13, 2019 at 11:58 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > On Ebisu the DDR0 power rail needs to be kept powered when backup mode is
> > enabled.  Reflect this in the "rohm,ddr-backup-power" property for the
> > BD9571MWV PMIC node.
> >
> > The accessory power switch (SW23) is a toggle switch, hence specify
> > "rohm,rstbmode-level".
> >
> > Based on advice from Geert Uytterhoeven.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v5.2.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 18a99d2e1ea5..0e873ccfd9e5 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -466,6 +466,8 @@ 
 		#interrupt-cells = <2>;
 		gpio-controller;
 		#gpio-cells = <2>;
+		rohm,ddr-backup-power = <0x1>;
+		rohm,rstbmode-level;
 	};
 };