| Message ID | 20190303165532.23727-3-tomli@tomli.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: sm750fb: trivial style fixes. | expand |
On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote: > Rename the function setDisplayControl() to set_display_control(). > This fixes the following checkpatch.pl warning: > > CHECK: Avoid CamelCase: <setDisplayControl> > > Suggested-by: Jin Chen <nobijinc@gmail.com> > Signed-off-by: Jin Chen <nobijinc@gmail.com> > [tomli@tomli.me: resent as trivial patch, reworded the commit message] > Signed-off-by: Yifeng Li <tomli@tomli.me> I've already applied Jin's patch to the tree, so no need to resend this. thanks, greg k-h
On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote: > Rename the function setDisplayControl() to set_display_control(). > This fixes the following checkpatch.pl warning: > > CHECK: Avoid CamelCase: <setDisplayControl> > > Suggested-by: Jin Chen <nobijinc@gmail.com> > Signed-off-by: Jin Chen <nobijinc@gmail.com> > [tomli@tomli.me: resent as trivial patch, reworded the commit message] > Signed-off-by: Yifeng Li <tomli@tomli.me> > --- Apparently Greg already applied this earlier... I don't know why the original patch didn't reach me. I'm on the devel@driverdev.osuosl.org list. Did Jin Chen write this? If so why does it have a Suggested-by tag for him? If not then you should have preserved the authorship credit by using the From: header in the first line on the commit message... Anyway, it doesn't matter but hopefully this helps for next time. regards, dan carpenter
diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c index 1273e7d18925..f38051eedb6c 100644 --- a/drivers/staging/sm750fb/ddk750_display.c +++ b/drivers/staging/sm750fb/ddk750_display.c @@ -5,7 +5,7 @@ #include "ddk750_power.h" #include "ddk750_dvi.h" -static void setDisplayControl(int ctrl, int disp_state) +static void set_display_control(int ctrl, int disp_state) { /* state != 0 means turn on both timing & plane en_bit */ unsigned long reg, val, reserved; @@ -137,12 +137,12 @@ void ddk750_setLogicalDispOut(enum disp_output output) if (output & PRI_TP_USAGE) { /* set primary timing and plane en_bit */ - setDisplayControl(0, (output & PRI_TP_MASK) >> PRI_TP_OFFSET); + set_display_control(0, (output & PRI_TP_MASK) >> PRI_TP_OFFSET); } if (output & SEC_TP_USAGE) { /* set secondary timing and plane en_bit*/ - setDisplayControl(1, (output & SEC_TP_MASK) >> SEC_TP_OFFSET); + set_display_control(1, (output & SEC_TP_MASK) >> SEC_TP_OFFSET); } if (output & PNL_SEQ_USAGE) {
Rename the function setDisplayControl() to set_display_control(). This fixes the following checkpatch.pl warning: CHECK: Avoid CamelCase: <setDisplayControl> Suggested-by: Jin Chen <nobijinc@gmail.com> Signed-off-by: Jin Chen <nobijinc@gmail.com> [tomli@tomli.me: resent as trivial patch, reworded the commit message] Signed-off-by: Yifeng Li <tomli@tomli.me> --- drivers/staging/sm750fb/ddk750_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)