| Message ID | 20190308183743.11145-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup | expand |
On Fri, Mar 8, 2019 at 10:38 AM Nathan Chancellor <natechancellor@gmail.com> wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' > is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > It's not wrong; when options is NULL, baud has no default value. Use > 9600 as that is a sane default. > > Link: https://github.com/ClangBuiltLinux/linux/issues/395 > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Great find. Thanks for the fix, and thanks Greg for the advice and additional analysis here. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/tty/serial/qcom_geni_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 3bcec1c20219..35e5f9c5d5be 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -1050,7 +1050,7 @@ static int __init qcom_geni_console_setup(struct console *co, char *options) > { > struct uart_port *uport; > struct qcom_geni_serial_port *port; > - int baud; > + int baud = 9600; > int bits = 8; > int parity = 'n'; > int flow = 'n'; > -- > 2.21.0 >
On Fri, Mar 8, 2019 at 7:38 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' > is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > It's not wrong; when options is NULL, baud has no default value. Use > 9600 as that is a sane default. > > Link: https://github.com/ClangBuiltLinux/linux/issues/395 > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/tty/serial/qcom_geni_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 3bcec1c20219..35e5f9c5d5be 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -1050,7 +1050,7 @@ static int __init qcom_geni_console_setup(struct console *co, char *options) > { > struct uart_port *uport; > struct qcom_geni_serial_port *port; > - int baud; > + int baud = 9600; > int bits = 8; > int parity = 'n'; > int flow = 'n'; I made a similar patch here, but after looking at the driver concluded that the bitrate had to be 115200, since that is used as the default value otherwise. Arnd
On Fri, Mar 22, 2019 at 7:20 AM Arnd Bergmann <arnd@arndb.de> wrote: > > On Fri, Mar 8, 2019 at 7:38 PM Nathan Chancellor > <natechancellor@gmail.com> wrote: > > > > When building with -Wsometimes-uninitialized, Clang warns: > > > > drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' > > is used uninitialized whenever 'if' condition is false > > [-Wsometimes-uninitialized] > > > > It's not wrong; when options is NULL, baud has no default value. Use > > 9600 as that is a sane default. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/395 > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > --- > > drivers/tty/serial/qcom_geni_serial.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > > index 3bcec1c20219..35e5f9c5d5be 100644 > > --- a/drivers/tty/serial/qcom_geni_serial.c > > +++ b/drivers/tty/serial/qcom_geni_serial.c > > @@ -1050,7 +1050,7 @@ static int __init qcom_geni_console_setup(struct console *co, char *options) > > { > > struct uart_port *uport; > > struct qcom_geni_serial_port *port; > > - int baud; > > + int baud = 9600; > > int bits = 8; > > int parity = 'n'; > > int flow = 'n'; > > I made a similar patch here, but after looking at the driver concluded > that the bitrate had to be 115200, since that is used as the default > value otherwise. Good point, we use this driver for Pixel, and I usually connect with a baud rate of 115200.
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 3bcec1c20219..35e5f9c5d5be 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1050,7 +1050,7 @@ static int __init qcom_geni_console_setup(struct console *co, char *options) { struct uart_port *uport; struct qcom_geni_serial_port *port; - int baud; + int baud = 9600; int bits = 8; int parity = 'n'; int flow = 'n';
When building with -Wsometimes-uninitialized, Clang warns: drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] It's not wrong; when options is NULL, baud has no default value. Use 9600 as that is a sane default. Link: https://github.com/ClangBuiltLinux/linux/issues/395 Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)