diff mbox series

[18/28] arm64: dts: allwinner: a64: Add missing PIO clocks

Message ID 20190325135300.6440-18-maxime.ripard@bootlin.com (mailing list archive)
State New, archived
Headers show
Series [01/28] dt-bindings: arm: Remove the CPU compatible documentation | expand

Commit Message

Maxime Ripard March 25, 2019, 1:52 p.m. UTC 
The pinctrl binding mandates that we have the three clocks fed into the PIO
described.

Even though the old case is still supported for backward compatibility, we
should update our DTs to fix this.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Chen-Yu Tsai March 25, 2019, 5:04 p.m. UTC | #1 
On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The pinctrl binding mandates that we have the three clocks fed into the PIO
> described.
>
> Even though the old case is still supported for backward compatibility, we
> should update our DTs to fix this.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Maybe a fixes tag?

Acked-by: Chen-Yu Tsai <wens@csie.org>
Maxime Ripard March 25, 2019, 7:58 p.m. UTC | #2 
On Tue, Mar 26, 2019 at 01:04:09AM +0800, Chen-Yu Tsai wrote:
> On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > The pinctrl binding mandates that we have the three clocks fed into the PIO
> > described.
> >
> > Even though the old case is still supported for backward compatibility, we
> > should update our DTs to fix this.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Maybe a fixes tag?
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>

I've added the fixes tag and applied, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 4b79d34da63d..4b5fd161dc60 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -583,7 +583,8 @@ 
 			interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&ccu 58>;
+			clocks = <&ccu 58>, <&osc24M>, <&rtc 0>;
+			clock-names = "apb", "hosc", "losc";
 			gpio-controller;
 			#gpio-cells = <3>;
 			interrupt-controller;