[0/4] pvrdma: Add support for SRQ

Message

Kamal Heib March 26, 2019, 5:52 a.m. UTC

This series implements the SRQ (Shared Receive Queue) for the pvrdma
device, It also includes all the needed functions and definitions for
support SRQ in the backend and resource management layers.

Kamal Heib (4):
  hw/rdma: Add SRQ support to backend layer
  hw/rdma: Add support for managing SRQ resource
  hw/rdma: Modify create/destroy QP to support SRQ
  hw/pvrdma: Add support for SRQ

 hw/rdma/rdma_backend.c      | 124 ++++++++++++++++++++-
 hw/rdma/rdma_backend.h      |  18 +++-
 hw/rdma/rdma_backend_defs.h |   5 +
 hw/rdma/rdma_rm.c           | 106 +++++++++++++++++-
 hw/rdma/rdma_rm.h           |  13 ++-
 hw/rdma/rdma_rm_defs.h      |   9 ++
 hw/rdma/vmw/pvrdma_cmd.c    | 208 ++++++++++++++++++++++++++++++++----
 hw/rdma/vmw/pvrdma_main.c   |  16 +++
 hw/rdma/vmw/pvrdma_qp_ops.c |  46 +++++++-
 hw/rdma/vmw/pvrdma_qp_ops.h |   1 +
 10 files changed, 512 insertions(+), 34 deletions(-)

Comments

[e-mail] March 26, 2019, 5:59 a.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH 0/4] pvrdma: Add support for SRQ
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
ba0f5032e5 hw/pvrdma: Add support for SRQ
75b1d8e3de hw/rdma: Modify create/destroy QP to support SRQ
f91a83fe50 hw/rdma: Add support for managing SRQ resource
5547fa2080 hw/rdma: Add SRQ support to backend layer

=== OUTPUT BEGIN ===
1/4 Checking commit 5547fa208084 (hw/rdma: Add SRQ support to backend layer)
WARNING: line over 80 characters
#32: FILE: hw/rdma/rdma_backend.c:121:
+                rdma_protected_gslist_remove_int32(&bctx->backend_qp->cqe_ctx_list,

WARNING: line over 80 characters
#35: FILE: hw/rdma/rdma_backend.c:124:
+                rdma_protected_gslist_remove_int32(&bctx->backend_srq->cqe_ctx_list,

WARNING: line over 80 characters
#80: FILE: hw/rdma/rdma_backend.c:706:
+        rdma_error_report("ibv_post_srq_recv failed, srqn=0x%x, rc=%d, errno=%d",

total: 0 errors, 3 warnings, 176 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit f91a83fe50a8 (hw/rdma: Add support for managing SRQ resource)
3/4 Checking commit 75b1d8e3de21 (hw/rdma: Modify create/destroy QP to support SRQ)
ERROR: suspect code indent for conditional statements (4, 9)
#95: FILE: hw/rdma/rdma_rm.c:435:
+    if (is_srq) {
+         qp->is_srq = is_srq;

total: 1 errors, 0 warnings, 218 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit ba0f5032e56f (hw/pvrdma: Add support for SRQ)
ERROR: code indent should never use tabs
#204: FILE: hw/rdma/vmw/pvrdma_main.c:493:
+^Iif (val & PVRDMA_UAR_SRQ_RECV) {$

ERROR: code indent should never use tabs
#207: FILE: hw/rdma/vmw/pvrdma_main.c:496:
+^I    pvrdma_srq_recv(dev, val & PVRDMA_UAR_HANDLE_MASK);$

ERROR: code indent should never use tabs
#208: FILE: hw/rdma/vmw/pvrdma_main.c:497:
+^I}$

ERROR: code indent should never use tabs
#209: FILE: hw/rdma/vmw/pvrdma_main.c:498:
+^Ibreak;$

ERROR: code indent should never use tabs
#276: FILE: hw/rdma/vmw/pvrdma_qp_ops.c:278:
+^I^I^I^I   wqe->hdr.num_sge,$

total: 5 errors, 0 warnings, 264 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]