| Message ID | 20190304125033.28841-3-josef@lusticky.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add DRM panel driver for Ilitek ILI9341 based panels in parallel RGB mode | expand |
On Mon, Mar 04, 2019 at 01:50:33PM +0100, Josef Lusticky wrote: > --- You need a commit message and a Signed-off-by. Run checkpatch.pl, it will tell you these things. > .../bindings/display/panel/ilitek,ili9341.txt | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt > new file mode 100644 > index 000000000000..4e0e483bc12e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt I don't like the same h/w being documented in 2 places as we already have bindings/display/ilitek,ili9341.txt. Expand that to cover both modes. > @@ -0,0 +1,33 @@ > +Ilitek ILI9341 TFT panel driver with SPI control bus > + > +This is a driver for 240x320 TFT panels with parallel RGB color input. > + > +Required properties: > + - compatible: "displaytech,dt024ctft", "ilitek,ili9341" > + - backlight: phandle of the backlight device attached to the panel > + > +Optional properties: > + - dc-gpios: a GPIO spec for the Data/Command pin, see gpio/gpio.txt How is this optional? Looks pretty important from reading the driver. > + - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt > + > +The panel must obey the rules for a SPI slave device as specified in > +spi/spi-bus.txt > + > +The device node can contain one 'port' child node with one child > +'endpoint' node, according to the bindings defined in > +media/video-interfaces.txt. This node should describe panel's video bus. > + > +Example: > + > +panel@0 { > + compatible = "displaytech,dt024ctft", "ilitek,ili9341"; > + reg = <0>; > + backlight = <&backlight>; > + dc-gpios = <&pio 4 9 GPIO_ACTIVE_HIGH>; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&display_out>; > + }; > + }; > +}; > -- > 2.20.1 >
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt new file mode 100644 index 000000000000..4e0e483bc12e --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt @@ -0,0 +1,33 @@ +Ilitek ILI9341 TFT panel driver with SPI control bus + +This is a driver for 240x320 TFT panels with parallel RGB color input. + +Required properties: + - compatible: "displaytech,dt024ctft", "ilitek,ili9341" + - backlight: phandle of the backlight device attached to the panel + +Optional properties: + - dc-gpios: a GPIO spec for the Data/Command pin, see gpio/gpio.txt + - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt + +The panel must obey the rules for a SPI slave device as specified in +spi/spi-bus.txt + +The device node can contain one 'port' child node with one child +'endpoint' node, according to the bindings defined in +media/video-interfaces.txt. This node should describe panel's video bus. + +Example: + +panel@0 { + compatible = "displaytech,dt024ctft", "ilitek,ili9341"; + reg = <0>; + backlight = <&backlight>; + dc-gpios = <&pio 4 9 GPIO_ACTIVE_HIGH>; + + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; +};