[V9,1/4] dt-bindings: watchdog: add i.MX system controller watchdog

Commit Message

Anson Huang March 21, 2019, 2:26 a.m. UTC

Add i.MX system controller watchdog binding doc.

Signed-off-by: Anson Huang <[e-mail]>
---
Changes since V8:
	- add optional property "timeout-sec" according to driver change.
---
 .../bindings/watchdog/fsl-imx-sc-wdt.txt           | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/fsl-imx-sc-wdt.txt

Comments

Rob Herring (Arm) March 25, 2019, 8:37 p.m. UTC | #1

On Thu, Mar 21, 2019 at 02:26:38AM +0000, Anson Huang wrote:
> Add i.MX system controller watchdog binding doc.
> 
> Signed-off-by: Anson Huang <[e-mail]>
> ---
> Changes since V8:
> 	- add optional property "timeout-sec" according to driver change.
> ---
>  .../bindings/watchdog/fsl-imx-sc-wdt.txt           | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/fsl-imx-sc-wdt.txt

I still think what's in ATF should be discoverable, but:

Acked-by: Rob Herring <[e-mail]>

Anson Huang March 29, 2019, 7:44 a.m. UTC | #2

Hi, Guenter/Shawn
	Since DT has been acked, would you pick up this patch series if no additional comments?

Best Regards!
Anson Huang

> -----Original Message-----
> From: Rob Herring [mailto:[e-mail]]
> Sent: 2019年3月26日 4:37
> To: Anson Huang <[e-mail]>
> Cc: [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail];
> Aisheng Dong <[e-mail]>; Daniel Baluta
> <[e-mail]>; [e-mail]; [e-mail];
> [e-mail]; Andy Gross <[e-mail]>;
> [e-mail]; [e-mail];
> [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail]; linux-
> [e-mail]; [e-mail]; linux-arm-
> [e-mail]; [e-mail]; dl-linux-imx
> <[e-mail]>
> Subject: Re: [PATCH V9 1/4] dt-bindings: watchdog: add i.MX system
> controller watchdog
> 
> On Thu, Mar 21, 2019 at 02:26:38AM +0000, Anson Huang wrote:
> > Add i.MX system controller watchdog binding doc.
> >
> > Signed-off-by: Anson Huang <[e-mail]>
> > ---
> > Changes since V8:
> > 	- add optional property "timeout-sec" according to driver change.
> > ---
> >  .../bindings/watchdog/fsl-imx-sc-wdt.txt           | 24
> ++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/watchdog/fsl-
> imx-sc-wdt.txt
> 
> I still think what's in ATF should be discoverable, but:
> 
> Acked-by: Rob Herring <[e-mail]>

Guenter Roeck March 29, 2019, 4:49 p.m. UTC | #3

On Fri, Mar 29, 2019 at 07:44:21AM +0000, Anson Huang wrote:
> Hi, Guenter/Shawn
> 	Since DT has been acked, would you pick up this patch series if no additional comments?
> 

I added patch 1 and 2 of the series to my watchdog-next tree.
Wim usually picks it up from there.

Guenter

> Best Regards!
> Anson Huang
> 
> > -----Original Message-----
> > From: Rob Herring [mailto:[e-mail]]
> > Sent: 2019年3月26日 4:37
> > To: Anson Huang <[e-mail]>
> > Cc: [e-mail]; [e-mail]; [e-mail];
> > [e-mail]; [e-mail]; [e-mail];
> > [e-mail]; [e-mail]; [e-mail];
> > Aisheng Dong <[e-mail]>; Daniel Baluta
> > <[e-mail]>; [e-mail]; [e-mail];
> > [e-mail]; Andy Gross <[e-mail]>;
> > [e-mail]; [e-mail];
> > [e-mail]; [e-mail];
> > [e-mail]; [e-mail]; [e-mail]; linux-
> > [e-mail]; [e-mail]; linux-arm-
> > [e-mail]; [e-mail]; dl-linux-imx
> > <[e-mail]>
> > Subject: Re: [PATCH V9 1/4] dt-bindings: watchdog: add i.MX system
> > controller watchdog
> > 
> > On Thu, Mar 21, 2019 at 02:26:38AM +0000, Anson Huang wrote:
> > > Add i.MX system controller watchdog binding doc.
> > >
> > > Signed-off-by: Anson Huang <[e-mail]>
> > > ---
> > > Changes since V8:
> > > 	- add optional property "timeout-sec" according to driver change.
> > > ---
> > >  .../bindings/watchdog/fsl-imx-sc-wdt.txt           | 24
> > ++++++++++++++++++++++
> > >  1 file changed, 24 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/watchdog/fsl-
> > imx-sc-wdt.txt
> > 
> > I still think what's in ATF should be discoverable, but:
> > 
> > Acked-by: Rob Herring <[e-mail]>

Shawn Guo April 3, 2019, 8:53 a.m. UTC | #4

On Fri, Mar 29, 2019 at 07:44:21AM +0000, Anson Huang wrote:
> Hi, Guenter/Shawn
> 	Since DT has been acked, would you pick up this patch series if no additional comments?
> 

Applied patch #3 and #4, thanks.

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-sc-wdt.txt b/Documentation/devicetree/bindings/watchdog/fsl-imx-sc-wdt.txt
new file mode 100644
index 0000000..02b87e9
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-sc-wdt.txt
@@ -0,0 +1,24 @@ 
+* Freescale i.MX System Controller Watchdog
+
+i.MX system controller watchdog is for i.MX SoCs with system controller inside,
+the watchdog is managed by system controller, users can ONLY communicate with
+system controller from secure mode for watchdog operations, so Linux i.MX system
+controller watchdog driver will call ARM SMC API and trap into ARM-Trusted-Firmware
+for watchdog operations, ARM-Trusted-Firmware is running at secure EL3 mode and
+it will request system controller to execute the watchdog operation passed from
+Linux kernel.
+
+Required properties:
+- compatible:	Should be :
+		"fsl,imx8qxp-sc-wdt"
+		followed by "fsl,imx-sc-wdt";
+
+Optional properties:
+- timeout-sec : Contains the watchdog timeout in seconds.
+
+Examples:
+
+watchdog {
+	compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
+	timeout-sec = <60>;
+};