| Message ID | 20190401150345.GJ28264@zn.tnic (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
| Series | cpufreq/intel_pstate: Load only on Intel hardware | expand |
Le 01/04/2019 à 17:03, Borislav Petkov a écrit : > From: Borislav Petkov <bp@suse.de> > > This driver is Intel-only so loading on anything which is not Intel is > pointless. Prevent it from doing so. > > While at it, correct the "not supported" print statement to say CPU > "model" which is what that test does. > Looks good to me ! Thanks ! Erwan,
On Monday, April 1, 2019 5:03:45 PM CEST Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > This driver is Intel-only so loading on anything which is not Intel is > pointless. Prevent it from doing so. Nice. I wondered whether there are more of these to find by review, instead of waiting for the next message to show up. I ended up in the "not so straight forward" IOMMU init macros... and continued with daily work again. Anyway there are a lot files showing up when grepping the kernel for intel files/drivers, maybe someone who is involved in the one or other comes up with something similar... Thomas FWIW: Reviewed-by: Thomas Renninger <trenn@suse.de> > While at it, correct the "not supported" print statement to say CPU > "model" which is what that test does. > > Suggested-by: Erwan Velu <e.velu@criteo.com> > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Len Brown <lenb@kernel.org> > Cc: linux-pm@vger.kernel.org > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > CC: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/intel_pstate.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index b599c7318aab..2986119dd31f 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -2596,6 +2596,9 @@ static int __init intel_pstate_init(void) > const struct x86_cpu_id *id; > int rc; > > + if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) > + return -ENODEV; > + ...
On Monday, April 1, 2019 5:03:45 PM CEST Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > This driver is Intel-only so loading on anything which is not Intel is > pointless. Prevent it from doing so. > > While at it, correct the "not supported" print statement to say CPU > "model" which is what that test does. > > Suggested-by: Erwan Velu <e.velu@criteo.com> > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Len Brown <lenb@kernel.org> > Cc: linux-pm@vger.kernel.org > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > CC: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/intel_pstate.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index b599c7318aab..2986119dd31f 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -2596,6 +2596,9 @@ static int __init intel_pstate_init(void) > const struct x86_cpu_id *id; > int rc; > > + if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) > + return -ENODEV; > + > if (no_load) > return -ENODEV; > > @@ -2611,7 +2614,7 @@ static int __init intel_pstate_init(void) > } else { > id = x86_match_cpu(intel_pstate_cpu_ids); > if (!id) { > - pr_info("CPU ID not supported\n"); > + pr_info("CPU model not supported\n"); > return -ENODEV; > } > > Applied, thanks!
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index b599c7318aab..2986119dd31f 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -2596,6 +2596,9 @@ static int __init intel_pstate_init(void) const struct x86_cpu_id *id; int rc; + if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) + return -ENODEV; + if (no_load) return -ENODEV; @@ -2611,7 +2614,7 @@ static int __init intel_pstate_init(void) } else { id = x86_match_cpu(intel_pstate_cpu_ids); if (!id) { - pr_info("CPU ID not supported\n"); + pr_info("CPU model not supported\n"); return -ENODEV; }