mm: __pagevec_lru_add_fn: typo fix

Commit Message

Peng Fan April 2, 2019, 9:43 a.m. UTC

There is no function named munlock_vma_pages, correct it to
munlock_vma_page.

Signed-off-by: Peng Fan <[e-mail]>
---
 mm/swap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vlastimil Babka April 3, 2019, 7:45 a.m. UTC | #1

On 4/2/19 11:43 AM, Peng Fan wrote:
> There is no function named munlock_vma_pages, correct it to
> munlock_vma_page.
> 
> Signed-off-by: Peng Fan <[e-mail]>

Acked-by: Vlastimil Babka <[e-mail]>

> ---
>  mm/swap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/swap.c b/mm/swap.c
> index 301ed4e04320..3a75722e68a9 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -867,7 +867,7 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
>  	SetPageLRU(page);
>  	/*
>  	 * Page becomes evictable in two ways:
> -	 * 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
> +	 * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
>  	 * 2) Before acquiring LRU lock to put the page to correct LRU and then
>  	 *   a) do PageLRU check with lock [check_move_unevictable_pages]
>  	 *   b) do PageLRU check before lock [clear_page_mlock]
>

Mukesh Ojha April 4, 2019, 7:30 a.m. UTC | #2

On 4/2/2019 3:13 PM, Peng Fan wrote:
> There is no function named munlock_vma_pages, correct it to
> munlock_vma_page.
>
> Signed-off-by: Peng Fan <[e-mail]>
Reviewed-by: Mukesh Ojha <[e-mail]>

Cheers,
-Mukesh
> ---
>   mm/swap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/swap.c b/mm/swap.c
> index 301ed4e04320..3a75722e68a9 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -867,7 +867,7 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
>   	SetPageLRU(page);
>   	/*
>   	 * Page becomes evictable in two ways:
> -	 * 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
> +	 * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
>   	 * 2) Before acquiring LRU lock to put the page to correct LRU and then
>   	 *   a) do PageLRU check with lock [check_move_unevictable_pages]
>   	 *   b) do PageLRU check before lock [clear_page_mlock]

Patch

diff --git a/mm/swap.c b/mm/swap.c
index 301ed4e04320..3a75722e68a9 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -867,7 +867,7 @@  static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
 	SetPageLRU(page);
 	/*
 	 * Page becomes evictable in two ways:
-	 * 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
+	 * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
 	 * 2) Before acquiring LRU lock to put the page to correct LRU and then
 	 *   a) do PageLRU check with lock [check_move_unevictable_pages]
 	 *   b) do PageLRU check before lock [clear_page_mlock]