| Message ID | 1552354316-20204-1-git-send-email-dongli.zhang@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] virtio_blk: replace 0 by HCTX_TYPE_DEFAULT to index blk_mq_tag_set->map | expand |
ping? The similar patchset has been queued by linux-scsi 5.2/scsi-queue. virtio-blk is the last place where HCTX_TYPE_DEFAULT is hardcoded. It would be more friendly to cscope if the hardcoding is avoided. Thank you very much! Dongli Zhang On 03/12/2019 09:31 AM, Dongli Zhang wrote: > Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding. > > Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> > --- > This is the only place to cleanup under drivers/block/*. Another patch set > is sent to scsi and then all of below are cleaned up: > - block/* > - drivers/* > > drivers/block/virtio_blk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 4bc083b..bed6035 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -691,7 +691,8 @@ static int virtblk_map_queues(struct blk_mq_tag_set *set) > { > struct virtio_blk *vblk = set->driver_data; > > - return blk_mq_virtio_map_queues(&set->map[0], vblk->vdev, 0); > + return blk_mq_virtio_map_queues(&set->map[HCTX_TYPE_DEFAULT], > + vblk->vdev, 0); > } > > #ifdef CONFIG_VIRTIO_BLK_SCSI >
On 3/11/19 7:31 PM, Dongli Zhang wrote:
> Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding.
Applied, thanks.
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 4bc083b..bed6035 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -691,7 +691,8 @@ static int virtblk_map_queues(struct blk_mq_tag_set *set) { struct virtio_blk *vblk = set->driver_data; - return blk_mq_virtio_map_queues(&set->map[0], vblk->vdev, 0); + return blk_mq_virtio_map_queues(&set->map[HCTX_TYPE_DEFAULT], + vblk->vdev, 0); } #ifdef CONFIG_VIRTIO_BLK_SCSI
Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding. Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> --- This is the only place to cleanup under drivers/block/*. Another patch set is sent to scsi and then all of below are cleaned up: - block/* - drivers/* drivers/block/virtio_blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)