| Message ID | 20190409164542.30274-2-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | libxl: New slow lock + fix libxl_cdrom_insert with QEMU depriv | expand |
On Tue, Apr 09, 2019 at 05:45:34PM +0100, Anthony PERARD wrote: > That comment as been separated from the function it defines by > 4197d3abbb3055d3798254eb7ba239bfb5824360, but then was not useful > anymore when the libxl__device_disk_add() prototype was removed by > 22ea8ad02e465e32cd40887c750b55c3a997a288. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com>
Anthony PERARD writes ("[PATCH 1/9] libxl_internal: Remove lost comment"):
> That comment as been separated from the function it defines by
> 4197d3abbb3055d3798254eb7ba239bfb5824360, but then was not useful
> anymore when the libxl__device_disk_add() prototype was removed by
> 22ea8ad02e465e32cd40887c750b55c3a997a288.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 44e0221284..98a1ee6159 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -2744,13 +2744,6 @@ struct libxl__multidev { * DONE. */ -/* AO operation to connect a disk device, called by - * libxl_device_disk_add and libxl__add_disks. This function calls - * libxl__wait_device_connection to wait for the device to - * finish the connection (might involve executing hotplug scripts). - * - * Once finished, aodev->callback will be executed. - */ /* * As of Xen 4.5 we maintain various information, including hotplug * device information, in JSON files, so that we can use this JSON
That comment as been separated from the function it defines by 4197d3abbb3055d3798254eb7ba239bfb5824360, but then was not useful anymore when the libxl__device_disk_add() prototype was removed by 22ea8ad02e465e32cd40887c750b55c3a997a288. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libxl/libxl_internal.h | 7 ------- 1 file changed, 7 deletions(-)