| Message ID | 46e9b55edb223894392a90c7cdb6241a43cb9cff.1554864022.git.shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2] ASoC: fsl_esai: replace fall-through with break | expand |
On Wed, Apr 10, 2019 at 02:42:45AM +0000, S.j. Wang wrote: > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of > each other, so replace fall-through with break. > > Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> Thanks > --- > Changes in v2 > - fix the fixes tag. > > sound/soc/fsl/fsl_esai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c > index c7410bbfd2af..bad0dfed6b68 100644 > --- a/sound/soc/fsl/fsl_esai.c > +++ b/sound/soc/fsl/fsl_esai.c > @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, > break; > case ESAI_HCKT_EXTAL: > ecr |= ESAI_ECR_ETI; > - /* fall through */ > + break; > case ESAI_HCKR_EXTAL: > ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI; > break; > -- > 1.9.1 >
On Wed, Apr 10, 2019 at 02:42:45AM +0000, S.j. Wang wrote: > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of > each other, so replace fall-through with break. This doesn't apply against current code, please check and resend.
On 4/9/19 9:42 PM, S.j. Wang wrote: > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of > each other, so replace fall-through with break. > I think you should change the subject line to: fix missing break in switch statement ...because you are fixing a bug, and it's important to put emphasis on that in the subject line. Also, notice that this bug has been out there for more than 5 years now, so you should also tag this for stable. Thanks -- Gustavo > Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- > Changes in v2 > - fix the fixes tag. > > sound/soc/fsl/fsl_esai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c > index c7410bbfd2af..bad0dfed6b68 100644 > --- a/sound/soc/fsl/fsl_esai.c > +++ b/sound/soc/fsl/fsl_esai.c > @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, > break; > case ESAI_HCKT_EXTAL: > ecr |= ESAI_ECR_ETI; > - /* fall through */ > + break; > case ESAI_HCKR_EXTAL: > ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI; > break; >
Hi > > > On 4/9/19 9:42 PM, S.j. Wang wrote: > > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent > of > > each other, so replace fall-through with break. > > > I think you should change the subject line to: > > fix missing break in switch statement > > ...because you are fixing a bug, and it's important to put emphasis on that in > the subject line. > > Also, notice that this bug has been out there for more than 5 years now, so > you should also tag this for stable. > > Thanks > -- > Gustavo > Ok, will send v3. > > > Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > --- > > Changes in v2 > > - fix the fixes tag. > > > > sound/soc/fsl/fsl_esai.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index > > c7410bbfd2af..bad0dfed6b68 100644 > > --- a/sound/soc/fsl/fsl_esai.c > > +++ b/sound/soc/fsl/fsl_esai.c > > @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai > *dai, int clk_id, > > break; > > case ESAI_HCKT_EXTAL: > > ecr |= ESAI_ECR_ETI; > > - /* fall through */ > > + break; > > case ESAI_HCKR_EXTAL: > > ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI; > > break; > >
Hi Mark > > On Wed, Apr 10, 2019 at 02:42:45AM +0000, S.j. Wang wrote: > > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent > of > > each other, so replace fall-through with break. > > This doesn't apply against current code, please check and resend. Thanks, have sent v4 for update subject according to Gustavo's comments. [PATCH V4] ASoC: fsl_esai: Fix missing break in switch statement Best regards Wang shengjiu
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index c7410bbfd2af..bad0dfed6b68 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, break; case ESAI_HCKT_EXTAL: ecr |= ESAI_ECR_ETI; - /* fall through */ + break; case ESAI_HCKR_EXTAL: ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI; break;
case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of each other, so replace fall-through with break. Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- Changes in v2 - fix the fixes tag. sound/soc/fsl/fsl_esai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)