diff mbox series

[v2,19/22] drm/i915/guc: Enable GuC CTB communication on Gen11

Message ID 20190411084436.24384-20-michal.wajdeczko@intel.com (mailing list archive)
State New, archived
Headers show
Series GuC 32.0.3 | expand

Commit Message

Michal Wajdeczko April 11, 2019, 8:44 a.m. UTC
Gen11 GuC firmware expects H2G command messages to be sent over CTB
(command transport buffers).

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: John Spotswood <john.a.spotswood@intel.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniele Ceraolo Spurio April 11, 2019, 11:58 p.m. UTC | #1
On 4/11/19 1:44 AM, Michal Wajdeczko wrote:
> Gen11 GuC firmware expects H2G command messages to be sent over CTB
> (command transport buffers).
> 

Even gen9 blobs can now use CTB, so we can just make the whole CTB 
handling unconditional. I'm ok with doing that as a follow up as this 
series already changes enough things as is.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: John Spotswood <john.a.spotswood@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_pci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index f893c2cbce15..8af8820b3df8 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -743,6 +743,7 @@ static const struct intel_device_info intel_cannonlake_info = {
>   	}, \
>   	GEN(11), \
>   	.ddb_size = 2048, \
> +	.has_guc_ct = 1, \
>   	.has_logical_ring_elsq = 1, \
>   	.color = { .degamma_lut_size = 33, .gamma_lut_size = 1024 }
>   
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index f893c2cbce15..8af8820b3df8 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -743,6 +743,7 @@  static const struct intel_device_info intel_cannonlake_info = {
 	}, \
 	GEN(11), \
 	.ddb_size = 2048, \
+	.has_guc_ct = 1, \
 	.has_logical_ring_elsq = 1, \
 	.color = { .degamma_lut_size = 33, .gamma_lut_size = 1024 }