| Message ID | 20190411105720.32357-5-peron.clem@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Allwinner H6 Mali Midgard GPU | expand |
Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a): > Add the mali gpu node to the H6 device-tree. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index > e0dc4a05c1ba..196753110434 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -157,6 +157,20 @@ > allwinner,sram = <&ve_sram 1>; > }; > > + gpu: gpu@1800000 { > + compatible = "allwinner,sun50i-h6-mali", > + "arm,mali-t720"; > + reg = <0x01800000 0x4000>; > + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "job", "mmu", "gpu"; > + clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>; > + clock-names = "core", "bus"; > + resets = <&ccu RST_BUS_GPU>; > + status = "disabled"; Usually self sufficient peripherals are enabled by default in DTSI. > + }; > + > syscon: syscon@3000000 { > compatible = "allwinner,sun50i-h6-system- control", > "allwinner,sun50i-a64- system-control";
Hi, On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <jernej.skrabec@siol.net> wrote: > > Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a): > > Add the mali gpu node to the H6 device-tree. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index > > e0dc4a05c1ba..196753110434 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -157,6 +157,20 @@ > > allwinner,sram = <&ve_sram 1>; > > }; > > > > + gpu: gpu@1800000 { > > + compatible = "allwinner,sun50i-h6-mali", > > + "arm,mali-t720"; > > + reg = <0x01800000 0x4000>; > > + interrupts = <GIC_SPI 84 > IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 85 > IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 83 > IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "job", "mmu", "gpu"; > > + clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>; > > + clock-names = "core", "bus"; > > + resets = <&ccu RST_BUS_GPU>; > > + status = "disabled"; > > Usually self sufficient peripherals are enabled by default in DTSI. I follow the other Mali Midgard (rk3399, rk3288) syntax. But I think you're right here, will go for an update I think. Clement > > > + }; > > + > > syscon: syscon@3000000 { > > compatible = "allwinner,sun50i-h6-system- > control", > > "allwinner,sun50i-a64- > system-control"; > > > >
Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a): > Hi, > > On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <jernej.skrabec@siol.net> wrote: > > Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a): > > > Add the mali gpu node to the H6 device-tree. > > > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > > --- > > > > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index > > > e0dc4a05c1ba..196753110434 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > @@ -157,6 +157,20 @@ > > > > > > allwinner,sram = <&ve_sram 1>; > > > > > > }; > > > > > > + gpu: gpu@1800000 { > > > + compatible = "allwinner,sun50i-h6-mali", > > > + "arm,mali-t720"; > > > + reg = <0x01800000 0x4000>; > > > + interrupts = <GIC_SPI 84 > > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > + <GIC_SPI 85 > > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > + <GIC_SPI 83 > > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > + interrupt-names = "job", "mmu", "gpu"; > > > + clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>; > > > + clock-names = "core", "bus"; > > > + resets = <&ccu RST_BUS_GPU>; > > > + status = "disabled"; > > > > Usually self sufficient peripherals are enabled by default in DTSI. > > I follow the other Mali Midgard (rk3399, rk3288) syntax. > But I think you're right here, will go for an update I think. > I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status property is not set). Best regards, Jernej > Clement > > > > + }; > > > + > > > > > > syscon: syscon@3000000 { > > > > > > compatible = "allwinner,sun50i-h6-system- > > > > control", > > > > > "allwinner,sun50i-a64- > > > > system-control";
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi @@ -157,6 +157,20 @@ allwinner,sram = <&ve_sram 1>; }; + gpu: gpu@1800000 { + compatible = "allwinner,sun50i-h6-mali", + "arm,mali-t720"; + reg = <0x01800000 0x4000>; + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "job", "mmu", "gpu"; + clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>; + clock-names = "core", "bus"; + resets = <&ccu RST_BUS_GPU>; + status = "disabled"; + }; + syscon: syscon@3000000 { compatible = "allwinner,sun50i-h6-system-control", "allwinner,sun50i-a64-system-control";
Add the mali gpu node to the H6 device-tree. Signed-off-by: Clément Péron <peron.clem@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)