| Message ID | 1555313834-15107-4-git-send-email-masonccyang@mxic.com.tw (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | mfd: Add Renesas R-Car Gen3 RPC-IF MFD & SPI driver | expand |
On 04/15/2019 10:37 AM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD controller. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > --- > .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > > diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > new file mode 100644 > index 0000000..bfb3d29 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > @@ -0,0 +1,37 @@ > +Renesas R-Car Gen3 RPC-IF MFD controller Device Tree Bindings > +------------------------------------------------------------- > + > +Required properties: > +- compatible: should be an SoC-specific compatible value, followed by > + "renesas,rcar-gen3-rpc" as a fallback. > + supported SoC-specific values are: > + "renesas,r8a77995-rpc" (R-Car D3) > +- reg: should contain 2 entries, one for the base address of rpc-if registers, > + and one for the direct mapping area > +- reg-names: should contain "regs", and "dirmap" The device tree describes the hardware, not the driver. Why did you remove the "wbuf" area? [...] MBR, Sergei
On 16.04.2019 4:06, masonccyang@mxic.com.tw wrote: > > > Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD controller. > > > > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > > > --- > > > .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 37 +++++++++ > > +++++++++++++ > > > 1 file changed, 37 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mfd/mfd- > > renesas-rpc.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas- > > rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > > > new file mode 100644 > > > index 0000000..bfb3d29 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > > > @@ -0,0 +1,37 @@ > > > +Renesas R-Car Gen3 RPC-IF MFD controller Device Tree Bindings > > > +------------------------------------------------------------- > > > + > > > +Required properties: > > > +- compatible: should be an SoC-specific compatible value, followed by > > > + "renesas,rcar-gen3-rpc" as a fallback. > > > + supported SoC-specific values are: > > > + "renesas,r8a77995-rpc" (R-Car D3) > > > +- reg: should contain 2 entries, one for the base address of rpc- > > if registers, > > > + and one for the direct mapping area > > > +- reg-names: should contain "regs", and "dirmap" > > > > The device tree describes the hardware, not the driver. Why did you remove > > the "wbuf" area? > > I don't think we should describe the hardware that driver did not implement it > because there are still many RPC registers we don't use them. I have to repeat: we describe the hardware, not the driver capabilities. > best regards, > Mason MBR, Sergei
Hello! On 04/18/2019 08:55 AM, masonccyang@mxic.com.tw wrote: >> > > > Document the bindings used by the Renesas R-Car Gen3 RPC-IF >> MFD controller. >> > > > >> > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> >> > > > --- >> > > > .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 37 +++++++++ >> > > +++++++++++++ >> > > > 1 file changed, 37 insertions(+) >> > > > create mode 100644 Documentation/devicetree/bindings/mfd/mfd- >> > > renesas-rpc.txt >> > > > >> > > > diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas- >> > > rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >> > > > new file mode 100644 >> > > > index 0000000..bfb3d29 >> > > > --- /dev/null >> > > > +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >> > > > @@ -0,0 +1,37 @@ >> > > > +Renesas R-Car Gen3 RPC-IF MFD controller Device Tree Bindings >> > > > +------------------------------------------------------------- >> > > > + >> > > > +Required properties: >> > > > +- compatible: should be an SoC-specific compatible value, followed by >> > > > + "renesas,rcar-gen3-rpc" as a fallback. >> > > > + supported SoC-specific values are: >> > > > + "renesas,r8a77995-rpc" (R-Car D3) >> > > > +- reg: should contain 2 entries, one for the base address of rpc- >> > > if registers, >> > > > + and one for the direct mapping area >> > > > +- reg-names: should contain "regs", and "dirmap" >> > > >> > > The device tree describes the hardware, not the driver. Why >> did you remove >> > > the "wbuf" area? >> > >> > I don't think we should describe the hardware that driver did not >> implement it >> > because there are still many RPC registers we don't use them. >> >> I have to repeat: we describe the hardware, not the driver capabilities. > > how about: > > - reg: should contain three register areas: > first for the base address of rpc-if registers, > second for the direct mapping read mode and > third for an optional write buffer area. > - reg-names: should contain "regs", "dirmap" and "wbuf"(optional). > > is it OK ? No, the write buffer area is always there, at least on the gen3 chips. (I forgot which other Renesas SoC has RPC-IF as well). > thanks & best regards, > Mason MBR, Sergei
On 04/18/2019 07:55 PM, Sergei Shtylyov wrote: >>>> > > Document the bindings used by the Renesas R-Car Gen3 RPC-IF >>> MFD controller. >>>> > > >>>> > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> >>>> > > --- >>>> > > .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 37 +++++++++ >>>> > +++++++++++++ >>>> > > 1 file changed, 37 insertions(+) >>>> > > create mode 100644 Documentation/devicetree/bindings/mfd/mfd- >>>> > renesas-rpc.txt >>>> > > >>>> > > diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas- >>>> > rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >>>> > > new file mode 100644 >>>> > > index 0000000..bfb3d29 >>>> > > --- /dev/null >>>> > > +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >>>> > > @@ -0,0 +1,37 @@ >>>> > > +Renesas R-Car Gen3 RPC-IF MFD controller Device Tree Bindings >>>> > > +------------------------------------------------------------- >>>> > > + >>>> > > +Required properties: >>>> > > +- compatible: should be an SoC-specific compatible value, followed by >>>> > > + "renesas,rcar-gen3-rpc" as a fallback. >>>> > > + supported SoC-specific values are: >>>> > > + "renesas,r8a77995-rpc" (R-Car D3) >>>> > > +- reg: should contain 2 entries, one for the base address of rpc- >>>> > if registers, >>>> > > + and one for the direct mapping area >>>> > > +- reg-names: should contain "regs", and "dirmap" >>>> > >>>> > The device tree describes the hardware, not the driver. Why >>> did you remove >>>> > the "wbuf" area? >>>> >>>> I don't think we should describe the hardware that driver did not >>> implement it >>>> because there are still many RPC registers we don't use them. >>> >>> I have to repeat: we describe the hardware, not the driver capabilities. >> >> how about: >> >> - reg: should contain three register areas: >> first for the base address of rpc-if registers, >> second for the direct mapping read mode and >> third for an optional write buffer area. >> - reg-names: should contain "regs", "dirmap" and "wbuf"(optional). >> >> is it OK ? > > No, the write buffer area is always there, at least on the gen3 chips. > (I forgot which other Renesas SoC has RPC-IF as well). So it was RZ/A1. But it didn't have the HyperFlash mode... >> thanks & best regards, >> Mason MBR, Sergei
diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt new file mode 100644 index 0000000..bfb3d29 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt @@ -0,0 +1,37 @@ +Renesas R-Car Gen3 RPC-IF MFD controller Device Tree Bindings +------------------------------------------------------------- + +Required properties: +- compatible: should be an SoC-specific compatible value, followed by + "renesas,rcar-gen3-rpc" as a fallback. + supported SoC-specific values are: + "renesas,r8a77995-rpc" (R-Car D3) +- reg: should contain 2 entries, one for the base address of rpc-if registers, + and one for the direct mapping area +- reg-names: should contain "regs", and "dirmap" +- clocks: should contain 1 entries for the module's clock +- clock-names: should contain "rpc" +- #address-cells: should be 1 +- #size-cells: should be 0 + +Example: + + rpc: rpc-if@ee200000 { + compatible = "renesas,r8a77995-rpc", "renesas,rcar-gen3-rpc"; + reg = <0 0xee200000 0 0x200>, <0 0x08000000 0 0x4000000>; + reg-names = "regs", "dirmap"; + clocks = <&cpg CPG_MOD 917>; + clock-names = "rpc"; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 917>; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <40000000>; + spi-tx-bus-width = <1>; + spi-rx-bus-width = <1>; + }; + };
Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD controller. Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> --- .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt