| Message ID | 20190420122333.23662-1-luca@z3ntu.xyz (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] dt-bindings: input: add GPIO controllable vibrator | expand |
On Sat, Apr 20, 2019 at 7:24 AM Luca Weiss <luca@z3ntu.xyz> wrote: > > Provide a simple driver for GPIO controllable vibrators. > It will be used by the Fairphone 2. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > Changes from v3: > - Convert .txt based doc to the new yaml based format > > .../bindings/input/gpio-vibrator.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/gpio-vibrator.yaml > > diff --git a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > new file mode 100644 > index 000000000000..bca1b6ea07a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bindings/input/gpio-vibrator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIO vibrator > + > +maintainers: > + - Luca Weiss <luca@z3ntu.xyz> > + > +description: |+ > + Registers a GPIO device as vibrator, where the on/off capability is controlled by a GPIO. > + > +properties: > + compatible: > + items: > + - const: gpio-vibrator These 2 lines can be simplified to just 'const: gpio-vibrator'. > + > + enable-gpios: > + maxItems: 1 > + > + vcc-supply: > + $ref: /schemas/types.yaml#/definitions/phandle This isn't necessary as we can do this for every occurrence of '*-supply'. I'll add that to the core schema. With those 2 changes: Reviewed-by: Rob Herring <robh@kernel.org> > + description: Regulator that provides power > + > +required: > + - compatible > + - enable-gpios > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + vibrator { > + compatible = "gpio-vibrator"; > + enable-gpios = <&msmgpio 86 GPIO_ACTIVE_HIGH>; > + vcc-supply = <&pm8941_l18>; > + }; > -- > 2.21.0 >
diff --git a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml new file mode 100644 index 000000000000..bca1b6ea07a4 --- /dev/null +++ b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bindings/input/gpio-vibrator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO vibrator + +maintainers: + - Luca Weiss <luca@z3ntu.xyz> + +description: |+ + Registers a GPIO device as vibrator, where the on/off capability is controlled by a GPIO. + +properties: + compatible: + items: + - const: gpio-vibrator + + enable-gpios: + maxItems: 1 + + vcc-supply: + $ref: /schemas/types.yaml#/definitions/phandle + description: Regulator that provides power + +required: + - compatible + - enable-gpios + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + vibrator { + compatible = "gpio-vibrator"; + enable-gpios = <&msmgpio 86 GPIO_ACTIVE_HIGH>; + vcc-supply = <&pm8941_l18>; + };
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Changes from v3: - Convert .txt based doc to the new yaml based format .../bindings/input/gpio-vibrator.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/gpio-vibrator.yaml