| Message ID | 324016691a62a13ce46c9ccd35c7e492bf609fd6.1555967348.git.joseph.salisbury@microsoft.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 64caea53e07f0a3bc4af74f4123b258c1ceb4d67 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | drivers: hid: Add a module description line | expand |
From: Joseph Salisbury <Joseph.Salisbury@microsoft.com> Sent: Monday, April 22, 2019 2:31 PM > > Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com> > --- > drivers/hid/hid-hyperv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c > index 704049e62d58..d3311d714d35 100644 > --- a/drivers/hid/hid-hyperv.c > +++ b/drivers/hid/hid-hyperv.c > @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void) > } > > MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver"); > + > module_init(mousevsc_init); > module_exit(mousevsc_exit); > -- > 2.17.1 Even though it will likely be redundant with the commit title, there probably needs to be a short commit message. (And also with the other two similar patches.) Michael
Thanks for the feedback. I'll probably update each patch subject with the module names as well. I'll send a v2 for all three. Thanks, Joe -----Original Message----- From: Michael Kelley <mikelley@microsoft.com> Sent: Monday, April 22, 2019 11:16 PM To: Joseph Salisbury <Joseph.Salisbury@microsoft.com>; KY Srinivasan <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>; sashal@kernel.org; jikos@kernel.org; benjamin.tissoires@redhat.com Cc: linux-hyperv@vger.kernel.org; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org Subject: RE: [PATCH] drivers: hid: Add a module description line From: Joseph Salisbury <Joseph.Salisbury@microsoft.com> Sent: Monday, April 22, 2019 2:31 PM > > Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com> > --- > drivers/hid/hid-hyperv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c index > 704049e62d58..d3311d714d35 100644 > --- a/drivers/hid/hid-hyperv.c > +++ b/drivers/hid/hid-hyperv.c > @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void) } > > MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver"); > + > module_init(mousevsc_init); > module_exit(mousevsc_exit); > -- > 2.17.1 Even though it will likely be redundant with the commit title, there probably needs to be a short commit message. (And also with the other two similar patches.) Michael
From: Joseph Salisbury <joseph.salisbury@microsoft.com> Sent: Monday, April 22, 2019 8:47 PM > > This patch only adds a MODULE_DESCRIPTION statement to the driver. > This change is only cosmetic, so there should be no runtime impact. > > > Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com> > --- Reviewed-by: Michael Kelley <mikelley@microsoft.com>
On Tue, Apr 23, 2019 at 04:38:05PM +0000, Michael Kelley wrote: >From: Joseph Salisbury <joseph.salisbury@microsoft.com> Sent: Monday, April 22, 2019 8:47 PM >> >> This patch only adds a MODULE_DESCRIPTION statement to the driver. >> This change is only cosmetic, so there should be no runtime impact. >> >> >> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com> >> --- > >Reviewed-by: Michael Kelley <mikelley@microsoft.com> Queued up for hyperv-next, thanks! -- Thanks, Sasha
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c index 704049e62d58..d3311d714d35 100644 --- a/drivers/hid/hid-hyperv.c +++ b/drivers/hid/hid-hyperv.c @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void) } MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver"); + module_init(mousevsc_init); module_exit(mousevsc_exit);
Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com> --- drivers/hid/hid-hyperv.c | 2 ++ 1 file changed, 2 insertions(+)