| Message ID | 1556025203-59961-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig | expand |
On Tue, Apr 23, 2019 at 3:20 PM Biju Das <biju.das@bp.renesas.com> wrote: > Remove the GENERIC_PHY config option from shmobile_defconfig, as it is > selected by PHY_RCAR_GEN3_USB2. > > PHY_RCAR_GEN3_USB2 is enabled by the commit 0cd4f4f10245d1d9616e00245 > ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig"). > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Wed, Apr 24, 2019 at 09:12:04AM +0200, Geert Uytterhoeven wrote: > On Tue, Apr 23, 2019 at 3:20 PM Biju Das <biju.das@bp.renesas.com> wrote: > > Remove the GENERIC_PHY config option from shmobile_defconfig, as it is > > selected by PHY_RCAR_GEN3_USB2. > > > > PHY_RCAR_GEN3_USB2 is enabled by the commit 0cd4f4f10245d1d9616e00245 > > ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig"). > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> This does not seem to work as expected when applied on top of renesas-devel-20190423-v5.1-rc5. Without this patch I see both CONFIG_GENERIC_PHY and CONFIG_PHY_RCAR_GEN selected. With this patch I see neither selected, I expected both. --- .config.old 2019-04-24 11:31:12.480520934 +0200 +++ .config 2019-04-24 11:31:34.732852122 +0200 @@ -4272,7 +4272,7 @@ # # PHY Subsystem # -CONFIG_GENERIC_PHY=y +# CONFIG_GENERIC_PHY is not set # CONFIG_BCM_KONA_USB2_PHY is not set # CONFIG_PHY_CADENCE_DP is not set # CONFIG_PHY_CADENCE_DPHY is not set @@ -4282,7 +4282,6 @@ # CONFIG_PHY_PXA_28NM_USB2 is not set # CONFIG_PHY_CPCAP_USB is not set # CONFIG_PHY_MAPPHONE_MDM6600 is not set -CONFIG_PHY_RCAR_GEN2=y # CONFIG_PHY_RCAR_GEN3_PCIE is not set # CONFIG_PHY_RCAR_GEN3_USB3 is not set # CONFIG_POWERCAP is not set
Hi Simon, Thanks for the feedback. I missed to add the dependency for this patch. This patch has dependency on https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01 regards, Biju > -----Original Message----- > From: Simon Horman <horms@verge.net.au> > Sent: 24 April 2019 10:33 > To: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Biju Das <biju.das@bp.renesas.com>; Magnus Damm > <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; Linux- > Renesas <linux-renesas-soc@vger.kernel.org>; Linux ARM <linux-arm- > kernel@lists.infradead.org>; Geert Uytterhoeven > <geert+renesas@glider.be>; Chris Paterson > <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro@bp.renesas.com> > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > shmobile_defconfig > > On Wed, Apr 24, 2019 at 09:12:04AM +0200, Geert Uytterhoeven wrote: > > On Tue, Apr 23, 2019 at 3:20 PM Biju Das <biju.das@bp.renesas.com> > wrote: > > > Remove the GENERIC_PHY config option from shmobile_defconfig, as it > > > is selected by PHY_RCAR_GEN3_USB2. > > > > > > PHY_RCAR_GEN3_USB2 is enabled by the commit > > > 0cd4f4f10245d1d9616e00245 > > > ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in > shmobile_defconfig"). > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > This does not seem to work as expected when applied on top of renesas- > devel-20190423-v5.1-rc5. > > Without this patch I see both CONFIG_GENERIC_PHY and > CONFIG_PHY_RCAR_GEN selected. With this patch I see neither selected, I > expected both. > > --- .config.old 2019-04-24 11:31:12.480520934 +0200 > +++ .config 2019-04-24 11:31:34.732852122 +0200 > @@ -4272,7 +4272,7 @@ > # > # PHY Subsystem > # > -CONFIG_GENERIC_PHY=y > +# CONFIG_GENERIC_PHY is not set > # CONFIG_BCM_KONA_USB2_PHY is not set > # CONFIG_PHY_CADENCE_DP is not set > # CONFIG_PHY_CADENCE_DPHY is not set > @@ -4282,7 +4282,6 @@ > # CONFIG_PHY_PXA_28NM_USB2 is not set > # CONFIG_PHY_CPCAP_USB is not set > # CONFIG_PHY_MAPPHONE_MDM6600 is not set - > CONFIG_PHY_RCAR_GEN2=y # CONFIG_PHY_RCAR_GEN3_PCIE is not set # > CONFIG_PHY_RCAR_GEN3_USB3 is not set # CONFIG_POWERCAP is not set
On Wed, Apr 24, 2019 at 09:44:11AM +0000, Biju Das wrote: > Hi Simon, > > Thanks for the feedback. > > I missed to add the dependency for this patch. > > This patch has dependency on > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01 Thanks, but I see the same result with this patch applied on top of 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 > > -----Original Message----- > > From: Simon Horman <horms@verge.net.au> > > Sent: 24 April 2019 10:33 > > To: Geert Uytterhoeven <geert@linux-m68k.org> > > Cc: Biju Das <biju.das@bp.renesas.com>; Magnus Damm > > <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; Linux- > > Renesas <linux-renesas-soc@vger.kernel.org>; Linux ARM <linux-arm- > > kernel@lists.infradead.org>; Geert Uytterhoeven > > <geert+renesas@glider.be>; Chris Paterson > > <Chris.Paterson2@renesas.com>; Fabrizio Castro > > <fabrizio.castro@bp.renesas.com> > > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > > shmobile_defconfig > > > > On Wed, Apr 24, 2019 at 09:12:04AM +0200, Geert Uytterhoeven wrote: > > > On Tue, Apr 23, 2019 at 3:20 PM Biju Das <biju.das@bp.renesas.com> > > wrote: > > > > Remove the GENERIC_PHY config option from shmobile_defconfig, as it > > > > is selected by PHY_RCAR_GEN3_USB2. > > > > > > > > PHY_RCAR_GEN3_USB2 is enabled by the commit > > > > 0cd4f4f10245d1d9616e00245 > > > > ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in > > shmobile_defconfig"). > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > This does not seem to work as expected when applied on top of renesas- > > devel-20190423-v5.1-rc5. > > > > Without this patch I see both CONFIG_GENERIC_PHY and > > CONFIG_PHY_RCAR_GEN selected. With this patch I see neither selected, I > > expected both. > > > > --- .config.old 2019-04-24 11:31:12.480520934 +0200 > > +++ .config 2019-04-24 11:31:34.732852122 +0200 > > @@ -4272,7 +4272,7 @@ > > # > > # PHY Subsystem > > # > > -CONFIG_GENERIC_PHY=y > > +# CONFIG_GENERIC_PHY is not set > > # CONFIG_BCM_KONA_USB2_PHY is not set > > # CONFIG_PHY_CADENCE_DP is not set > > # CONFIG_PHY_CADENCE_DPHY is not set > > @@ -4282,7 +4282,6 @@ > > # CONFIG_PHY_PXA_28NM_USB2 is not set > > # CONFIG_PHY_CPCAP_USB is not set > > # CONFIG_PHY_MAPPHONE_MDM6600 is not set - > > CONFIG_PHY_RCAR_GEN2=y # CONFIG_PHY_RCAR_GEN3_PCIE is not set # > > CONFIG_PHY_RCAR_GEN3_USB3 is not set # CONFIG_POWERCAP is not set >
Hi Simon, Thanks for the feedback. > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > shmobile_defconfig > > On Wed, Apr 24, 2019 at 09:44:11AM +0000, Biju Das wrote: > > Hi Simon, > > > > Thanks for the feedback. > > > > I missed to add the dependency for this patch. > > > > This patch has dependency on > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/co > > mmit/?h=next-20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01 > > Thanks, but I see the same result with this patch applied on top of > > 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 That is strange. Have you ran make shmobile_defconfig after applying the patch? I get the following result with renesas- devel-20190423-v5.1-rc5. CONFIG_GENERIC_PHY=y # CONFIG_BCM_KONA_USB2_PHY is not set # CONFIG_PHY_CADENCE_DP is not set # CONFIG_PHY_CADENCE_DPHY is not set # CONFIG_PHY_CADENCE_SIERRA is not set # CONFIG_PHY_FSL_IMX8MQ_USB is not set # CONFIG_PHY_PXA_28NM_HSIC is not set # CONFIG_PHY_PXA_28NM_USB2 is not set # CONFIG_PHY_CPCAP_USB is not set # CONFIG_PHY_MAPPHONE_MDM6600 is not set CONFIG_PHY_RCAR_GEN2=y # CONFIG_PHY_RCAR_GEN3_PCIE is not set CONFIG_PHY_RCAR_GEN3_USB2=y Regards, Biju > > > -----Original Message----- > > > From: Simon Horman <horms@verge.net.au> > > > Sent: 24 April 2019 10:33 > > > To: Geert Uytterhoeven <geert@linux-m68k.org> > > > Cc: Biju Das <biju.das@bp.renesas.com>; Magnus Damm > > > <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; > > > Linux- Renesas <linux-renesas-soc@vger.kernel.org>; Linux ARM > > > <linux-arm- kernel@lists.infradead.org>; Geert Uytterhoeven > > > <geert+renesas@glider.be>; Chris Paterson > > > <Chris.Paterson2@renesas.com>; Fabrizio Castro > > > <fabrizio.castro@bp.renesas.com> > > > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > > > shmobile_defconfig > > > > > > On Wed, Apr 24, 2019 at 09:12:04AM +0200, Geert Uytterhoeven wrote: > > > > On Tue, Apr 23, 2019 at 3:20 PM Biju Das <biju.das@bp.renesas.com> > > > wrote: > > > > > Remove the GENERIC_PHY config option from shmobile_defconfig, as > > > > > it is selected by PHY_RCAR_GEN3_USB2. > > > > > > > > > > PHY_RCAR_GEN3_USB2 is enabled by the commit > > > > > 0cd4f4f10245d1d9616e00245 > > > > > ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in > > > shmobile_defconfig"). > > > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > This does not seem to work as expected when applied on top of > > > renesas- devel-20190423-v5.1-rc5. > > > > > > Without this patch I see both CONFIG_GENERIC_PHY and > > > CONFIG_PHY_RCAR_GEN selected. With this patch I see neither > > > selected, I expected both. > > > > > > --- .config.old 2019-04-24 11:31:12.480520934 +0200 > > > +++ .config 2019-04-24 11:31:34.732852122 +0200 > > > @@ -4272,7 +4272,7 @@ > > > # > > > # PHY Subsystem > > > # > > > -CONFIG_GENERIC_PHY=y > > > +# CONFIG_GENERIC_PHY is not set > > > # CONFIG_BCM_KONA_USB2_PHY is not set # > CONFIG_PHY_CADENCE_DP is > > > not set # CONFIG_PHY_CADENCE_DPHY is not set @@ -4282,7 +4282,6 > @@ > > > # CONFIG_PHY_PXA_28NM_USB2 is not set # CONFIG_PHY_CPCAP_USB > is not > > > set # CONFIG_PHY_MAPPHONE_MDM6600 is not set - > > > CONFIG_PHY_RCAR_GEN2=y # CONFIG_PHY_RCAR_GEN3_PCIE is not > set # > > > CONFIG_PHY_RCAR_GEN3_USB3 is not set # CONFIG_POWERCAP is not > set > >
On Wed, Apr 24, 2019 at 11:11:43AM +0000, Biju Das wrote: > Hi Simon, > > Thanks for the feedback. > > > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > > shmobile_defconfig > > > > On Wed, Apr 24, 2019 at 09:44:11AM +0000, Biju Das wrote: > > > Hi Simon, > > > > > > Thanks for the feedback. > > > > > > I missed to add the dependency for this patch. > > > > > > This patch has dependency on > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/co > > > mmit/?h=next-20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01 > > > > Thanks, but I see the same result with this patch applied on top of > > > > 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 > > That is strange. Have you ran make shmobile_defconfig after applying the patch? > > I get the following result with renesas- devel-20190423-v5.1-rc5. Thanks, I also see things working fine with both * [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig * 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 applied on top of renesas-devel-20190423-v5.1-rc5 I think I can go ahead and apply [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig once I rebase my branches on v5.2-rc1, agter it has been release and assuming it includes 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470
> Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > shmobile_defconfig > > On Wed, Apr 24, 2019 at 11:11:43AM +0000, Biju Das wrote: > > Hi Simon, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > > > shmobile_defconfig > > > > > > On Wed, Apr 24, 2019 at 09:44:11AM +0000, Biju Das wrote: > > > > Hi Simon, > > > > > > > > Thanks for the feedback. > > > > > > > > I missed to add the dependency for this patch. > > > > > > > > This patch has dependency on > > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.gi > > > > t/co > > > > mmit/?h=next- > 20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01 > > > > > > Thanks, but I see the same result with this patch applied on top of > > > > > > 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 > > > > That is strange. Have you ran make shmobile_defconfig after applying the > patch? > > > > I get the following result with renesas- devel-20190423-v5.1-rc5. > > Thanks, I also see things working fine with both > * [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig > * 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 applied on > top of renesas-devel-20190423-v5.1-rc5 > > I think I can go ahead and apply > [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig > once I rebase my branches on v5.2-rc1, agter it has been release and > assuming it includes > 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 Thanks Simon. Regards, Biju
On Fri, Apr 26, 2019 at 10:14:26AM +0000, Biju Das wrote: > > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > > shmobile_defconfig > > > > On Wed, Apr 24, 2019 at 11:11:43AM +0000, Biju Das wrote: > > > Hi Simon, > > > > > > Thanks for the feedback. > > > > > > > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > > > > shmobile_defconfig > > > > > > > > On Wed, Apr 24, 2019 at 09:44:11AM +0000, Biju Das wrote: > > > > > Hi Simon, > > > > > > > > > > Thanks for the feedback. > > > > > > > > > > I missed to add the dependency for this patch. > > > > > > > > > > This patch has dependency on > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.gi > > > > > t/co > > > > > mmit/?h=next- > > 20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01 > > > > > > > > Thanks, but I see the same result with this patch applied on top of > > > > > > > > 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 > > > > > > That is strange. Have you ran make shmobile_defconfig after applying the > > patch? > > > > > > I get the following result with renesas- devel-20190423-v5.1-rc5. > > > > Thanks, I also see things working fine with both > > * [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig > > * 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 applied on > > top of renesas-devel-20190423-v5.1-rc5 > > > > I think I can go ahead and apply > > [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig > > once I rebase my branches on v5.2-rc1, agter it has been release and > > assuming it includes > > 5d8042e95fd4 phy: rcar-gen3-usb2: Add support for r8a77470 > > Thanks Simon. Likewise, thanks. Now that v5.2-rc1 is available I have applied this patch for inclusion in v5.3.
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig index 78425dd..f0d44d4 100644 --- a/arch/arm/configs/shmobile_defconfig +++ b/arch/arm/configs/shmobile_defconfig @@ -197,7 +197,6 @@ CONFIG_PWM=y CONFIG_PWM_RCAR=y CONFIG_PWM_RENESAS_TPU=y CONFIG_RESET_CONTROLLER=y -CONFIG_GENERIC_PHY=y CONFIG_PHY_RCAR_GEN2=y CONFIG_PHY_RCAR_GEN3_USB2=y # CONFIG_DNOTIFY is not set
Remove the GENERIC_PHY config option from shmobile_defconfig, as it is selected by PHY_RCAR_GEN3_USB2. PHY_RCAR_GEN3_USB2 is enabled by the commit 0cd4f4f10245d1d9616e00245 ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig"). Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- arch/arm/configs/shmobile_defconfig | 1 - 1 file changed, 1 deletion(-)