Message ID | 20190423162932.21428-1-changbin.du@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | Include linux ACPI/PCI/X86 docs into Sphinx TOC tree | expand |
On Tue, Apr 23, 2019 at 6:30 PM Changbin Du <changbin.du@gmail.com> wrote: > > Hi Corbet and All, > The kernel now uses Sphinx to generate intelligent and beautiful documentation > from reStructuredText files. I converted all of the Linux ACPI/PCI/X86 docs to > reST format in this serias. > > In this version I combined ACPI and PCI docs, and added new x86 docs conversion. I'm not sure if combining all three into one big patch series has been a good idea, honestly. It would have been easier to review and handle otherwise. For one, I'd like to handle the ACPI part of it myself if Jon doesn't mind that. Thanks, Rafael
On Tue, Apr 23, 2019 at 06:39:47PM +0200, Rafael J. Wysocki wrote: > On Tue, Apr 23, 2019 at 6:30 PM Changbin Du <changbin.du@gmail.com> wrote: > > Hi Corbet and All, > > The kernel now uses Sphinx to generate intelligent and beautiful > > documentation from reStructuredText files. I converted all of the Linux > > ACPI/PCI/X86 docs to reST format in this serias. > > > > In this version I combined ACPI and PCI docs, and added new x86 docs > > conversion. > > I'm not sure if combining all three into one big patch series has been > a good idea, honestly. Yeah, if you post this again, I would find it easier to deal with if linux-pci only got the PCI-related things. 63 patches is a little too much for one series. Bjorn
On Tue, Apr 23, 2019 at 12:36:44PM -0500, Bjorn Helgaas wrote: > On Tue, Apr 23, 2019 at 06:39:47PM +0200, Rafael J. Wysocki wrote: > > On Tue, Apr 23, 2019 at 6:30 PM Changbin Du <changbin.du@gmail.com> wrote: > > > Hi Corbet and All, > > > The kernel now uses Sphinx to generate intelligent and beautiful > > > documentation from reStructuredText files. I converted all of the Linux > > > ACPI/PCI/X86 docs to reST format in this serias. > > > > > > In this version I combined ACPI and PCI docs, and added new x86 docs > > > conversion. > > > > I'm not sure if combining all three into one big patch series has been > > a good idea, honestly. > > Yeah, if you post this again, I would find it easier to deal with if > linux-pci only got the PCI-related things. 63 patches is a little too > much for one series. > sure, so I will resend them respectively. > Bjorn
On Wed, 24 Apr 2019 00:28:29 +0800 Changbin Du <changbin.du@gmail.com> wrote: > The kernel now uses Sphinx to generate intelligent and beautiful documentation > from reStructuredText files. I converted all of the Linux ACPI/PCI/X86 docs to > reST format in this serias. > > In this version I combined ACPI and PCI docs, and added new x86 docs conversion. As mentioned by others, this is a lot of stuff; I would really rather see each of those groups as separate patch sets. If you can do a reasonably quick turnaround with Mauro's suggestions addressed and tags applied, we should be able to get at least some of this into 5.2. Thanks, Mauro, for looking at all of this stuff! Thanks, jon
Em Wed, 24 Apr 2019 10:18:46 -0600 Jonathan Corbet <corbet@lwn.net> escreveu: > On Wed, 24 Apr 2019 00:28:29 +0800 > Changbin Du <changbin.du@gmail.com> wrote: > > > The kernel now uses Sphinx to generate intelligent and beautiful documentation > > from reStructuredText files. I converted all of the Linux ACPI/PCI/X86 docs to > > reST format in this serias. > > > > In this version I combined ACPI and PCI docs, and added new x86 docs conversion. > > As mentioned by others, this is a lot of stuff; I would really rather see > each of those groups as separate patch sets. Yeah, makes sense to me, either to split into separate patchsets or to group the changes per sub-dir (or both). > If you can do a reasonably quick turnaround with Mauro's suggestions > addressed and tags applied, we should be able to get at least some of this > into 5.2. Thanks, Mauro, for looking at all of this stuff! Anytime! Just to make clear, I'm still reviewing it... I'm at patch 35/63 now. So, expect more comments from my side. Thanks, Mauro
Em Wed, 24 Apr 2019 23:46:18 +0800 Changbin Du <changbin.du@gmail.com> escreveu: > On Tue, Apr 23, 2019 at 12:36:44PM -0500, Bjorn Helgaas wrote: > > On Tue, Apr 23, 2019 at 06:39:47PM +0200, Rafael J. Wysocki wrote: > > > On Tue, Apr 23, 2019 at 6:30 PM Changbin Du <changbin.du@gmail.com> wrote: > > > > Hi Corbet and All, > > > > The kernel now uses Sphinx to generate intelligent and beautiful > > > > documentation from reStructuredText files. I converted all of the Linux > > > > ACPI/PCI/X86 docs to reST format in this serias. > > > > > > > > In this version I combined ACPI and PCI docs, and added new x86 docs > > > > conversion. > > > > > > I'm not sure if combining all three into one big patch series has been > > > a good idea, honestly. > > > > Yeah, if you post this again, I would find it easier to deal with if > > linux-pci only got the PCI-related things. 63 patches is a little too > > much for one series. > > > sure, so I will resend them respectively. I reviewed up to patch 39. There are too many files on x86 that seems to be mangled by some tab->whitespace conversion, with caused very big diffs and lots of broken ascii artwork. Please ensure that the diffs will contain the minimal amount of stuff that would be required for them to be properly formatted as ReST files there. Ah, perhaps next time you could format the patches with a lower merge similarity logic (using, for example, the parameter -M10). Regards, Mauro > > > Bjorn > Thanks, Mauro