| Message ID | 1555901236-145920-1-git-send-email-wright.feng@cypress.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | brcmfmac: remove the duplicate line of sending mail box interrupt | expand |
On April 22, 2019 4:47:31 AM Wright Feng <Wright.Feng@cypress.com> wrote: > The line is duplicate so remove it from pcie.c. We don't need to send > host to dongle mail box interrupt twice after writing data. Hi Wright, Thanks for the patch. I am a bit early as it is not uncommon that hardware requires an extra kick. Might be the case here for some chips. Will follow-up on it. Regards, Arend > Signed-off-by: Wright Feng <wright.feng@cypress.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 - > 1 file changed, 1 deletion(-)
On 4/24/2019 7:24 AM, Arend Van Spriel wrote: > On April 22, 2019 4:47:31 AM Wright Feng <Wright.Feng@cypress.com> wrote: > >> The line is duplicate so remove it from pcie.c. We don't need to send >> host to dongle mail box interrupt twice after writing data. > > Hi Wright, > > Thanks for the patch. I am a bit early as it is not uncommon that > hardware requires an extra kick. Might be the case here for some chips. > Will follow-up on it. Hi Wright, I checked in our dhd driver code and it also does a double write. Turns out to be a hardware workaround so we need to keep this. It is worth a comment though. Thanks, Arend
On 2019/4/24 下午 04:46, Arend Van Spriel wrote: > On 4/24/2019 7:24 AM, Arend Van Spriel wrote: >> On April 22, 2019 4:47:31 AM Wright Feng <Wright.Feng@cypress.com> wrote: >> >>> The line is duplicate so remove it from pcie.c. We don't need to send >>> host to dongle mail box interrupt twice after writing data. >> >> Hi Wright, >> >> Thanks for the patch. I am a bit early as it is not uncommon that >> hardware requires an extra kick. Might be the case here for some >> chips. Will follow-up on it. > > Hi Wright, > > I checked in our dhd driver code and it also does a double write. Turns > out to be a hardware workaround so we need to keep this. It is worth a > comment though. > Hi Arend, Thanks for the information. NXP and I worked on suspend/resume stress test issue with 1FD(4359b1) two months ago, and we found one of root cause is duplicate mailbox interrupt. I've checked the history of the hardware issue internally, and it seems that the issue is only on PCIEGEN2 revision 1 to 13. So is that okay we can skip the hardware workaround when PCIEGEN2 revision is greater than 13 and add the comment on it in my patch v2? Regards, Wright > Thanks, > Arend
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index fd3968f..ca619a9 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -698,7 +698,6 @@ brcmf_pcie_send_mb_data(struct brcmf_pciedev_info *devinfo, u32 htod_mb_data) brcmf_pcie_write_tcm32(devinfo, addr, htod_mb_data); pci_write_config_dword(devinfo->pdev, BRCMF_PCIE_REG_SBMBX, 1); - pci_write_config_dword(devinfo->pdev, BRCMF_PCIE_REG_SBMBX, 1); return 0; }
The line is duplicate so remove it from pcie.c. We don't need to send host to dongle mail box interrupt twice after writing data. Signed-off-by: Wright Feng <wright.feng@cypress.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 - 1 file changed, 1 deletion(-)