| Message ID | 1556185800-20098-1-git-send-email-sw0312.kim@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [libdrm] tests/libkms-test-plane: fix possbile memory leak | expand |
On Thu, 25 Apr 2019 at 10:49, Seung-Woo Kim <sw0312.kim@samsung.com> wrote: > > The pointer p aquired with drmModeGetPlane() is not free in error > path. Fix possible memory leak by calling drmModeFreePlane() in > the error path. > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> and pushed to master. Thanks Emil
diff --git a/tests/kms/libkms-test-plane.c b/tests/kms/libkms-test-plane.c index 6c40a3c..4cb2737 100644 --- a/tests/kms/libkms-test-plane.c +++ b/tests/kms/libkms-test-plane.c @@ -55,8 +55,10 @@ static int kms_plane_probe(struct kms_plane *plane) } plane->formats = calloc(p->count_formats, sizeof(uint32_t)); - if (!plane->formats) + if (!plane->formats) { + drmModeFreePlane(p); return -ENOMEM; + } for (i = 0; i < p->count_formats; i++) plane->formats[i] = p->formats[i];
The pointer p aquired with drmModeGetPlane() is not free in error path. Fix possible memory leak by calling drmModeFreePlane() in the error path. Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> --- tests/kms/libkms-test-plane.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)