| Message ID | 20190308151723.27374-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3a349763cf11e63534b8f2d302f2d0c790566497 |
| Headers | show |
| Series | [v2] Input: synaptics-rmi4 - write config register values to the right offset | expand |
On Fri, 2019-03-08 at 16:17 +0100, Lucas Stach wrote: > Currently any changed config register values don't take effect, as the > function to write them back is called with the wrong register offset. > > Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D > sensors and F11) > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > v2: drop spurious whitespace change > --- > drivers/input/rmi4/rmi_f11.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index df64d6aed4f7..93901ebd122a 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -1230,7 +1230,7 @@ static int rmi_f11_initialize(struct rmi_function *fn) > } > > rc = f11_write_control_regs(fn, &f11->sens_query, > - &f11->dev_controls, fn->fd.query_base_addr); > + &f11->dev_controls, fn->fd.control_base_addr); > if (rc) > dev_warn(&fn->dev, "Failed to write control registers\n"); Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
Hi Dmitry, did this patch fall through the cracks? Regards, Lucas Am Freitag, den 08.03.2019, 16:17 +0100 schrieb Lucas Stach: > Currently any changed config register values don't take effect, as the > function to write them back is called with the wrong register offset. > > Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D > sensors and F11) > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > v2: drop spurious whitespace change > --- > drivers/input/rmi4/rmi_f11.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index df64d6aed4f7..93901ebd122a 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -1230,7 +1230,7 @@ static int rmi_f11_initialize(struct rmi_function *fn) > } > > rc = f11_write_control_regs(fn, &f11->sens_query, > - &f11->dev_controls, fn->fd.query_base_addr); > + &f11->dev_controls, fn->fd.control_base_addr); > if (rc) > dev_warn(&fn->dev, "Failed to write control registers\n"); >
On Fri, Mar 08, 2019 at 04:17:23PM +0100, Lucas Stach wrote: > Currently any changed config register values don't take effect, as the > function to write them back is called with the wrong register offset. > > Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D > sensors and F11) > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Applied, thank you. > --- > v2: drop spurious whitespace change > --- > drivers/input/rmi4/rmi_f11.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index df64d6aed4f7..93901ebd122a 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -1230,7 +1230,7 @@ static int rmi_f11_initialize(struct rmi_function *fn) > } > > rc = f11_write_control_regs(fn, &f11->sens_query, > - &f11->dev_controls, fn->fd.query_base_addr); > + &f11->dev_controls, fn->fd.control_base_addr); > if (rc) > dev_warn(&fn->dev, "Failed to write control registers\n"); > > -- > 2.20.1 >
diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index df64d6aed4f7..93901ebd122a 100644 --- a/drivers/input/rmi4/rmi_f11.c +++ b/drivers/input/rmi4/rmi_f11.c @@ -1230,7 +1230,7 @@ static int rmi_f11_initialize(struct rmi_function *fn) } rc = f11_write_control_regs(fn, &f11->sens_query, - &f11->dev_controls, fn->fd.query_base_addr); + &f11->dev_controls, fn->fd.control_base_addr); if (rc) dev_warn(&fn->dev, "Failed to write control registers\n");
Currently any changed config register values don't take effect, as the function to write them back is called with the wrong register offset. Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D sensors and F11) Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- v2: drop spurious whitespace change --- drivers/input/rmi4/rmi_f11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)