mbox series

[v8,00/12] SIW: Request for Comments

Message ID 20190426131852.30142-1-bmt@zurich.ibm.com (mailing list archive)
Headers show
Series SIW: Request for Comments | expand

Message

Bernard Metzler April 26, 2019, 1:18 p.m. UTC
This patch set contributes version 8 of the SoftiWarp
driver, as originally introduced to the list Oct 6th, 2017.
SoftiWarp (siw) implements the iWarp RDMA protocol over
kernel TCP sockets. The driver integrates with the
linux-rdma framework.

The only purpose of this patch set is to rebase the driver
to the current code base of the 'rdma/for-next' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git

There are no functional changes wrt. version 7, except one
bug fix in the fast MR registration path, where an application
provided, changed IO address was not taken into account.

As said, the current patch set is based on rdma/for-next.
For convenience, it is also maintained at
https://github.com/zrlio/softiwarp-for-linux-rdma.git
within branch 'siw-for-rdma-next-v8'.

Thanks very much for your time and help!

Bernard.

Bernard Metzler (12):
  iWarp wire packet format
  SIW main include file
  SIW network and RDMA core interface
  SIW connection management
  SIW application interface
  SIW application buffer management
  SIW queue pair methods
  SIW transmit path
  SIW receive path
  SIW completion queue methods
  SIW debugging
  SIW addition to kernel build environment

 MAINTAINERS                              |    7 +
 drivers/infiniband/Kconfig               |    1 +
 drivers/infiniband/sw/Makefile           |    1 +
 drivers/infiniband/sw/siw/Kconfig        |   17 +
 drivers/infiniband/sw/siw/Makefile       |   12 +
 drivers/infiniband/sw/siw/iwarp.h        |  379 ++++
 drivers/infiniband/sw/siw/siw.h          |  733 ++++++++
 drivers/infiniband/sw/siw/siw_cm.c       | 2107 ++++++++++++++++++++++
 drivers/infiniband/sw/siw/siw_cm.h       |  121 ++
 drivers/infiniband/sw/siw/siw_cq.c       |  109 ++
 drivers/infiniband/sw/siw/siw_debug.c    |   91 +
 drivers/infiniband/sw/siw/siw_debug.h    |   40 +
 drivers/infiniband/sw/siw/siw_main.c     |  712 ++++++++
 drivers/infiniband/sw/siw/siw_mem.c      |  464 +++++
 drivers/infiniband/sw/siw/siw_mem.h      |   53 +
 drivers/infiniband/sw/siw/siw_qp.c       | 1354 ++++++++++++++
 drivers/infiniband/sw/siw/siw_qp_rx.c    | 1520 ++++++++++++++++
 drivers/infiniband/sw/siw/siw_qp_tx.c    | 1291 +++++++++++++
 drivers/infiniband/sw/siw/siw_verbs.c    | 1826 +++++++++++++++++++
 drivers/infiniband/sw/siw/siw_verbs.h    |   83 +
 include/uapi/rdma/rdma_user_ioctl_cmds.h |    1 +
 include/uapi/rdma/siw_user.h             |  186 ++
 22 files changed, 11108 insertions(+)
 create mode 100644 drivers/infiniband/sw/siw/Kconfig
 create mode 100644 drivers/infiniband/sw/siw/Makefile
 create mode 100644 drivers/infiniband/sw/siw/iwarp.h
 create mode 100644 drivers/infiniband/sw/siw/siw.h
 create mode 100644 drivers/infiniband/sw/siw/siw_cm.c
 create mode 100644 drivers/infiniband/sw/siw/siw_cm.h
 create mode 100644 drivers/infiniband/sw/siw/siw_cq.c
 create mode 100644 drivers/infiniband/sw/siw/siw_debug.c
 create mode 100644 drivers/infiniband/sw/siw/siw_debug.h
 create mode 100644 drivers/infiniband/sw/siw/siw_main.c
 create mode 100644 drivers/infiniband/sw/siw/siw_mem.c
 create mode 100644 drivers/infiniband/sw/siw/siw_mem.h
 create mode 100644 drivers/infiniband/sw/siw/siw_qp.c
 create mode 100644 drivers/infiniband/sw/siw/siw_qp_rx.c
 create mode 100644 drivers/infiniband/sw/siw/siw_qp_tx.c
 create mode 100644 drivers/infiniband/sw/siw/siw_verbs.c
 create mode 100644 drivers/infiniband/sw/siw/siw_verbs.h
 create mode 100644 include/uapi/rdma/siw_user.h

Comments

Leon Romanovsky April 26, 2019, 9:07 p.m. UTC | #1
On Fri, Apr 26, 2019 at 03:18:40PM +0200, Bernard Metzler wrote:
> This patch set contributes version 8 of the SoftiWarp
> driver, as originally introduced to the list Oct 6th, 2017.
> SoftiWarp (siw) implements the iWarp RDMA protocol over
> kernel TCP sockets. The driver integrates with the
> linux-rdma framework.
>
> The only purpose of this patch set is to rebase the driver
> to the current code base of the 'rdma/for-next' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
>
> There are no functional changes wrt. version 7, except one
> bug fix in the fast MR registration path, where an application
> provided, changed IO address was not taken into account.
>
> As said, the current patch set is based on rdma/for-next.
> For convenience, it is also maintained at
> https://github.com/zrlio/softiwarp-for-linux-rdma.git
> within branch 'siw-for-rdma-next-v8'.
>
> Thanks very much for your time and help!
>
> Bernard.
>
> Bernard Metzler (12):
>   iWarp wire packet format
>   SIW main include file
>   SIW network and RDMA core interface
>   SIW connection management
>   SIW application interface
>   SIW application buffer management
>   SIW queue pair methods
>   SIW transmit path
>   SIW receive path
>   SIW completion queue methods
>   SIW debugging
>   SIW addition to kernel build environment
>
>  MAINTAINERS                              |    7 +
>  drivers/infiniband/Kconfig               |    1 +
>  drivers/infiniband/sw/Makefile           |    1 +
>  drivers/infiniband/sw/siw/Kconfig        |   17 +
>  drivers/infiniband/sw/siw/Makefile       |   12 +
>  drivers/infiniband/sw/siw/iwarp.h        |  379 ++++
>  drivers/infiniband/sw/siw/siw.h          |  733 ++++++++
>  drivers/infiniband/sw/siw/siw_cm.c       | 2107 ++++++++++++++++++++++
>  drivers/infiniband/sw/siw/siw_cm.h       |  121 ++
>  drivers/infiniband/sw/siw/siw_cq.c       |  109 ++
>  drivers/infiniband/sw/siw/siw_debug.c    |   91 +
>  drivers/infiniband/sw/siw/siw_debug.h    |   40 +
>  drivers/infiniband/sw/siw/siw_main.c     |  712 ++++++++
>  drivers/infiniband/sw/siw/siw_mem.c      |  464 +++++
>  drivers/infiniband/sw/siw/siw_mem.h      |   53 +
>  drivers/infiniband/sw/siw/siw_qp.c       | 1354 ++++++++++++++
>  drivers/infiniband/sw/siw/siw_qp_rx.c    | 1520 ++++++++++++++++
>  drivers/infiniband/sw/siw/siw_qp_tx.c    | 1291 +++++++++++++
>  drivers/infiniband/sw/siw/siw_verbs.c    | 1826 +++++++++++++++++++
>  drivers/infiniband/sw/siw/siw_verbs.h    |   83 +
>  include/uapi/rdma/rdma_user_ioctl_cmds.h |    1 +
>  include/uapi/rdma/siw_user.h             |  186 ++

To make our life easier, that file should be named like all
other files: siw-abi.h.

Thanks

>  22 files changed, 11108 insertions(+)
>  create mode 100644 drivers/infiniband/sw/siw/Kconfig
>  create mode 100644 drivers/infiniband/sw/siw/Makefile
>  create mode 100644 drivers/infiniband/sw/siw/iwarp.h
>  create mode 100644 drivers/infiniband/sw/siw/siw.h
>  create mode 100644 drivers/infiniband/sw/siw/siw_cm.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_cm.h
>  create mode 100644 drivers/infiniband/sw/siw/siw_cq.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_debug.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_debug.h
>  create mode 100644 drivers/infiniband/sw/siw/siw_main.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_mem.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_mem.h
>  create mode 100644 drivers/infiniband/sw/siw/siw_qp.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_qp_rx.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_qp_tx.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_verbs.c
>  create mode 100644 drivers/infiniband/sw/siw/siw_verbs.h
>  create mode 100644 include/uapi/rdma/siw_user.h
>
> --
> 2.17.2
>
Bernard Metzler May 2, 2019, 2:48 p.m. UTC | #2
-----"Leon Romanovsky" <leon@kernel.org> wrote: -----

>To: "Bernard Metzler" <bmt@zurich.ibm.com>
>From: "Leon Romanovsky" <leon@kernel.org>
>Date: 04/26/2019 11:07PM
>Cc: linux-rdma@vger.kernel.org
>Subject: Re: [PATCH v8 00/12] SIW: Request for Comments
>
>On Fri, Apr 26, 2019 at 03:18:40PM +0200, Bernard Metzler wrote:
>> This patch set contributes version 8 of the SoftiWarp
>> driver, as originally introduced to the list Oct 6th, 2017.
>> SoftiWarp (siw) implements the iWarp RDMA protocol over
>> kernel TCP sockets. The driver integrates with the
>> linux-rdma framework.
>>
>> The only purpose of this patch set is to rebase the driver
>> to the current code base of the 'rdma/for-next' branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
>>
>> There are no functional changes wrt. version 7, except one
>> bug fix in the fast MR registration path, where an application
>> provided, changed IO address was not taken into account.
>>
>> As said, the current patch set is based on rdma/for-next.
>> For convenience, it is also maintained at
>>
>https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_zrlio
>_softiwarp-2Dfor-2Dlinux-2Drdma.git&d=DwIBAg&c=jf_iaSHvJObTbx-siA1ZOg
>&r=2TaYXQ0T-r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=s8kBzxPaiWgkYRMQ4GYI
>r7PWqYcD_iXi93ILDWO7c7E&s=XVI0RTnHzvzg_hoLQv66acO8xfIn3HchSRrxZ0Z4ySE
>&e=
>> within branch 'siw-for-rdma-next-v8'.
>>
>> Thanks very much for your time and help!
>>
>> Bernard.
>>
>> Bernard Metzler (12):
>>   iWarp wire packet format
>>   SIW main include file
>>   SIW network and RDMA core interface
>>   SIW connection management
>>   SIW application interface
>>   SIW application buffer management
>>   SIW queue pair methods
>>   SIW transmit path
>>   SIW receive path
>>   SIW completion queue methods
>>   SIW debugging
>>   SIW addition to kernel build environment
>>
>>  MAINTAINERS                              |    7 +
>>  drivers/infiniband/Kconfig               |    1 +
>>  drivers/infiniband/sw/Makefile           |    1 +
>>  drivers/infiniband/sw/siw/Kconfig        |   17 +
>>  drivers/infiniband/sw/siw/Makefile       |   12 +
>>  drivers/infiniband/sw/siw/iwarp.h        |  379 ++++
>>  drivers/infiniband/sw/siw/siw.h          |  733 ++++++++
>>  drivers/infiniband/sw/siw/siw_cm.c       | 2107
>++++++++++++++++++++++
>>  drivers/infiniband/sw/siw/siw_cm.h       |  121 ++
>>  drivers/infiniband/sw/siw/siw_cq.c       |  109 ++
>>  drivers/infiniband/sw/siw/siw_debug.c    |   91 +
>>  drivers/infiniband/sw/siw/siw_debug.h    |   40 +
>>  drivers/infiniband/sw/siw/siw_main.c     |  712 ++++++++
>>  drivers/infiniband/sw/siw/siw_mem.c      |  464 +++++
>>  drivers/infiniband/sw/siw/siw_mem.h      |   53 +
>>  drivers/infiniband/sw/siw/siw_qp.c       | 1354 ++++++++++++++
>>  drivers/infiniband/sw/siw/siw_qp_rx.c    | 1520 ++++++++++++++++
>>  drivers/infiniband/sw/siw/siw_qp_tx.c    | 1291 +++++++++++++
>>  drivers/infiniband/sw/siw/siw_verbs.c    | 1826
>+++++++++++++++++++
>>  drivers/infiniband/sw/siw/siw_verbs.h    |   83 +
>>  include/uapi/rdma/rdma_user_ioctl_cmds.h |    1 +
>>  include/uapi/rdma/siw_user.h             |  186 ++
>
>To make our life easier, that file should be named like all
>other files: siw-abi.h.
>
>Thanks

Hi Leon,

I just saw your several responses to my last RFC for
siw (version 8). Thank you very much for your help.
Sorry for not acting on it earlier. Since Friday
night last week I am on a vacation trip with very
limited time to work on it. I will be back next week
and reply asap.

Again, many thanks!

Bernard.
>
>>  22 files changed, 11108 insertions(+)
>>  create mode 100644 drivers/infiniband/sw/siw/Kconfig
>>  create mode 100644 drivers/infiniband/sw/siw/Makefile
>>  create mode 100644 drivers/infiniband/sw/siw/iwarp.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_cm.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_cm.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_cq.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_debug.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_debug.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_main.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_mem.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_mem.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_qp.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_qp_rx.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_qp_tx.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_verbs.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_verbs.h
>>  create mode 100644 include/uapi/rdma/siw_user.h
>>
>> --
>> 2.17.2
>>
>
>
Bernard Metzler May 7, 2019, 2:34 p.m. UTC | #3
-----"Leon Romanovsky" <leon@kernel.org> wrote: -----

>To: "Bernard Metzler" <bmt@zurich.ibm.com>
>From: "Leon Romanovsky" <leon@kernel.org>
>Date: 04/26/2019 11:07PM
>Cc: linux-rdma@vger.kernel.org
>Subject: Re: [PATCH v8 00/12] SIW: Request for Comments
>
>On Fri, Apr 26, 2019 at 03:18:40PM +0200, Bernard Metzler wrote:
>> This patch set contributes version 8 of the SoftiWarp
>> driver, as originally introduced to the list Oct 6th, 2017.
>> SoftiWarp (siw) implements the iWarp RDMA protocol over
>> kernel TCP sockets. The driver integrates with the
>> linux-rdma framework.
>>
>> The only purpose of this patch set is to rebase the driver
>> to the current code base of the 'rdma/for-next' branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
>>
>> There are no functional changes wrt. version 7, except one
>> bug fix in the fast MR registration path, where an application
>> provided, changed IO address was not taken into account.
>>
>> As said, the current patch set is based on rdma/for-next.
>> For convenience, it is also maintained at
>>
>https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_zrlio
>_softiwarp-2Dfor-2Dlinux-2Drdma.git&d=DwIBAg&c=jf_iaSHvJObTbx-siA1ZOg
>&r=2TaYXQ0T-r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=s8kBzxPaiWgkYRMQ4GYI
>r7PWqYcD_iXi93ILDWO7c7E&s=XVI0RTnHzvzg_hoLQv66acO8xfIn3HchSRrxZ0Z4ySE
>&e=
>> within branch 'siw-for-rdma-next-v8'.
>>
>> Thanks very much for your time and help!
>>
>> Bernard.
>>
>> Bernard Metzler (12):
>>   iWarp wire packet format
>>   SIW main include file
>>   SIW network and RDMA core interface
>>   SIW connection management
>>   SIW application interface
>>   SIW application buffer management
>>   SIW queue pair methods
>>   SIW transmit path
>>   SIW receive path
>>   SIW completion queue methods
>>   SIW debugging
>>   SIW addition to kernel build environment
>>
>>  MAINTAINERS                              |    7 +
>>  drivers/infiniband/Kconfig               |    1 +
>>  drivers/infiniband/sw/Makefile           |    1 +
>>  drivers/infiniband/sw/siw/Kconfig        |   17 +
>>  drivers/infiniband/sw/siw/Makefile       |   12 +
>>  drivers/infiniband/sw/siw/iwarp.h        |  379 ++++
>>  drivers/infiniband/sw/siw/siw.h          |  733 ++++++++
>>  drivers/infiniband/sw/siw/siw_cm.c       | 2107
>++++++++++++++++++++++
>>  drivers/infiniband/sw/siw/siw_cm.h       |  121 ++
>>  drivers/infiniband/sw/siw/siw_cq.c       |  109 ++
>>  drivers/infiniband/sw/siw/siw_debug.c    |   91 +
>>  drivers/infiniband/sw/siw/siw_debug.h    |   40 +
>>  drivers/infiniband/sw/siw/siw_main.c     |  712 ++++++++
>>  drivers/infiniband/sw/siw/siw_mem.c      |  464 +++++
>>  drivers/infiniband/sw/siw/siw_mem.h      |   53 +
>>  drivers/infiniband/sw/siw/siw_qp.c       | 1354 ++++++++++++++
>>  drivers/infiniband/sw/siw/siw_qp_rx.c    | 1520 ++++++++++++++++
>>  drivers/infiniband/sw/siw/siw_qp_tx.c    | 1291 +++++++++++++
>>  drivers/infiniband/sw/siw/siw_verbs.c    | 1826
>+++++++++++++++++++
>>  drivers/infiniband/sw/siw/siw_verbs.h    |   83 +
>>  include/uapi/rdma/rdma_user_ioctl_cmds.h |    1 +
>>  include/uapi/rdma/siw_user.h             |  186 ++
>
>To make our life easier, that file should be named like all
>other files: siw-abi.h.
>
OK, will do.

>>  22 files changed, 11108 insertions(+)
>>  create mode 100644 drivers/infiniband/sw/siw/Kconfig
>>  create mode 100644 drivers/infiniband/sw/siw/Makefile
>>  create mode 100644 drivers/infiniband/sw/siw/iwarp.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_cm.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_cm.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_cq.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_debug.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_debug.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_main.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_mem.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_mem.h
>>  create mode 100644 drivers/infiniband/sw/siw/siw_qp.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_qp_rx.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_qp_tx.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_verbs.c
>>  create mode 100644 drivers/infiniband/sw/siw/siw_verbs.h
>>  create mode 100644 include/uapi/rdma/siw_user.h
>>
>> --
>> 2.17.2
>>
>
>