[0/7] irqchip: Use devm_platform_ioremap_resource()

Message

Mukesh Ojha April 4, 2019, 7:20 a.m. UTC

Hi All,

This is just a minor change to promote using of this api
devm_platform_ioremap_resource() and nothing else functional
change it does.

Also, there are patches where only ioremap is used without requesting
the mem region so this devm_platform_ioremap_resource() take cares all
of that in single call.


Mukesh Ojha (7):
  irqchip/irq-uniphier-aidet: Use devm_platform_ioremap_resource()
  irqchip/irq-imgpdc.c: Use devm_platform_ioremap_resource()
  irqchip/irq-ts4800.c: Use devm_platform_ioremap_resource()
  irqchip/irq-mbigen.c: Use devm_platform_ioremap_resource()
  irqchip/irq-mvebu-icu: Use devm_platform_ioremap_resource()
  irqchip/irq-mvebu-pic: Use devm_platform_ioremap_resource()
  irqchip/irq-mvebu-sei: Use devm_platform_ioremap_resource()

 drivers/irqchip/irq-imgpdc.c         | 10 +---------
 drivers/irqchip/irq-ls-scfg-msi.c    |  4 +---
 drivers/irqchip/irq-mbigen.c         |  9 +--------
 drivers/irqchip/irq-mvebu-icu.c      |  4 +---
 drivers/irqchip/irq-mvebu-pic.c      |  4 +---
 drivers/irqchip/irq-mvebu-sei.c      |  3 +--
 drivers/irqchip/irq-ts4800.c         |  4 +---
 drivers/irqchip/irq-uniphier-aidet.c |  4 +---
 8 files changed, 8 insertions(+), 34 deletions(-)

Comments

Marc Zyngier April 29, 2019, 8:27 a.m. UTC | #1

On 04/04/2019 08:20, Mukesh Ojha wrote:
> Hi All,
> 
> This is just a minor change to promote using of this api
> devm_platform_ioremap_resource() and nothing else functional
> change it does.
> 
> Also, there are patches where only ioremap is used without requesting
> the mem region so this devm_platform_ioremap_resource() take cares all
> of that in single call.

This series has a number of problems:

- It seems to introduce bugs rather than fixing anything
- It doesn't do a complete job of cleaning up the drivers
- Patch 4 does more than it is advertises doing
- You haven't cc'd the authors of these drivers, which would be common
courtesy

For a series that is a "minor change", that's a bit much. Please do not
send such blanket changes without understanding what you are doing.

Thanks,

	M.