| Message ID | 20190429051944.77164-1-nbelakovski@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | | expand |
On Sun, Apr 28, 2019 at 10:19:41PM -0700, nbelakovski@gmail.com wrote: > From: Nickolai Belakovski <nbelakovski@gmail.com> > > Added test_i18ncmp per instructions from Szeder > > Is there some other part of the infrastructure that's testing for this? Because it did not fail in any of my Travis CI builds. > > Travis CI results: https://travis-ci.org/nbelakovski/git/builds/525801210 Testing with GETTEXT_POISON was broken since 6cdccfce (i18n: make GETTEXT_POISON a runtime option, 2018-11-08), and didn't catch any of these issues. See: https://public-inbox.org/git/xmqqlg0bvppc.fsf_-_@gitster-ct.c.googlers.com/T/#u The fix f88b9cb603 (gettext tests: export the restored GIT_TEST_GETTEXT_POISON, 2019-04-15) was merged to master just last week.
> Testing with GETTEXT_POISON was broken since 6cdccfce (i18n: make > GETTEXT_POISON a runtime option, 2018-11-08), and didn't catch any of > these issues. See: > > https://public-inbox.org/git/xmqqlg0bvppc.fsf_-_@gitster-ct.c.googlers.com/T/#u > > The fix f88b9cb603 (gettext tests: export the restored > GIT_TEST_GETTEXT_POISON, 2019-04-15) was merged to master just last > week. > Ah I see, thanks for the info.
Hi, am I the only person who is puzzled every time this patch series with a completely empty subject and without any further explanation about the intent in the mail body is sent? Ciao, Johannes On Sun, 28 Apr 2019, nbelakovski@gmail.com wrote: > From: Nickolai Belakovski <nbelakovski@gmail.com> > > Added test_i18ncmp per instructions from Szeder > > Is there some other part of the infrastructure that's testing for this? Because it did not fail in any of my Travis CI builds. > > Travis CI results: https://travis-ci.org/nbelakovski/git/builds/525801210 > > Nickolai Belakovski (3): > ref-filter: add worktreepath atom > branch: update output to include worktree info > branch: add worktree info on verbose output > > Documentation/git-branch.txt | 12 ++++-- > Documentation/git-for-each-ref.txt | 5 +++ > builtin/branch.c | 16 ++++++-- > ref-filter.c | 78 ++++++++++++++++++++++++++++++++++++++ > t/t3200-branch.sh | 16 +++++--- > t/t3203-branch-output.sh | 43 ++++++++++++++++++++- > t/t6302-for-each-ref-filter.sh | 13 +++++++ > 7 files changed, 168 insertions(+), 15 deletions(-) > > -- > 2.14.2 > >
Sorry, I'm not very accustomed to mailing list development. I had assumed that this was being threaded with the other messages in the series, hence leaving the subject blank and only putting new info in the body. In the future I'll add in an appropriate subject and brief re-hash in the body. Thanks for bringing it up. Nickolai On Mon, Apr 29, 2019 at 1:57 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > > Hi, > > am I the only person who is puzzled every time this patch series with a > completely empty subject and without any further explanation about the > intent in the mail body is sent? > > Ciao, > Johannes > > > On Sun, 28 Apr 2019, nbelakovski@gmail.com wrote: > > > From: Nickolai Belakovski <nbelakovski@gmail.com> > > > > Added test_i18ncmp per instructions from Szeder > > > > Is there some other part of the infrastructure that's testing for this? Because it did not fail in any of my Travis CI builds. > > > > Travis CI results: https://travis-ci.org/nbelakovski/git/builds/525801210 > > > > Nickolai Belakovski (3): > > ref-filter: add worktreepath atom > > branch: update output to include worktree info > > branch: add worktree info on verbose output > > > > Documentation/git-branch.txt | 12 ++++-- > > Documentation/git-for-each-ref.txt | 5 +++ > > builtin/branch.c | 16 ++++++-- > > ref-filter.c | 78 ++++++++++++++++++++++++++++++++++++++ > > t/t3200-branch.sh | 16 +++++--- > > t/t3203-branch-output.sh | 43 ++++++++++++++++++++- > > t/t6302-for-each-ref-filter.sh | 13 +++++++ > > 7 files changed, 168 insertions(+), 15 deletions(-) > > > > -- > > 2.14.2 > > > >
Hi Nickolai, On Mon, 29 Apr 2019, Nickolai Belakovski wrote: > Sorry, I'm not very accustomed to mailing list development. I had assumed > that this was being threaded with the other messages in the series, hence > leaving the subject blank and only putting new info in the body. The openness of a mailing list-centric development is that everybody with an email address can participate [*1*]. The downside is that *anybody* with *any* mail program can be a reader, so you cannot assume *anything* about how people will read your mails. Some will read it in a mail program that color-codes levels of quotation. Others will not have any color whatsoever. Some thread. Some don't. In most mail programs, you cannot even search for a Message-ID. Which can be non-unique. So the perceived benefits of this way to run a project come at a price. > In the future I'll add in an appropriate subject and brief re-hash in the > body. Thanks for bringing it up. Thank you, Johannes Footnote *1*: Of course, it is not *all* that open. If you cannot convince your mail program to send mails in plain text only, and to stop reformatting mails e.g. to make them look better on cell phones (refusing this is the price of requiring patches to be sent in whitespace-preserving plain text emails), then you're not invited to the party. This is why I sometimes say, not altogether without reason, that you can use *any* mail program to participate in the Git project as long as it is `mutt`.
From: Nickolai Belakovski <nbelakovski@gmail.com> Added test_i18ncmp per instructions from Szeder Is there some other part of the infrastructure that's testing for this? Because it did not fail in any of my Travis CI builds. Travis CI results: https://travis-ci.org/nbelakovski/git/builds/525801210 Nickolai Belakovski (3): ref-filter: add worktreepath atom branch: update output to include worktree info branch: add worktree info on verbose output Documentation/git-branch.txt | 12 ++++-- Documentation/git-for-each-ref.txt | 5 +++ builtin/branch.c | 16 ++++++-- ref-filter.c | 78 ++++++++++++++++++++++++++++++++++++++ t/t3200-branch.sh | 16 +++++--- t/t3203-branch-output.sh | 43 ++++++++++++++++++++- t/t6302-for-each-ref-filter.sh | 13 +++++++ 7 files changed, 168 insertions(+), 15 deletions(-)