mbox series

[00/14] soundwire: more code cleanups

Message ID 20190502105930.9889-1-vkoul@kernel.org (mailing list archive)
Headers show
Series soundwire: more code cleanups | expand

Message

Vinod Koul May 2, 2019, 10:59 a.m. UTC 
After applying cleanup from Pierre, I realized few more things can be
cleaned up as well, so fixing these instance in the subsystem.

Looks like bool is no longer encouraged, but I have skipped those and few
alignment as they caused code to look worse.

Greg,
if you are okay I would like to add this as well (i know it is late, but
they are cosmetic changes and no logic ones, let me know and I can
send a updated PR)

Vinod Koul (14):
  soundwire: fix kconfig help format
  soundwire: fix SPDX license for header files
  soundwire: intel: fix SPDX license for header file
  soundwire: remove empty line before/after braces
  soundwire: cadence: remove empty line after braces
  soundwire: intel: remove empty line after braces
  soundwire: add argument to function definition
  soundwire: more alignment fixes
  soundwire: intel: more alignment fixes
  soundwire: avoid multiple assignments
  soundwire: fix more typos
  soundwire: wrap macro argument in parenthesis
  soundwire: add a blank line between functions
  soundwire: remove multiple blank lines

 drivers/soundwire/Kconfig               |  2 +-
 drivers/soundwire/bus.c                 | 17 +++++-------
 drivers/soundwire/cadence_master.c      |  1 -
 drivers/soundwire/intel.c               | 36 ++++++++++++-------------
 drivers/soundwire/intel_init.c          |  1 -
 drivers/soundwire/mipi_disco.c          |  6 -----
 drivers/soundwire/stream.c              | 28 +++++++++----------
 include/linux/soundwire/sdw.h           | 16 +++++------
 include/linux/soundwire/sdw_intel.h     |  6 ++---
 include/linux/soundwire/sdw_registers.h |  5 ++--
 include/linux/soundwire/sdw_type.h      |  6 ++---
 11 files changed, 54 insertions(+), 70 deletions(-)

Comments

Greg KH May 2, 2019, 3:10 p.m. UTC | #1 
On Thu, May 02, 2019 at 04:29:16PM +0530, Vinod Koul wrote:
> After applying cleanup from Pierre, I realized few more things can be
> cleaned up as well, so fixing these instance in the subsystem.

I do not see any of Pierre's patches in here, only yours :(

I'll go queue his up first, and then see what is remaining in this
series...

greg k-h
Greg KH May 2, 2019, 3:19 p.m. UTC | #2 
On Thu, May 02, 2019 at 04:29:16PM +0530, Vinod Koul wrote:
> After applying cleanup from Pierre, I realized few more things can be
> cleaned up as well, so fixing these instance in the subsystem.
> 
> Looks like bool is no longer encouraged, but I have skipped those and few
> alignment as they caused code to look worse.
> 
> Greg,
> if you are okay I would like to add this as well (i know it is late, but
> they are cosmetic changes and no logic ones, let me know and I can
> send a updated PR)

This made no sense, as it was on top of Pierre's patches.

I've applied both his, and your, patch series to the tree now, hopefully
this type of mess doesn't happen again in the future.

Please be a lot more specific as to what you expect me to do with a
patch series, and what exactly it is for/against/after, as this was not
obvious at all.

ugh, someone owes me a drink...

greg k-h
Pierre-Louis Bossart May 2, 2019, 3:42 p.m. UTC | #3 
On 5/2/19 10:19 AM, Greg KH wrote:
> On Thu, May 02, 2019 at 04:29:16PM +0530, Vinod Koul wrote:
>> After applying cleanup from Pierre, I realized few more things can be
>> cleaned up as well, so fixing these instance in the subsystem.
>>
>> Looks like bool is no longer encouraged, but I have skipped those and few
>> alignment as they caused code to look worse.
>>
>> Greg,
>> if you are okay I would like to add this as well (i know it is late, but
>> they are cosmetic changes and no logic ones, let me know and I can
>> send a updated PR)
> 
> This made no sense, as it was on top of Pierre's patches.
> 
> I've applied both his, and your, patch series to the tree now, hopefully
> this type of mess doesn't happen again in the future.
> 
> Please be a lot more specific as to what you expect me to do with a
> patch series, and what exactly it is for/against/after, as this was not
> obvious at all.
> 
> ugh, someone owes me a drink...
> 
> greg k-h

I'll be glad to buy a round at the next ELC.

I also boiled initially when I saw the Kconfig patch until I realized it 
was a different patch. Same for the SPDX files. It wasn't obvious from a 
quick review and I could have been the one sending a nasty email.

There are additional cleanups from Vinod that I saw but didn't fix as I 
wasn't sure they made the code readable (e.g. dev_dbg logs exceeding 80 
chars and newlines after loops), but I also missed others that are very 
much needed, so please add my Rvb tag for this 'more code cleanups' series.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thank you Vinod for the additional work. I am almost done with the 
sysfs/debugfs cleanups and should post that next week.