mbox series

[v4,0/4] vmw_balloon: Compaction and shrinker support

Message ID 20190425115445.20815-1-namit@vmware.com (mailing list archive)
Headers show
Series vmw_balloon: Compaction and shrinker support | expand

Message

Nadav Amit April 25, 2019, 11:54 a.m. UTC
VMware balloon enhancements: adding support for memory compaction,
memory shrinker (to prevent OOM) and splitting of refused pages to
prevent recurring inflations.

Patches 1-2: Support for compaction
Patch 3: Support for memory shrinker - disabled by default
Patch 4: Split refused pages to improve performance

v3->v4:
* "get around to" comment [Michael]
* Put list_add under page lock [Michael]

v2->v3:
* Fixing wrong argument type (int->size_t) [Michael]
* Fixing a comment (it) [Michael]
* Reinstating the BUG_ON() when page is locked [Michael] 

v1->v2:
* Return number of pages in list enqueue/dequeue interfaces [Michael]
* Removed first two patches which were already merged

Nadav Amit (4):
  mm/balloon_compaction: List interfaces
  vmw_balloon: Compaction support
  vmw_balloon: Add memory shrinker
  vmw_balloon: Split refused pages

 drivers/misc/Kconfig               |   1 +
 drivers/misc/vmw_balloon.c         | 489 ++++++++++++++++++++++++++---
 include/linux/balloon_compaction.h |   4 +
 mm/balloon_compaction.c            | 144 ++++++---
 4 files changed, 553 insertions(+), 85 deletions(-)

Comments

Nadav Amit May 4, 2019, 1:25 a.m. UTC | #1
> On Apr 25, 2019, at 4:54 AM, Nadav Amit <namit@vmware.com> wrote:
> 
> VMware balloon enhancements: adding support for memory compaction,
> memory shrinker (to prevent OOM) and splitting of refused pages to
> prevent recurring inflations.
> 
> Patches 1-2: Support for compaction
> Patch 3: Support for memory shrinker - disabled by default
> Patch 4: Split refused pages to improve performance
> 
> v3->v4:
> * "get around to" comment [Michael]
> * Put list_add under page lock [Michael]
> 
> v2->v3:
> * Fixing wrong argument type (int->size_t) [Michael]
> * Fixing a comment (it) [Michael]
> * Reinstating the BUG_ON() when page is locked [Michael] 
> 
> v1->v2:
> * Return number of pages in list enqueue/dequeue interfaces [Michael]
> * Removed first two patches which were already merged
> 
> Nadav Amit (4):
>  mm/balloon_compaction: List interfaces
>  vmw_balloon: Compaction support
>  vmw_balloon: Add memory shrinker
>  vmw_balloon: Split refused pages
> 
> drivers/misc/Kconfig               |   1 +
> drivers/misc/vmw_balloon.c         | 489 ++++++++++++++++++++++++++---
> include/linux/balloon_compaction.h |   4 +
> mm/balloon_compaction.c            | 144 ++++++---
> 4 files changed, 553 insertions(+), 85 deletions(-)
> 
> -- 
> 2.19.1

Ping.
Nadav Amit May 17, 2019, 5:10 p.m. UTC | #2
> On May 3, 2019, at 6:25 PM, Nadav Amit <namit@vmware.com> wrote:
> 
>> On Apr 25, 2019, at 4:54 AM, Nadav Amit <namit@vmware.com> wrote:
>> 
>> VMware balloon enhancements: adding support for memory compaction,
>> memory shrinker (to prevent OOM) and splitting of refused pages to
>> prevent recurring inflations.
>> 
>> Patches 1-2: Support for compaction
>> Patch 3: Support for memory shrinker - disabled by default
>> Patch 4: Split refused pages to improve performance
>> 
>> v3->v4:
>> * "get around to" comment [Michael]
>> * Put list_add under page lock [Michael]
>> 
>> v2->v3:
>> * Fixing wrong argument type (int->size_t) [Michael]
>> * Fixing a comment (it) [Michael]
>> * Reinstating the BUG_ON() when page is locked [Michael] 
>> 
>> v1->v2:
>> * Return number of pages in list enqueue/dequeue interfaces [Michael]
>> * Removed first two patches which were already merged
>> 
>> Nadav Amit (4):
>> mm/balloon_compaction: List interfaces
>> vmw_balloon: Compaction support
>> vmw_balloon: Add memory shrinker
>> vmw_balloon: Split refused pages
>> 
>> drivers/misc/Kconfig               |   1 +
>> drivers/misc/vmw_balloon.c         | 489 ++++++++++++++++++++++++++---
>> include/linux/balloon_compaction.h |   4 +
>> mm/balloon_compaction.c            | 144 ++++++---
>> 4 files changed, 553 insertions(+), 85 deletions(-)
>> 
>> -- 
>> 2.19.1
> 
> Ping.

Ping.

Greg, did it got lost again?
Greg KH May 17, 2019, 5:24 p.m. UTC | #3
On Fri, May 17, 2019 at 05:10:23PM +0000, Nadav Amit wrote:
> > On May 3, 2019, at 6:25 PM, Nadav Amit <namit@vmware.com> wrote:
> > 
> >> On Apr 25, 2019, at 4:54 AM, Nadav Amit <namit@vmware.com> wrote:
> >> 
> >> VMware balloon enhancements: adding support for memory compaction,
> >> memory shrinker (to prevent OOM) and splitting of refused pages to
> >> prevent recurring inflations.
> >> 
> >> Patches 1-2: Support for compaction
> >> Patch 3: Support for memory shrinker - disabled by default
> >> Patch 4: Split refused pages to improve performance
> >> 
> >> v3->v4:
> >> * "get around to" comment [Michael]
> >> * Put list_add under page lock [Michael]
> >> 
> >> v2->v3:
> >> * Fixing wrong argument type (int->size_t) [Michael]
> >> * Fixing a comment (it) [Michael]
> >> * Reinstating the BUG_ON() when page is locked [Michael] 
> >> 
> >> v1->v2:
> >> * Return number of pages in list enqueue/dequeue interfaces [Michael]
> >> * Removed first two patches which were already merged
> >> 
> >> Nadav Amit (4):
> >> mm/balloon_compaction: List interfaces
> >> vmw_balloon: Compaction support
> >> vmw_balloon: Add memory shrinker
> >> vmw_balloon: Split refused pages
> >> 
> >> drivers/misc/Kconfig               |   1 +
> >> drivers/misc/vmw_balloon.c         | 489 ++++++++++++++++++++++++++---
> >> include/linux/balloon_compaction.h |   4 +
> >> mm/balloon_compaction.c            | 144 ++++++---
> >> 4 files changed, 553 insertions(+), 85 deletions(-)
> >> 
> >> -- 
> >> 2.19.1
> > 
> > Ping.
> 
> Ping.
> 
> Greg, did it got lost again?


I thought you needed the mm developers to ack the first patch, did that
ever happen?
Nadav Amit May 17, 2019, 5:57 p.m. UTC | #4
> On May 17, 2019, at 10:24 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Fri, May 17, 2019 at 05:10:23PM +0000, Nadav Amit wrote:
>>> On May 3, 2019, at 6:25 PM, Nadav Amit <namit@vmware.com> wrote:
>>> 
>>>> On Apr 25, 2019, at 4:54 AM, Nadav Amit <namit@vmware.com> wrote:
>>>> 
>>>> VMware balloon enhancements: adding support for memory compaction,
>>>> memory shrinker (to prevent OOM) and splitting of refused pages to
>>>> prevent recurring inflations.
>>>> 
>>>> Patches 1-2: Support for compaction
>>>> Patch 3: Support for memory shrinker - disabled by default
>>>> Patch 4: Split refused pages to improve performance
>>>> 
>>>> v3->v4:
>>>> * "get around to" comment [Michael]
>>>> * Put list_add under page lock [Michael]
>>>> 
>>>> v2->v3:
>>>> * Fixing wrong argument type (int->size_t) [Michael]
>>>> * Fixing a comment (it) [Michael]
>>>> * Reinstating the BUG_ON() when page is locked [Michael] 
>>>> 
>>>> v1->v2:
>>>> * Return number of pages in list enqueue/dequeue interfaces [Michael]
>>>> * Removed first two patches which were already merged
>>>> 
>>>> Nadav Amit (4):
>>>> mm/balloon_compaction: List interfaces
>>>> vmw_balloon: Compaction support
>>>> vmw_balloon: Add memory shrinker
>>>> vmw_balloon: Split refused pages
>>>> 
>>>> drivers/misc/Kconfig               |   1 +
>>>> drivers/misc/vmw_balloon.c         | 489 ++++++++++++++++++++++++++---
>>>> include/linux/balloon_compaction.h |   4 +
>>>> mm/balloon_compaction.c            | 144 ++++++---
>>>> 4 files changed, 553 insertions(+), 85 deletions(-)
>>>> 
>>>> -- 
>>>> 2.19.1
>>> 
>>> Ping.
>> 
>> Ping.
>> 
>> Greg, did it got lost again?
> 
> 
> I thought you needed the mm developers to ack the first patch, did that
> ever happen?

Yes. You will see Michael Tsirkin’s “Acked-by" on it.
Greg KH May 17, 2019, 6:10 p.m. UTC | #5
On Fri, May 17, 2019 at 05:57:22PM +0000, Nadav Amit wrote:
> > On May 17, 2019, at 10:24 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Fri, May 17, 2019 at 05:10:23PM +0000, Nadav Amit wrote:
> >>> On May 3, 2019, at 6:25 PM, Nadav Amit <namit@vmware.com> wrote:
> >>> 
> >>>> On Apr 25, 2019, at 4:54 AM, Nadav Amit <namit@vmware.com> wrote:
> >>>> 
> >>>> VMware balloon enhancements: adding support for memory compaction,
> >>>> memory shrinker (to prevent OOM) and splitting of refused pages to
> >>>> prevent recurring inflations.
> >>>> 
> >>>> Patches 1-2: Support for compaction
> >>>> Patch 3: Support for memory shrinker - disabled by default
> >>>> Patch 4: Split refused pages to improve performance
> >>>> 
> >>>> v3->v4:
> >>>> * "get around to" comment [Michael]
> >>>> * Put list_add under page lock [Michael]
> >>>> 
> >>>> v2->v3:
> >>>> * Fixing wrong argument type (int->size_t) [Michael]
> >>>> * Fixing a comment (it) [Michael]
> >>>> * Reinstating the BUG_ON() when page is locked [Michael] 
> >>>> 
> >>>> v1->v2:
> >>>> * Return number of pages in list enqueue/dequeue interfaces [Michael]
> >>>> * Removed first two patches which were already merged
> >>>> 
> >>>> Nadav Amit (4):
> >>>> mm/balloon_compaction: List interfaces
> >>>> vmw_balloon: Compaction support
> >>>> vmw_balloon: Add memory shrinker
> >>>> vmw_balloon: Split refused pages
> >>>> 
> >>>> drivers/misc/Kconfig               |   1 +
> >>>> drivers/misc/vmw_balloon.c         | 489 ++++++++++++++++++++++++++---
> >>>> include/linux/balloon_compaction.h |   4 +
> >>>> mm/balloon_compaction.c            | 144 ++++++---
> >>>> 4 files changed, 553 insertions(+), 85 deletions(-)
> >>>> 
> >>>> -- 
> >>>> 2.19.1
> >>> 
> >>> Ping.
> >> 
> >> Ping.
> >> 
> >> Greg, did it got lost again?
> > 
> > 
> > I thought you needed the mm developers to ack the first patch, did that
> > ever happen?
> 
> Yes. You will see Michael Tsirkin’s “Acked-by" on it.

Ah, missed that, thanks.  Will queue this up after the -rc1 release is
out, can't do anything until then.

greg k-h