| Message ID | 1556265512-9130-9-git-send-email-yibin.gong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add ecspi ERR009165 for i.mx6/7 soc family | expand |
On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > --- > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > index 2d32641..32c4263d 100644 > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > @@ -10,6 +10,8 @@ Required properties: > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc > + (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf) What about other i.MX6 chips? Seems like this is missing some fallbacks. The binding doc should make it clear what are all valid combinations of compatible strings. > - "fsl,imx8mq-ecspi" for SPI compatible with the one integrated on i.MX8M > - reg : Offset and length of the register set for the device > - interrupts : Should contain CSPI/eCSPI interrupt > -- > 2.7.4 >
On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > --- > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > index 2d32641..32c4263d 100644 > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > @@ -10,6 +10,8 @@ Required properties: > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc > + (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf) I wouldn't mention this errata in the binding documentation. Just state that fsl,imx6ul-ecspi is designed to be used on i.MX6UL. And that it might also be used on later SoCs as a "fallback compatible" is a detail that is so common that I would expect it not being worth mentioning. So for me it would also be OK to drop "fsl,imx53-ecspi" from the list as this is only used like: compatible = "fsl,imx53-ecspi", "fsl,imx51-ecspi"; (But note that I have no authority here.) Best regards Uwe
> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > --- > > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > index 2d32641..32c4263d 100644 > > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > @@ -10,6 +10,8 @@ Required properties: > > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 > > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 > > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on > > i.MX53 and later Soc > > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc > > + > > + (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw > > + > ww.nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=02%7C01 > %7Cyi > > + > bin.gong%40nxp.com%7Cc36708a8219843ffe1d308d6cecbc512%7C686ea1d > 3bc2b > > + > 4c6fa92cd99c5c301635%7C0%7C1%7C636923771907346428&sdata=9e > 8c8GK2 > > + hSE90rzyArm8elog9dwNqn4Jeoeff79XwI4%3D&reserved=0) > > I wouldn't mention this errata in the binding documentation. Just state that > fsl,imx6ul-ecspi is designed to be used on i.MX6UL. And that it might also be > used on later SoCs as a "fallback compatible" is a detail that is so common that Eh...Maybe add one flag member in 'struct spi_imx_devtype_data' to state errata fixed is better? > I would expect it not being worth mentioning. So for me it would also be OK to > drop "fsl,imx53-ecspi" from the list as this is only used like: > > compatible = "fsl,imx53-ecspi", "fsl,imx51-ecspi"; > > (But note that I have no authority here.) > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe > ngutronix.de%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7Cc36708 > a8219843ffe1d308d6cecbc512%7C686ea1d3bc2b4c6fa92cd99c5c301635%7 > C0%7C1%7C636923771907346428&sdata=McF9ueExCPpCq5Nxa6iJ9h53 > 9d9fO4DIW2IaS90ZdpQ%3D&reserved=0 |
> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > --- > > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > index 2d32641..32c4263d 100644 > > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > > @@ -10,6 +10,8 @@ Required properties: > > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 > > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 > > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on > > i.MX53 and later Soc > > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc > > + > > + (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw > > + > ww.nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=02%7C01 > %7Cyi > > + > bin.gong%40nxp.com%7C1eb9b302759b4af6fbe408d6ce709b8b%7C686ea1d > 3bc2b > > + > 4c6fa92cd99c5c301635%7C0%7C1%7C636923380371230101&sdata=% > 2BxM9fN > > + 6aEFkNlY5KU9qNiqqFMuDEfqGNrzADDiPO9gQ%3D&reserved=0) > > What about other i.MX6 chips? I only state in the cover letter of this patch set, for i.mx6q/dl/sl/sx still need this errata which is fixed i.mx chips after i.mx6ul including i.mx6ull,i.mx8m,i.mx8mm. I'll double confirm again and describe it clearly in commit log in v3. > > Seems like this is missing some fallbacks. The binding doc should make it clear > what are all valid combinations of compatible strings. In another Uwe's comment, I'm thinking move such errata information into spi driver level which makes binding doc clear. What do you think? > > > - "fsl,imx8mq-ecspi" for SPI compatible with the one integrated on > > i.MX8M > > - reg : Offset and length of the register set for the device > > - interrupts : Should contain CSPI/eCSPI interrupt > > -- > > 2.7.4 > >
diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt index 2d32641..32c4263d 100644 --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt @@ -10,6 +10,8 @@ Required properties: - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc + (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf) - "fsl,imx8mq-ecspi" for SPI compatible with the one integrated on i.MX8M - reg : Offset and length of the register set for the device - interrupts : Should contain CSPI/eCSPI interrupt
ERR009165 fixed from i.mx6ul, add it to show the errata fixed. Signed-off-by: Robin Gong <yibin.gong@nxp.com> --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ 1 file changed, 2 insertions(+)