| Message ID | a8bebd8db2727b8b95edcee613f39b90fa93daff.1557154206.git-series.marmarek@invisiblethingslab.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fixes for large framebuffer, placed above 4GB | expand |
Am Mon, 6 May 2019 16:50:19 +0200 schrieb Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>: > The limit 1900x1200 do not match real world devices (1900 looks like a > typo, should be 1920). But in practice the limits are arbitrary and do > not serve any real purpose. As discussed in "Increase framebuffer size > to todays standards" thread, drop them completely. ACK for the idea. Olaf
On 06/05/2019 15:50, Marek Marczykowski-Górecki wrote: > The limit 1900x1200 do not match real world devices (1900 looks like a > typo, should be 1920). But in practice the limits are arbitrary and do > not serve any real purpose. As discussed in "Increase framebuffer size > to todays standards" thread, drop them completely. > > This fixes graphic console on device with 3840x2160 native resolution. > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> On 06.05.19 at 16:50, <marmarek@invisiblethingslab.com> wrote: > The limit 1900x1200 do not match real world devices (1900 looks like a > typo, should be 1920). But in practice the limits are arbitrary and do > not serve any real purpose. As discussed in "Increase framebuffer size > to todays standards" thread, drop them completely. > > This fixes graphic console on device with 3840x2160 native resolution. > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> And unless I'm mis-remembering again Suggested-by: Jan Beulich <jbeulich@suse.com> Jan
diff --git a/xen/drivers/video/lfb.c b/xen/drivers/video/lfb.c index 0475a68..5022195 100644 --- a/xen/drivers/video/lfb.c +++ b/xen/drivers/video/lfb.c @@ -10,9 +10,6 @@ #include "lfb.h" #include "font.h" -#define MAX_XRES 1900 -#define MAX_YRES 1200 - struct lfb_status { struct lfb_prop lfbp; @@ -146,13 +143,6 @@ void lfb_carriage_return(void) int __init lfb_init(struct lfb_prop *lfbp) { - if ( lfbp->width > MAX_XRES || lfbp->height > MAX_YRES ) - { - printk(XENLOG_WARNING "Couldn't initialize a %ux%u framebuffer early.\n", - lfbp->width, lfbp->height); - return -EINVAL; - } - lfb.lfbp = *lfbp; lfb.lbuf = xmalloc_bytes(lfb.lfbp.bytes_per_line);
The limit 1900x1200 do not match real world devices (1900 looks like a typo, should be 1920). But in practice the limits are arbitrary and do not serve any real purpose. As discussed in "Increase framebuffer size to todays standards" thread, drop them completely. This fixes graphic console on device with 3840x2160 native resolution. Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> --- Cc: Olaf Hering <olaf@aepfle.de> --- xen/drivers/video/lfb.c | 10 ---------- 1 file changed, 10 deletions(-)