| Message ID | 418abbd5-f01c-19ef-c9f2-7de5662f10a2@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4c88519133bdd802fb0df4707b5a8c066af7154d |
| Headers | show |
| Series | ASoC: sound/soc/sof/: fix kconfig dependency warning | expand |
On 5/6/19 2:01 PM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix kconfig warning for unmet dependency for IOSF_MBI when > PCI is not set/enabled. Fixes this warning: > > WARNING: unmet direct dependencies detected for IOSF_MBI > Depends on [n]: PCI [=n] > Selected by [y]: > - SND_SOC_SOF_ACPI [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_SOF_TOPLEVEL [=y] && (ACPI [=y] || COMPILE_TEST [=n]) && X86 [=y] > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> I completely forgot to mirror the change in sound/soc/intel/Kconfig for IOSF support (ASoC: Intel: atom: Make PCI dependency explicit) for the same issue that ACPI no longer depends on PCI, thanks Randy for spotting this. > --- > sound/soc/sof/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20190506.orig/sound/soc/sof/Kconfig > +++ linux-next-20190506/sound/soc/sof/Kconfig > @@ -28,7 +28,7 @@ config SND_SOC_SOF_ACPI > select SND_SOC_ACPI if ACPI > select SND_SOC_SOF_OPTIONS > select SND_SOC_SOF_INTEL_ACPI if SND_SOC_SOF_INTEL_TOPLEVEL > - select IOSF_MBI if X86 > + select IOSF_MBI if X86 && PCI > help > This adds support for ACPI enumeration. This option is required > to enable Intel Haswell/Broadwell/Baytrail/Cherrytrail devices > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
--- linux-next-20190506.orig/sound/soc/sof/Kconfig +++ linux-next-20190506/sound/soc/sof/Kconfig @@ -28,7 +28,7 @@ config SND_SOC_SOF_ACPI select SND_SOC_ACPI if ACPI select SND_SOC_SOF_OPTIONS select SND_SOC_SOF_INTEL_ACPI if SND_SOC_SOF_INTEL_TOPLEVEL - select IOSF_MBI if X86 + select IOSF_MBI if X86 && PCI help This adds support for ACPI enumeration. This option is required to enable Intel Haswell/Broadwell/Baytrail/Cherrytrail devices