diff mbox series

dt-binding: usb: add usb-role-switch property

Message ID 5756e05930f5e6a3940ad9d019399c8e63d24f18.1556454324.git.chunfeng.yun@mediatek.com (mailing list archive)
State Superseded
Headers show
Series dt-binding: usb: add usb-role-switch property | expand

Commit Message

Chunfeng Yun (云春峰) April 28, 2019, 12:27 p.m. UTC
Add a property usb-role-switch to tell Dual-Role controller driver
that use USB Role Switch framework to handle the role switch between
host mode and device mode, it's useful when the driver has already
supported other ways, such as extcon framework etc.

Cc: Biju Das <biju.das@bp.renesas.com>
Cc: Yu Chen <chenyu56@huawei.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v1:
the property is discussed in:
[v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property
https://patchwork.kernel.org/patch/10852497/

Mediatek and Hisilicon also try to use it:
[v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch
https://patchwork.kernel.org/patch/10918385/
[v4,6/6] usb: mtu3: register a USB Role Switch for dual role mode
https://patchwork.kernel.org/patch/10918367/

[v6,10/13] usb: dwc3: Registering a role switch in the DRD code
https://patchwork.kernel.org/patch/10909981/
---
 Documentation/devicetree/bindings/usb/generic.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring (Arm) May 2, 2019, 7:49 p.m. UTC | #1
On Sun, Apr 28, 2019 at 08:27:46PM +0800, Chunfeng Yun wrote:
> Add a property usb-role-switch to tell Dual-Role controller driver
> that use USB Role Switch framework to handle the role switch between
> host mode and device mode, it's useful when the driver has already
> supported other ways, such as extcon framework etc.
> 
> Cc: Biju Das <biju.das@bp.renesas.com>
> Cc: Yu Chen <chenyu56@huawei.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v1:
> the property is discussed in:
> [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property
> https://patchwork.kernel.org/patch/10852497/
> 
> Mediatek and Hisilicon also try to use it:
> [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch
> https://patchwork.kernel.org/patch/10918385/
> [v4,6/6] usb: mtu3: register a USB Role Switch for dual role mode
> https://patchwork.kernel.org/patch/10918367/
> 
> [v6,10/13] usb: dwc3: Registering a role switch in the DRD code
> https://patchwork.kernel.org/patch/10909981/
> ---
>  Documentation/devicetree/bindings/usb/generic.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt
> index 0a74ab8dfdc2..c73950b72513 100644
> --- a/Documentation/devicetree/bindings/usb/generic.txt
> +++ b/Documentation/devicetree/bindings/usb/generic.txt
> @@ -30,6 +30,9 @@ Optional properties:
>  			optional for OTG device.
>   - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is
>  			optional for OTG device.
> + - usb-role-switch: tells Dual-Role USB controller driver that we want to use
> +			USB Role Switch framework to handle the role switch
> +			between host mode and device mode.

Please describe this in terms of h/w functionality, not drivers and 
Linux things.

Rob
Chunfeng Yun (云春峰) May 7, 2019, 2:26 a.m. UTC | #2
On Thu, 2019-05-02 at 14:49 -0500, Rob Herring wrote:
> On Sun, Apr 28, 2019 at 08:27:46PM +0800, Chunfeng Yun wrote:
> > Add a property usb-role-switch to tell Dual-Role controller driver
> > that use USB Role Switch framework to handle the role switch between
> > host mode and device mode, it's useful when the driver has already
> > supported other ways, such as extcon framework etc.
> > 
> > Cc: Biju Das <biju.das@bp.renesas.com>
> > Cc: Yu Chen <chenyu56@huawei.com>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v1:
> > the property is discussed in:
> > [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property
> > https://patchwork.kernel.org/patch/10852497/
> > 
> > Mediatek and Hisilicon also try to use it:
> > [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch
> > https://patchwork.kernel.org/patch/10918385/
> > [v4,6/6] usb: mtu3: register a USB Role Switch for dual role mode
> > https://patchwork.kernel.org/patch/10918367/
> > 
> > [v6,10/13] usb: dwc3: Registering a role switch in the DRD code
> > https://patchwork.kernel.org/patch/10909981/
> > ---
> >  Documentation/devicetree/bindings/usb/generic.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt
> > index 0a74ab8dfdc2..c73950b72513 100644
> > --- a/Documentation/devicetree/bindings/usb/generic.txt
> > +++ b/Documentation/devicetree/bindings/usb/generic.txt
> > @@ -30,6 +30,9 @@ Optional properties:
> >  			optional for OTG device.
> >   - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is
> >  			optional for OTG device.
> > + - usb-role-switch: tells Dual-Role USB controller driver that we want to use
> > +			USB Role Switch framework to handle the role switch
> > +			between host mode and device mode.
> 
> Please describe this in terms of h/w functionality, not drivers and 
> Linux things.
Sorry for the late reply, v2 is posted

> 
> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt
index 0a74ab8dfdc2..c73950b72513 100644
--- a/Documentation/devicetree/bindings/usb/generic.txt
+++ b/Documentation/devicetree/bindings/usb/generic.txt
@@ -30,6 +30,9 @@  Optional properties:
 			optional for OTG device.
  - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is
 			optional for OTG device.
+ - usb-role-switch: tells Dual-Role USB controller driver that we want to use
+			USB Role Switch framework to handle the role switch
+			between host mode and device mode.
 
 This is an attribute to a USB controller such as: